Re: [dev-servo] Build flavors and defaults

2015-02-26 Thread Lars Bergstrom
Do you think that making us clear all the warnings will make rust upgrades even more painful? Today we tend to leave the warnings (and mark them as E-Easy bugs), since it shaves a day or two off of landing the rustup, during which time the tree would have been locked. Also, I was thinking about

Re: [dev-servo] Build flavors and defaults

2015-02-26 Thread Glenn Watson
If we build release mode on the builders, perhaps we could re-enable "warnings as errors", but for release builds only. This would mean you can develop in debug mode locally with warnings, but bors won't merge any PRs that introduce warnings? On 25/02/15 00:12, Lars Bergstrom wrote: Two que

Re: [dev-servo] Build flavors and defaults

2015-02-24 Thread Ms2ger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/24/2015 03:12 PM, Lars Bergstrom wrote: > Two questions about build flavors. > > 1) Should we change the default build type back from debug to > release? > > When we made the switch to cargo, we changed to debug builds by > default, which mad

Re: [dev-servo] Build flavors and defaults

2015-02-24 Thread Manish Goregaokar
For Linux: Linux1 (build, unit, content, ref): - Debug - 24:13 - Release - 32:24 Linux2 (build, wpt, cef) - Debug - 28:00

Re: [dev-servo] Build flavors and defaults

2015-02-24 Thread Manish Goregaokar
I added a set of builders (not hooked up with bors) to saltfs: https://github.com/servo/saltfs/pull/15 If we merge that, we should be able to time it. -Manish Goregaokar On Tue, Feb 24, 2015 at 10:00 PM, Manish Goregaokar wrote: > With wpt? I think they're mostly the same, since wpt on a debu

Re: [dev-servo] Build flavors and defaults

2015-02-24 Thread Manish Goregaokar
With wpt? I think they're mostly the same, since wpt on a debug is slower but building on debug is faster. But it may not still be the case, when I ran some numbers on it in the days of travis the numbers didn't follow any clear patte

Re: [dev-servo] Build flavors and defaults

2015-02-24 Thread Jack Moffitt
I'm +1 to make ./mach build do release builds and add new --debug flags. Also I think Manish's idea of triggering a daily debug build seems like a good idea. However, what is the current time difference between debug and release builds these days? jack. On Tue, Feb 24, 2015 at 7:21 AM, Manish Go

Re: [dev-servo] Build flavors and defaults

2015-02-24 Thread Manish Goregaokar
Perhaps make release the default target for ./mach build, with a servobuild thing so that devs can make the default debug again? For all other cases, have `--release` and `--debug` as flags. This way people trying it out get the smooth servo experience, but devs can continue to use fast compiling

[dev-servo] Build flavors and defaults

2015-02-24 Thread Lars Bergstrom
Two questions about build flavors. 1) Should we change the default build type back from debug to release? When we made the switch to cargo, we changed to debug builds by default, which made for some good “reduced build times” headlines, but has gotten me mail from externals evaluating Servo ask