Do you think that making us clear all the warnings will make rust upgrades even more painful? Today we tend to leave the warnings (and mark them as E-Easy bugs), since it shaves a day or two off of landing the rustup, during which time the tree would have been locked.
Also, I was thinking about it and I suspect we'll want to keep testing debug builds as well on all platforms and all tests. AFAIK, that's the only way to get integer overflow checking from rustc, so it'd be nice to ensure we are actually testing with that enabled, since overflow bugs account for a non-trivial number of security bugs. - Lars On Feb 24, 2015, at 3:11 PM, Glenn Watson <[email protected]> wrote: If we build release mode on the builders, perhaps we could re-enable "warnings as errors", but for release builds only. This would mean you can develop in debug mode locally with warnings, but bors won't merge any PRs that introduce warnings? On 25/02/15 00:12, Lars Bergstrom wrote: > Two questions about build flavors. > > 1) Should we change the default build type back from debug to release? > > When we made the switch to cargo, we changed to debug builds by default, > which made for some good “reduced build times” headlines, but has gotten me > mail from externals evaluating Servo asking why it’s so slow/choppy. It has > also tripped up internal folks doing performance or memory profiling more > than once. > > 2) Should the builders test release only or release and debug? > > We had release-only regressions during the last set of Rust and submodule > upgrades, which is really bad (e.g., right now, Servo release on OSX does not > display any content!). The only question in my mind here is whether we want > to test everything in release+debug, just test release, or mainly test > release but have a token debug build/test machine. > > _______________________________________________ > dev-servo mailing list > [email protected] > https://lists.mozilla.org/listinfo/dev-servo _______________________________________________ dev-servo mailing list [email protected] https://lists.mozilla.org/listinfo/dev-servo _______________________________________________ dev-servo mailing list [email protected] https://lists.mozilla.org/listinfo/dev-servo

