Re: [dev-servo] ./mach build vs. cargo build

2018-04-17 Thread Simon Sapin
On 05/04/18 18:21, Matt Brubeck wrote: We can set rustflags in the `[build]` section of .cargo/config: https://doc.rust-lang.org/cargo/reference/config.html I tried to do this for the unused extern crate warning (ld.gold can already be disabled through a `.servobuild` config) but hit https:/

Re: [dev-servo] ./mach build vs. cargo build

2018-04-05 Thread Matt Brubeck
We can set rustflags in the `[build]` section of .cargo/config: https://doc.rust-lang.org/cargo/reference/config.html On Wed, Apr 4, 2018 at 6:47 AM, Manish Goregaokar wrote: > IMO those reasons do not apply to toplevel flags; and given that Cargo > profiles are a thing we really should have a

Re: [dev-servo] ./mach build vs. cargo build

2018-04-04 Thread Manish Goregaokar
IMO those reasons do not apply to toplevel flags; and given that Cargo profiles are a thing we really should have a rustflags key there. I've always had trouble with getting IDEs working with servo because of this. -Manish Goregaokar On Wed, Apr 4, 2018 at 6:12 AM, Lars Bergstrom wrote: > Cargo

Re: [dev-servo] ./mach build vs. cargo build

2018-04-04 Thread Lars Bergstrom
Cargo has traditionally not wanted to add full support for arbitrary RUSTFLAGS, for reasonable reasons: https://github.com/rust-lang/cargo/issues/60#issuecomment-51705597 What we've done in the past is for each flag that we needed exposed opened a specific Issue or PR to Cargo to have just that on

Re: [dev-servo] ./mach build vs. cargo build

2018-04-03 Thread Simon Sapin
On 03/04/18 23:30, Emilio Cobos Álvarez wrote: or the bit to use the gold linker. The best outcome IMO would be to make that the default: https://github.com/rust-lang/rust/issues/30783 This was implemented and then reverted because of Debian Wheezy (oldoldstable), whose LTS ends next month

[dev-servo] ./mach build vs. cargo build

2018-04-03 Thread Emilio Cobos Álvarez
Hi, I was suggested to take this to the mailing list, so here I am. Right now doing ./mach build, then cargo build, or vice versa, causes a full rebuild, which is really painful[1]. The way to fix this is making mach build don't touch RUSTFLAGS, at least by default[2]. This requires making opt-