Re: [dev-servo] Tidy lints

2018-08-19 Thread Emilio Cobos Álvarez
On 8/19/18 9:54 PM, Josh Bowman-Matthews wrote: On 8/19/18 2:10 PM, Anthony Ramine wrote: We don't make use of rustfmt yet though (right? I was under a rock for 2 weeks so if I missed this excellent improvement, ignore me), so let's do that first IMO. Le 19 août 2018 à 19:43, Bobby Holley a

Re: [dev-servo] Tidy lints

2018-08-19 Thread Josh Bowman-Matthews
On 8/19/18 2:10 PM, Anthony Ramine wrote: We don't make use of rustfmt yet though (right? I was under a rock for 2 weeks so if I missed this excellent improvement, ignore me), so let's do that first IMO. Le 19 août 2018 à 19:43, Bobby Holley a écrit : rustfmt fits the bill, so I think it ma

Re: [dev-servo] Tidy lints

2018-08-19 Thread Anthony Ramine
We don't make use of rustfmt yet though (right? I was under a rock for 2 weeks so if I missed this excellent improvement, ignore me), so let's do that first IMO. > Le 19 août 2018 à 19:43, Bobby Holley a écrit : > > rustfmt fits the bill, so I think it makes sense to retire > that particular t

Re: [dev-servo] Tidy lints

2018-08-19 Thread Bobby Holley
Yeah. It's probably less important exactly what the order is and more that there's a canonical order that a tool can detect and automatically fix things to match. rustfmt fits the bill, so I think it makes sense to retire that particular tidy lint. On Sun, Aug 19, 2018 at 5:18 AM Anthony Ramine w

Re: [dev-servo] dev-servo Digest, Vol 78, Issue 3

2018-08-19 Thread Peter Hrvola
> On 19 Aug 2018, at 14:00, > wrote: > > Send dev-servo mailing list submissions to > dev-servo@lists.mozilla.org > > To subscribe or unsubscribe via the World Wide Web, visit > https://lists.mozilla.org/listinfo/dev-servo > or, via email, send a message with subject or body 'hel

Re: [dev-servo] Tidy lints

2018-08-19 Thread Anthony Ramine
I don't know, but if your question is "would you mind using a tool to automate that stuff instead of a lint that complains?" then my answer is "yes, I too don't enjoy reordering things by hand". > Le 19 août 2018 à 13:58, Emilio Cobos Álvarez a écrit : > > Can we enable import reordering in ru

Re: [dev-servo] Tidy lints

2018-08-19 Thread Emilio Cobos Álvarez
On 08/19/2018 11:17 AM, Anthony Ramine wrote: I personally think they are extremely useful, because if they don't exist I end up fixing order of things when I touch code around them. It's almost obsessive. Can we enable import reordering in rustfmt instead? -- Emilio

Re: [dev-servo] Tidy lints

2018-08-19 Thread Anthony Ramine
I personally think they are extremely useful, because if they don't exist I end up fixing order of things when I touch code around them. It's almost obsessive. That being said, it's 2018 and rustfix should be doing it for us. > Le 18 août 2018 à 18:28, Emilio Cobos Álvarez a écrit : > > Do peo