> On 19 Aug 2018, at 14:00, <[email protected]> > <[email protected]> wrote: > > Send dev-servo mailing list submissions to > [email protected] > > To subscribe or unsubscribe via the World Wide Web, visit > https://lists.mozilla.org/listinfo/dev-servo > or, via email, send a message with subject or body 'help' to > [email protected] > > You can reach the person managing the list at > [email protected] > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of dev-servo digest..." > > > Today's Topics: > > 1. Tidy lints (Emilio Cobos ?lvarez) > 2. Re: Tidy lints (Anthony Ramine) > 3. Re: Tidy lints (Emilio Cobos ?lvarez) > > > ---------------------------------------------------------------------- > > Message: 1 > Date: Sat, 18 Aug 2018 18:28:10 +0200 > From: Emilio Cobos ?lvarez <[email protected]> > To: [email protected] > Subject: [dev-servo] Tidy lints > Message-ID: <[email protected]> > Content-Type: text/plain; charset=utf-8; format=flowed > > I don't think the following tidy lints are very useful, and they always > make me spend some extra time fixing them up every time I sync code from > mozilla-central: > > * #[derive] trait name order. > * Lints that check `use` statements. > > Do people generally find them useful? > > I don't really think they are, and given we don't have an automatic way > to fix them (something like `./mach test-tidy --fix`) I'd prefer to > remove them, or to make `style` at least not require them. My feeling is > that their usefulness is just too little to justify the amount of time I > (and I suspect others) end up battling them. > > What do you think? > > Thanks, > > -- Emilio > > > ------------------------------ > > Message: 2 > Date: Sun, 19 Aug 2018 11:17:02 +0200 > From: Anthony Ramine <[email protected]> > To: [email protected] > Subject: Re: [dev-servo] Tidy lints > Message-ID: <[email protected]> > Content-Type: text/plain; charset=utf-8 > > I personally think they are extremely useful, because if they don't exist I > end up fixing order of things when I touch code around them. It's almost > obsessive. > > That being said, it's 2018 and rustfix should be doing it for us. > >> Le 18 ao?t 2018 ? 18:28, Emilio Cobos ?lvarez <[email protected]> a ?crit : >> >> Do people generally find them useful? > > > > ------------------------------ > > Message: 3 > Date: Sun, 19 Aug 2018 13:58:56 +0200 > From: Emilio Cobos ?lvarez <[email protected]> > To: [email protected] > Subject: Re: [dev-servo] Tidy lints > Message-ID: <[email protected]> > Content-Type: text/plain; charset=utf-8; format=flowed > > On 08/19/2018 11:17 AM, Anthony Ramine wrote: >> I personally think they are extremely useful, because if they don't exist I >> end up fixing order of things when I touch code around them. It's almost >> obsessive. > > Can we enable import reordering in rustfmt instead? > > -- Emilio > > > ------------------------------ > > Subject: Digest Footer > > _______________________________________________ > dev-servo mailing list > [email protected] > https://lists.mozilla.org/listinfo/dev-servo > > > ------------------------------ > > End of dev-servo Digest, Vol 78, Issue 3 > ****************************************
I have been recently digging into this. Just enabling reordering in rustfmt won’t help. Mach tidy must be modified to do the same checking as rustfmt (they’re different). Cheers _______________________________________________ dev-servo mailing list [email protected] https://lists.mozilla.org/listinfo/dev-servo
