Re: [dev-servo] Fwd: Re: Suggested code review workflow

2016-02-23 Thread David Rajchenbach-Teller
In Gecko, I have taken the habit of requesting long messages when the patch is not self-contained. Plus, I am currently working on bugs that would have been much easier to puzzle out if we (well, if I) had explained in the long message why some changes were made. In other words, +1 for requesting

Re: [dev-servo] Fwd: Re: Suggested code review workflow

2016-02-23 Thread smaug
On 02/21/2016 02:02 AM, Boris Zbarsky wrote: On 2/20/16 5:10 PM, Josh Matthews wrote: (as a random comment, I never read multiline comments for Gecko. Only the first line + the bug number. It is the bug where the relevant information needs to be available. Whether it it available also elsewhere