Re: [dev-servo] Testing Reviewable for reviews

2015-04-16 Thread Lars Bergstrom
Thank you for trying it out and providing some feedback! How would you like to see the “cons” changed? I assume that for the first one, you are looking for Reviewable to show commits and changed files individually so that you can review each portion of a change instead of the squashed change. H

Re: [dev-servo] Testing Reviewable for reviews

2015-04-16 Thread Tetsuharu OHZEKI
I tried to use Reviewable in some pull request. I'll write some feedback of my feeling: pros: - The mascot icon is so cute (critic has no it!). It relaxes me when I open a pull request. :) - The comments showing up on Github is great! cons: - If a pull request has a multiple commits, Reviewable d

[dev-servo] PSA: content tests are being retired

2015-04-16 Thread Ms2ger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi all, I've converted the content tests into web platform tests in a Servo specific directory: tests/wpt/mozilla/tests/. You can run just those tests with ./mach test-wpt --include _mozilla; when adding a test, add the --manifest-update argument (thi