Thank you for trying it out and providing some feedback! How would you like to see the “cons” changed? I assume that for the first one, you are looking for Reviewable to show commits and changed files individually so that you can review each portion of a change instead of the squashed change.
How would you like the diffs changed? They have a couple of issues open (at https://github.com/Reviewable/Reviewable/issues ) about detecting file renames and moves of blocks, but are there other things that Critic does that you want to see in Reviewable? The author has been open to feature requests and fixes so far. Except, unfortunately, for fixing the choice of animations that cause Firefox to behave poorly - like the Travis UI, such a large portion of their users are on Chrome that they aren’t too interested in doing anything beyond offering the “disable Animate Transitions” option. Thanks again for trying this out! - Lars On Apr 16, 2015, at 5:33 AM, Tetsuharu OHZEKI <saneyuki.s...@gmail.com> wrote: I tried to use Reviewable in some pull request. I'll write some feedback of my feeling: pros: - The mascot icon is so cute (critic has no it!). It relaxes me when I open a pull request. :) - The comments showing up on Github is great! cons: - If a pull request has a multiple commits, Reviewable displays them as squashed into one commit. - This is very difficult point. There is no difference from Github's default diff view. - This will be great dis-advantage if we review a big pull request. Thanks! 2015-04-15 6:15 GMT+09:00 Lars Bergstrom <larsb...@mozilla.com>: > As was mentioned briefly in the meeting notes for this week > (https://github.com/servo/servo/wiki/Meeting-2015-04-13 > <https://github.com/servo/servo/wiki/Meeting-2015-04-13> ), we are trying a > new service, http://reviewable.io <http://reviewable.io/>, for performing our > reviews. This week, please make an effort to try out the tool for your > reviews by clicking on the large purple “review on reviewable” link in the PR > and let me know either via e-mail or IRC what you do and don’t like about it. > Comparisons to either Critic or the built-in GitHub review UI are welcome. > > I’m trying this out because: > - It handles rebases / force-pushes to PR branches automatically (easily our > #1 Critic failure point, especially for new contributors). > - The comments show up on GitHub & GitHub comments show up there, so there’s > no “two worlds” experience. > - I only need to feel guilty for begging jgraham to help with our Web > Platform Tests integration, and not both that AND our twice-weekly Critic > crises. > > Thanks, > - Lars > > _______________________________________________ > dev-servo mailing list > dev-servo@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-servo -- Tetsuharu OHZEKI _______________________________________________ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
