Re: [dev-servo] RFC: Rename "rendering" to "painting"

2014-01-30 Thread Brian Anderson
On 01/30/2014 10:25 AM, Patrick Walton wrote: Hi everyone, Preface: This is a total bikeshed. I was wondering whether we might want to rename "render" to "paint". The issue is that "render" means different things in different browser engines and so the term is kind of confusing. As far as I c

Re: [dev-servo] RFC: Rename "rendering" to "painting"

2014-01-30 Thread Boris Zbarsky
On 1/30/14 10:25 AM, Patrick Walton wrote: - "Reflow" (from Gecko; WebKit calls this "layout") "Geometry computation"? Or is that too long? The others seem pretty reasonable to me. -Boris ___ dev-servo mailing list dev-servo@lists.mozilla.org ht

[dev-servo] RFC: Rename "rendering" to "painting"

2014-01-30 Thread Patrick Walton
Hi everyone, Preface: This is a total bikeshed. I was wondering whether we might want to rename "render" to "paint". The issue is that "render" means different things in different browser engines and so the term is kind of confusing. As far as I can tell "render" in Gecko means either "layout

Re: [dev-servo] What is the best practice to polish commits in 1 pull request?

2014-01-30 Thread brunoabinader
On Thursday, January 30, 2014 11:04:52 AM UTC-4, Ms2ger wrote: > Right now, I've been requesting that people squash those commits > > before landing. That does lead to the additional overhead that kmc > > describes, but it makes reviewing a lot easier and the history cleaner. > > I think it wo

Re: [dev-servo] What is the best practice to polish commits in 1 pull request?

2014-01-30 Thread Ms2ger
On 01/30/2014 03:39 PM, Tetsuharu OHZEKI wrote: Hi everyone, I sometimes break up the critic's review by using `git commit --amend` to polish my commits. (I'm sorry) I read the issue (https://github.com/mozilla/servo/issues/1468) to learn how to polish commits, but I feel that it have not g

Re: [dev-servo] What is the best practice to polish commits in 1 pull request?

2014-01-30 Thread James Graham
On 30/01/14 14:39, Tetsuharu OHZEKI wrote: Hi everyone, I sometimes break up the critic's review by using `git commit --amend` to polish my commits. (I'm sorry) I read the issue (https://github.com/mozilla/servo/issues/1468) to learn how to polish commits, but I feel that it have not gotten

[dev-servo] What is the best practice to polish commits in 1 pull request?

2014-01-30 Thread Tetsuharu OHZEKI
Hi everyone, I sometimes break up the critic's review by using `git commit --amend` to polish my commits. (I'm sorry) I read the issue (https://github.com/mozilla/servo/issues/1468) to learn how to polish commits, but I feel that it have not gotten the consensus of the best practice to polish