On 01/30/2014 03:39 PM, Tetsuharu OHZEKI wrote:
Hi everyone,
I sometimes break up the critic's review by using `git commit --amend`
to polish my commits. (I'm sorry....)
I read the issue (https://github.com/mozilla/servo/issues/1468) to
learn how to polish commits, but I feel that it have not gotten the
consensus of the best practice to polish commits with your reviews.
So what is the "better" practice to concentrate our commits before
merge it like the reviewing custom in bugzilla@mozilla?
Right now, I've been requesting that people squash those commits
before landing. That does lead to the additional overhead that kmc
describes, but it makes reviewing a lot easier and the history cleaner.
I think it would be optimal if bors squashed automatically when merging.
I guess we need a volunteer to get that done.
HTH
Ms2ger
_______________________________________________
dev-servo mailing list
dev-servo@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-servo
