Re: testing event targets for memory leaks

2018-04-16 Thread Ben Kelly
PSA, I am landing additional leak tests for AudioContext IDB WebSocket As part of: https://bugzilla.mozilla.org/show_bug.cgi?id=1451913 On Thu, Apr 5, 2018 at 12:18 PM, Ben Kelly wrote: > Hi all, > > I recently landed some test infrastructure for testing event targets for

Re: testing event targets for memory leaks

2018-04-09 Thread Ben Kelly
On Mon, Apr 9, 2018 at 3:16 PM, Randell Jesup wrote: > I'm surprises that DOMDataChannel wasn't found: > nsDOMDataChannel.h: > class nsDOMDataChannel final : public mozilla::DOMEventTargetHelper, > > perhaps you were looking for "public DOMEventTargetHelper"? > Yep. That was indeed my lame se

Re: testing event targets for memory leaks

2018-04-09 Thread Randell Jesup
>Hi all, > >I recently landed some test infrastructure for testing event targets for >memory leaks. This was part of fixing my service worker memory leak in bug >1447871. I wanted to let people know this existed and also ask for help >writing tests for more event targets. &g

Re: testing event targets for memory leaks

2018-04-09 Thread Ben Kelly
On Mon, Apr 9, 2018 at 12:32 PM, Ben Kelly wrote: > On Mon, Apr 9, 2018 at 12:06 PM, Boris Zbarsky wrote: > >> On 4/5/18 1:11 PM, Ben Kelly wrote: >> >>> 1. Make sure you set the nsIGlobalObject owner by passing it to the DETH >>> constructor or by calling BindToOwner(). >>> >> >> Can we just en

Re: testing event targets for memory leaks

2018-04-09 Thread Ben Kelly
On Mon, Apr 9, 2018 at 12:06 PM, Boris Zbarsky wrote: > On 4/5/18 1:11 PM, Ben Kelly wrote: > >> 1. Make sure you set the nsIGlobalObject owner by passing it to the DETH >> constructor or by calling BindToOwner(). >> > > Can we just enforce that by: > > 1) Removing the no-arg constructor from DE

Re: testing event targets for memory leaks

2018-04-09 Thread Boris Zbarsky
On 4/5/18 1:11 PM, Ben Kelly wrote: 1. Make sure you set the nsIGlobalObject owner by passing it to the DETH constructor or by calling BindToOwner(). Can we just enforce that by: 1) Removing the no-arg constructor from DETH. 2) Making the arg-taking constructors MOZ_ASSERT that the arg is no

Re: testing event targets for memory leaks

2018-04-09 Thread Ben Kelly
On Thu, Apr 5, 2018 at 12:18 PM, Ben Kelly wrote: > If one of these targets falls in your area, please try to find the time to > write a small test as described above. Also, please link it against the > meta bug here: > > https://bugzilla.mozilla.org/show_bug.cgi?id=1451787 > Sorry to self-repl

testing event targets for memory leaks

2018-04-09 Thread Ben Kelly
Hi all, I recently landed some test infrastructure for testing event targets for memory leaks. This was part of fixing my service worker memory leak in bug 1447871. I wanted to let people know this existed and also ask for help writing tests for more event targets. To repeat, I need help