On Mon, Apr 9, 2018 at 12:32 PM, Ben Kelly <bke...@mozilla.com> wrote:
> On Mon, Apr 9, 2018 at 12:06 PM, Boris Zbarsky <bzbar...@mit.edu> wrote: > >> On 4/5/18 1:11 PM, Ben Kelly wrote: >> >>> 1. Make sure you set the nsIGlobalObject owner by passing it to the DETH >>> constructor or by calling BindToOwner(). >>> >> >> Can we just enforce that by: >> >> 1) Removing the no-arg constructor from DETH. >> 2) Making the arg-taking constructors MOZ_ASSERT that the arg is not >> null. >> >> ? We'd need to fix some existing code, but after that should hopefully >> be in a better place... >> > > This would be nice to do yes, but was out of scope for the time I had. I > also suspect, though, that the non-binding DETH constructor is used for > objects created using the separate Init() method pattern. Not sure if its > fair to try to convert all of those. > > Also keep in mind that binding to the global on a worker thread is > somewhat new. Many DETH objects only try to bind nsPIDOMWindowInner, but > it would be better to always bind nsIGlobalObject now. > > Anyway, we should probably file a bug to consider it. > Filed as: https://bugzilla.mozilla.org/show_bug.cgi?id=1452705 _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
