Re: c++ unit test in content process

2014-10-06 Thread Patrick Wang
I see. I'll try to write with a more end-to-end test framework then. Thank you. Patrick On 10/3/14 9:59 PM, Benjamin Smedberg wrote: > > On 10/3/2014 9:46 AM, Patrick Wang wrote: >> The test I am writing is to test an implementation of WebRTC's TCP >> socket in content process. These codes are b

Re: c++ unit test in content process

2014-10-06 Thread Kyle Huey
On Mon, Oct 6, 2014 at 8:21 AM, Jason Orendorff wrote: > That said, if you see ways to improve the situation, go strong. The reason > we have tests and a testing culture here at all is herculean efforts from > Rob Sayre and others who saw what needed doing and did it. srsly. That guy rocked. -

Re: c++ unit test in content process

2014-10-06 Thread Milan Sreckovic
And as “bad” as it is, it’s as good as it gets, and it will only get worse - unless we continue the efforts to make things better. Sometimes it’s a long haul, and you can’t get the approval to spend a lot of time digging out of some places, but often even small things help. -- - Milan On Oct

Re: c++ unit test in content process

2014-10-06 Thread Jason Orendorff
On 10/03/2014 08:59 AM, Benjamin Smedberg wrote: On 10/3/2014 9:46 AM, Patrick Wang wrote: The test I am writing is to test an implementation of WebRTC's TCP socket in content process. These codes are build on top of TCPSocket's IPDL in C++ and don't have IDL so it cannot be called directly fro

Re: c++ unit test in content process

2014-10-03 Thread Eric Rescorla
Sadly, the WebRTC gtest-based ones (e.g., media/webrtc/signaling/test) do. On Fri, Oct 3, 2014 at 6:04 AM, Kyle Huey wrote: > On Fri, Oct 3, 2014 at 5:44 AM, Benjamin Smedberg > wrote: > > > > On 10/3/2014 4:59 AM, Patrick Wang wrote: > >> > >> Hi, > >> > >> I am trying to write a C++ unit te

Re: c++ unit test in content process

2014-10-03 Thread Benjamin Smedberg
On 10/3/2014 9:46 AM, Patrick Wang wrote: The test I am writing is to test an implementation of WebRTC's TCP socket in content process. These codes are build on top of TCPSocket's IPDL in C++ and don't have IDL so it cannot be called directly from JS, and the tests for chrome process version are

Re: c++ unit test in content process

2014-10-03 Thread Patrick Wang
The test I am writing is to test an implementation of WebRTC's TCP socket in content process. These codes are build on top of TCPSocket's IPDL in C++ and don't have IDL so it cannot be called directly from JS, and the tests for chrome process version are written with gtest. Therefore I am thinking

Re: c++ unit test in content process

2014-10-03 Thread Kyle Huey
On Fri, Oct 3, 2014 at 5:44 AM, Benjamin Smedberg wrote: > > On 10/3/2014 4:59 AM, Patrick Wang wrote: >> >> Hi, >> >> I am trying to write a C++ unit test for code that runs in child >> process, but all c++ tests I found run in parent process. Is it possible >> to write a c++ test case that runs

Re: c++ unit test in content process

2014-10-03 Thread Benjamin Smedberg
On 10/3/2014 4:59 AM, Patrick Wang wrote: Hi, I am trying to write a C++ unit test for code that runs in child process, but all c++ tests I found run in parent process. Is it possible to write a c++ test case that runs in child process, or is there any example in our code? Could you be more s

c++ unit test in content process

2014-10-03 Thread Patrick Wang
Hi, I am trying to write a C++ unit test for code that runs in child process, but all c++ tests I found run in parent process. Is it possible to write a c++ test case that runs in child process, or is there any example in our code? Thanks, Patrick smime.p7s Description: S/MIME Cryptographic Si