Re: Unsafe CPOWs are about to be outlawed in browser code

2016-02-02 Thread Dmitry Gutov
On 02/02/2016 12:29 AM, Kris Maglione wrote: That falls into the category of "unless it is calling browser code and making it do something unsafe". That's too bad. I'm just reusing a querying function from there, and a pretty small one. If you need to use that function from the main proces

Re: Unsafe CPOWs are about to be outlawed in browser code

2016-02-01 Thread Kris Maglione
On Tue, Feb 02, 2016 at 01:39:00AM +0300, Dmitry Gutov wrote: On 02/02/2016 12:29 AM, Kris Maglione wrote: That falls into the category of "unless it is calling browser code and making it do something unsafe". That's too bad. I'm just reusing a querying function from there, and a pretty small

Re: Unsafe CPOWs are about to be outlawed in browser code

2016-02-01 Thread Kris Maglione
On Thu, Jan 28, 2016 at 06:30:03PM -0800, raa...@gmail.com wrote: Hi! My addon is reportedly broken in the Nightly: https://github.com/dgutov/bmreplace/issues/32#issuecomment-176126946 It imports PlacesUIUtils.jsm and calls three functions from it, most notably PlacesUIUtils.getDescriptionFr

Re: Unsafe CPOWs are about to be outlawed in browser code

2016-02-01 Thread raaahh
четверг, 28 января 2016 г., 19:57:59 UTC+3 пользователь Dave Townsend написал: > I don't think that this is meant to impact add-on code at all, unless > it is calling browser code and making it do something unsafe, in which > case it would be up to the add-on developer to fix that. It's probably >

Re: Unsafe CPOWs are about to be outlawed in browser code

2016-01-28 Thread Bill McCloskey
On Thu, Jan 28, 2016 at 10:16 AM, Mike Conley wrote: > Add-ons that are not yet marked multi-process compatible will use our > shimming layer, which allows usage of unsafe CPOWs within add-on code / > compartments. > > At least part of the problem here appears to be that FireGestures has > "multi

Re: Unsafe CPOWs are about to be outlawed in browser code

2016-01-28 Thread Mike Conley
Add-ons that are not yet marked multi-process compatible will use our shimming layer, which allows usage of unsafe CPOWs within add-on code / compartments. At least part of the problem here appears to be that FireGestures has "multiprocessCompatible" set to true in its install.rdf: https://github

Re: Unsafe CPOWs are about to be outlawed in browser code

2016-01-28 Thread Dave Townsend
I don't think that this is meant to impact add-on code at all, unless it is calling browser code and making it do something unsafe, in which case it would be up to the add-on developer to fix that. It's probably worth filing a bug to track what is going on there though. On Thu, Jan 28, 2016 at 6:3

Re: Unsafe CPOWs are about to be outlawed in browser code

2016-01-28 Thread Honza Bambas
Do we have any agenda for extensions? I'm using FireGestures and it's broken since this has landed, just shouting out a lot of "unsafe CPOW usage" (missing the "forbidden" tho). Is the action here limited to just file a bug on the add-on side to fix this or can we do anything on our side? (I

Re: Unsafe CPOWs are about to be outlawed in browser code

2016-01-27 Thread Mike Conley
The spaghetti was put in the machine last night - this work has now landed on mozilla-central. If you start seeing "unsafe CPOW usage forbidden" in the Browser Console for various things, please mark them blocking bug 1233497. Thanks all, -Mike On 20/01/2016 3:54 PM, Mike Conley wrote: > (cross

Unsafe CPOWs are about to be outlawed in browser code

2016-01-20 Thread Mike Conley
(cross-posted to both dev-platform and firefox-dev) TL;DR: Shortly, I’ll be flipping a pref to outlaw unsafe CPOWs in almost all browser code. Unsafe CPOWs inside add-on scopes should continue to work properly. If you start seeing "unsafe CPOW usage forbidden” errors being throw for a feature you