On Thu, Jan 28, 2016 at 06:30:03PM -0800, raa...@gmail.com wrote:
Hi!

My addon is reportedly broken in the Nightly: https://github.com/dgutov/bmreplace/issues/32#issuecomment-176126946

It imports PlacesUIUtils.jsm and calls three functions from it, most notably PlacesUIUtils.getDescriptionFromDocument.

How do I "fix" that in the addon, aside for doing the big transition to an E10s-friendly architecture?

That falls into the category of "unless it is calling browser code and making it do something unsafe".

If you need to use that function from the main process, you can only do so from the message listener for a synchronous message from the content process (or a few other similar situations).

While you're at it, though, it would be a good idea to make that function asynchronous, so that you can check the description from the content process, and look up whether the URL is bookmarked, without blocking the browser process.

--
Kris Maglione
Firefox Add-ons Engineer
Mozilla Corporation

It is well to know something of the manners of various peoples, in
order more sanely to judge our own, and that we do not think that
everything against our modes is ridiculous, and against reason, as
those who have seen nothing are accustomed to think.
        --Rene Descartes

_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to