Re: Using __declspec(thread) on Windows

2014-10-17 Thread Neil
Robert O'Callahan wrote: I assume no-one's finding the Firefox libxul.dll and loading it from their own .EXE I assume people are finding the XULRunner libxul.dll and loading it from their own .EXE -- Warning: May contain traces of nuts. ___ dev-

Re: Using __declspec(thread) on Windows

2014-10-16 Thread Mike Hommey
On Fri, Oct 17, 2014 at 10:10:57AM +1300, Robert O'Callahan wrote: > It would be cool to use fast TLS via __declspec(thread) on Windows (and > __thread on gcc/clang). Due to WinXP bustage that only works for variables > in the .EXE or in DLLs statically linked by the .EXE, so not libxul, but in > o

Re: Using __declspec(thread) on Windows

2014-10-16 Thread Robert O'Callahan
On Fri, Oct 17, 2014 at 10:45 AM, David Major wrote: > > in the .EXE or in DLLs statically linked by the .EXE, so not libxul, but > in > > our shipped Windows builds mozglue.dll is statically linked to > firefox.exe > > so we could put __declspec(thread) variables there. > > What does 'statically

Re: Using __declspec(thread) on Windows

2014-10-16 Thread David Major
> in the .EXE or in DLLs statically linked by the .EXE, so not libxul, but in > our shipped Windows builds mozglue.dll is statically linked to firefox.exe > so we could put __declspec(thread) variables there. What does 'statically linked' mean in this context? Mozglue.dll is still a DLL, but yes

RE: Using __declspec(thread) on Windows

2014-10-16 Thread Robert Strong
> -Original Message- > From: dev-platform [mailto:dev-platform- > bounces+rstrong=mozilla@lists.mozilla.org] On Behalf Of Robert > O'Callahan > Sent: Thursday, October 16, 2014 2:11 PM > To: dev-platform@lists.mozilla.org > Subject: Using __declspec(thread) on Windows > > It would be