> -----Original Message----- > From: dev-platform [mailto:dev-platform- > bounces+rstrong=mozilla....@lists.mozilla.org] On Behalf Of Robert > O'Callahan > Sent: Thursday, October 16, 2014 2:11 PM > To: dev-platform@lists.mozilla.org > Subject: Using __declspec(thread) on Windows > > It would be cool to use fast TLS via __declspec(thread) on Windows (and > __thread on gcc/clang). Due to WinXP bustage that only works for variables > in > the .EXE or in DLLs statically linked by the .EXE, so not libxul, but in > our shipped > Windows builds mozglue.dll is statically linked to firefox.exe so we could > put > __declspec(thread) variables there. > > However, that would break if someone tried to dynamically load libxul on > WinXP in the context of a .EXE which did not statically link mozglue.dll. > Does anyone know if that's a problem? I assume no-one's finding the > Firefox > libxul.dll and loading it from their own .EXE, but maybe they're building > their > own? Do we care? It has been a while but we have seen apps load xul.dll and lock it so we aren't able to even move the file out of the way during application update so they definitely exist. There have also been other apps that load xul.dll without locking it but I haven't had visibility into those since making app update succeed for this case after I took over app update around Firefox 3.5. Not sure if we care overall though when they are able to load xul.dll and they choose to also lock the file there isn't much I can do to update Firefox.
Robert _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
