Re: OMTC on Windows

2014-06-17 Thread avihal
On Friday, May 30, 2014 5:14:20 AM UTC+3, avi...@gmail.com wrote: > So, wrt TART, I now took the time to carefully examine tab animation visually > on one system. > > > > TL;DR: > > - I think OMTC introduces a clearly visible regression with tab animation > compared to without OMTC. > > - I

Re: OMTC on Windows

2014-06-02 Thread Gijs Kruitbosch
On 30/05/2014 16:16, andreas@gmail.com wrote: Please read my email again. This kind of animation cannot be rendered with high FPS by any engine. This doesn't make sense. Avih posted numbers sans-OMTC, and the same machine he used that doesn't manage to get 60fps with OMTC gets almost 200

Re: OMTC on Windows

2014-05-30 Thread avihal
On Friday, May 30, 2014 6:16:53 PM UTC+3, andre...@gmail.com wrote: > Please read my email again. It was provided as an objective data and subjective assessment - and not as an opinion, in reply for your request for more info on systems where we suck, if I understood your request correctly. FWI

Re: OMTC on Windows

2014-05-30 Thread andreas . gal
Please read my email again. This kind of animation cannot be rendered with high FPS by any engine. It's simply conceptually expensive and inefficient for the DOM rendering model. We will work on matching other engines if we are slightly slower than we could be, but you will never reach solid per

Re: OMTC on Windows

2014-05-30 Thread avihal
On Friday, May 30, 2014 5:48:26 PM UTC+3, avi...@gmail.com wrote: > On all these systems, Firefox is far behind IE on this front, but with > margins getting lower as the systems get stronger (i.e. in order of > presentation - old atom, new atom, i7+hd4000). And just to complete the picture, the

Re: OMTC on Windows

2014-05-30 Thread avihal
On Friday, May 30, 2014 5:06:52 PM UTC+3, Gabriele Svelto wrote: > On 30/05/2014 14:19, Andreas Gal wrote: > If you can point us to some specific hardware we really suck on we can > definitely look into this. Sure, and the hardware specs are also available at bug 894128 comment 0. 100% smooth sc

Re: OMTC on Windows

2014-05-30 Thread Dao
On 30.05.2014 07:28, Matt Woodrow wrote: I definitely agree with this, but we also need OMTAnimations to be finished and enabled before any of the interesting parts of the UI can be converted. Given that, I don't think we can have this conversation at the expense of trying to fix the current set

Re: OMTC on Windows

2014-05-30 Thread Gabriele Svelto
On 30/05/2014 14:19, Andreas Gal wrote: > Now for Intel hardware being slow there could be a couple reasons, and APZ > might fix them actually. If I remember correctly Atom GPUs are PowerVR based, > which is a tile based rendering architecture. It splits the frame buffer in > small tiles and ren

Re: OMTC on Windows

2014-05-30 Thread Andreas Gal
There are likely two causes here. First, until we have APZ enabled its very unlikely that we can ever maintain a high frame-rate scrolling on low-end hardware. OMTC is a prerequisite for APZ (async pan/zoom). Low end hardware is simply not fast enough to repaint and buffer-rotate with 60FPS.

Re: OMTC on Windows

2014-05-30 Thread avihal
On Friday, May 30, 2014 1:25:33 PM UTC+3, avi...@gmail.com wrote: > FWIW, IE is able to maintain 100% smooth scrolling on some really complex > pages even on a _very_ low end Atom system (Intel iGPU), while Firefox > doesn't come anywhere near it. Of course, I'm hoping that APZ and maybe tiling

Re: OMTC on Windows

2014-05-30 Thread avihal
On Friday, May 30, 2014 8:22:25 AM UTC+3, Matt Woodrow wrote: > Thanks Avi! > > > > I can reproduce a regression like this (~100% slower on > > iconFade-close-DPIcurrent.all) with my machine forced to use the intel > > GPU, but not with the Nvidia one. Indeed, and it's not the first time we

Re: OMTC on Windows

2014-05-29 Thread Matt Woodrow
On 30/05/14 5:22 pm, Matt Woodrow wrote: Doing some profiling using my intel GPU suggests that my specific regression has to do with uploading and drawing shadows. I'm seeing ~45% of the OMTC profile [1] in nsDisplayBoxShadowOuter::Paint vs ~8% in the non-OMTC profile [2]. It's hard to tell e

Re: OMTC on Windows

2014-05-29 Thread Matt Woodrow
I definitely agree with this, but we also need OMTAnimations to be finished and enabled before any of the interesting parts of the UI can be converted. Given that, I don't think we can have this conversation at the expense of trying to fix the current set of regressions from OMTC. We may als

Re: OMTC on Windows

2014-05-29 Thread Matt Woodrow
Thanks Avi! I can reproduce a regression like this (~100% slower on iconFade-close-DPIcurrent.all) with my machine forced to use the intel GPU, but not with the Nvidia one. This suggests it's very much a driver/hardware specific problem, rather than a general regression with OMTC, which matc

Re: OMTC on Windows

2014-05-29 Thread Andreas Gal
I think we should shift the conversation to how we actually animate here. Animating by trying to reflow and repaint with 60fps is just a bad idea. This might work on very high end hardware, but it will cause poor performance on the low-end Windows notebooks people buy these days. In other words

Re: OMTC on Windows

2014-05-29 Thread avihal
So, wrt TART, I now took the time to carefully examine tab animation visually on one system. TL;DR: - I think OMTC introduces a clearly visible regression with tab animation compared to without OMTC. - I _think_ it regresses more with tab close than with tab open animation. - The actual throughp

Re: OMTC on Windows

2014-05-28 Thread Bas Schouten
g, "mozilla.dev.platform group" , "release-drivers" Sent: Wednesday, May 28, 2014 7:15:09 PM Subject: Re: OMTC on Windows Who's responsible for looking into the test/regression? Bas? Does the person looking into it need help from the performance or desktop teams? What bug

Re: OMTC on Windows

2014-05-28 Thread jmaher
https://bugzilla.mozilla.org/show_bug.cgi?id=1013262 tracks all the Talos performance adjustments ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: OMTC on Windows

2014-05-28 Thread Gavin Sharp
v-tech-...@lists.mozilla.org, "mozilla.dev.platform group" < > dev-platform@lists.mozilla.org>, "release-drivers" > > > > Sent: Thursday, May 22, 2014 4:46:29 AM > > Subject: Re: OMTC on Windows > > > > Looking on from m.d.tree-management, o

Re: OMTC on Windows

2014-05-28 Thread Vladimir Vukicevic
" > , "release-drivers" > > Sent: Thursday, May 22, 2014 4:46:29 AM > Subject: Re: OMTC on Windows > > Looking on from m.d.tree-management, on Fx-Team, the merge from this > change caused a >40% CART regression, too, which wasn't listed in the > or

Re: OMTC on Windows

2014-05-23 Thread Marco Zehe
For reference -- if this is applicable --, these failures are tracked in bug 1014673: https://bugzilla.mozilla.org/show_bug.cgi?id=1014673 Marco On 23.05.2014 09:10, Marco Zehe wrote: > Hi all, > > for a couple of days on Nightly, I am seeing an increasing number of > WM_GETOBJECT message respons

Re: OMTC on Windows

2014-05-23 Thread Marco Zehe
Hi all, for a couple of days on Nightly, I am seeing an increasing number of WM_GETOBJECT message response failures, causing in intermittent accessibility failures. I know for a fact that nothing in our code changed recently that could cause this, so I was wondering if OMTC could be responsible?

Re: OMTC on Windows

2014-05-22 Thread Girish Sharma
On Fri, May 23, 2014 at 1:51 AM, Bas Schouten wrote: > bug 1012213 Yup, looks like that only. Thanks for the bug. -- Girish Sharma B.Tech(H), Civil Engineering, Indian Institute of Technology, Kharagpur ___ dev-platform mailing list dev-platform@li

Re: OMTC on Windows

2014-05-22 Thread Bas Schouten
drivers" Sent: Thursday, May 22, 2014 8:15:18 PM Subject: Re: OMTC on Windows I don't know if everyone is noticing this or not, but I am noticing a lot of misplaced paint blocks while scrolling/animation etc. Sometimes even the complete tab won't refresh on a tab change.

Re: OMTC on Windows

2014-05-22 Thread Girish Sharma
"release-drivers" < > release-driv...@mozilla.org> > > Sent: Thursday, May 22, 2014 12:56:26 PM > > Subject: Re: OMTC on Windows > > > > On 2014-05-22, 5:18 AM, Bas Schouten wrote: > > > The focus should, in my opinion be, what has actually been aff

Re: OMTC on Windows

2014-05-22 Thread Bas Schouten
- Original Message - > From: "Ehsan Akhgari" > To: "Bas Schouten" , "Gijs Kruitbosch" > > Cc: "Gavin Sharp" , dev-tech-...@lists.mozilla.org, > "mozilla.dev.platform group" > , "release-drivers" >

Re: OMTC on Windows

2014-05-22 Thread Ehsan Akhgari
On 2014-05-22, 5:18 AM, Bas Schouten wrote: Hi Gijs, None of those things are true in my opinion. For what it's worth, the expected regression in CART was more around 20% than around 40%. The number surprises me a little, and we'll look into what makes CART so bad off (on our test servers) sp

Re: OMTC on Windows

2014-05-22 Thread Gijs Kruitbosch
t to spam people too much :-). Bas - Original Message - From: "Gavin Sharp" To: "Bas Schouten" Cc: "dev-tree-management" , dev-tech-...@lists.mozilla.org, "release-drivers" , "mozilla.dev.platform group" Sent: Sunday, May 18, 2014 6:23:58 PM

Re: OMTC on Windows

2014-05-22 Thread Bas Schouten
nal Message - From: "Gijs Kruitbosch" To: "Bas Schouten" , "Gavin Sharp" Cc: dev-tech-...@lists.mozilla.org, "mozilla.dev.platform group" , "release-drivers" Sent: Thursday, May 22, 2014 8:46:29 AM Subject: Re: OMTC on Windows Looking on from

Re: OMTC on Windows

2014-05-19 Thread Gavin Sharp
On Sun, May 18, 2014 at 11:48 AM, wrote: > Re TART regressions and Gavin's concerns - as always, we should > not trust the numbers blindly. > > The first thing we need is probably taking few windows machines with > different performance characteristics and compare tab animation perf > on those ma

Re: OMTC on Windows

2014-05-19 Thread Bas Schouten
- Original Message - > From: "Benjamin Smedberg" > To: "Bas Schouten" , dev-tech-...@lists.mozilla.org > Cc: "mozilla.dev.platform group" > Sent: Monday, May 19, 2014 1:01:28 PM > Subject: Re: OMTC on Windows > > On 5/18/2014 3:

Re: OMTC on Windows

2014-05-19 Thread Benjamin Smedberg
On 5/18/2014 3:16 AM, Bas Schouten wrote: remove a lot of code that we've currently been duplicating. Furthermore it puts us on track for enabling other features on desktop like APZ, off main thread animations and other improvements. What is APZ? Is OMTC turned on in all graphics setups, acc

Re: OMTC on Windows

2014-05-18 Thread avihal
On Monday, May 19, 2014 4:36:49 AM UTC+3, Boris Zbarsky wrote: > On 5/18/14, 2:23 PM, Gavin Sharp wrote: > > > OMTC is important, and I'm excited to see it land > > > on Windows, but the Firefox and Performance teams have just come off a > > > months-long effort to make significant wins in TART,

Re: OMTC on Windows

2014-05-18 Thread Boris Zbarsky
On 5/18/14, 2:23 PM, Gavin Sharp wrote: OMTC is important, and I'm excited to see it land on Windows, but the Firefox and Performance teams have just come off a months-long effort to make significant wins in TART, and the thought of taking a 20% regression (huge compared to some of the improvemen

Re: OMTC on Windows

2014-05-18 Thread Bas Schouten
where we've been using OMTC for the longest, as well as being very platform-specific in their behavior. Thanks! Bas - Original Message - From: "Armen Zambrano G." To: dev-platform@lists.mozilla.org Sent: Sunday, May 18, 2014 5:50:50 PM Subject: Re: OMTC on Windows What k

Re: OMTC on Windows

2014-05-18 Thread avihal
ens to be quite specialized and OMTC is a major shift in graphics implementation. Even if TART is already running and providing useful results with OMTC on OS X, it could still be out of its "comfort zone" with OMTC on windows. This is true about all tests. The more specialized the tes

Re: OMTC on Windows

2014-05-18 Thread Bas Schouten
t to spam people too much :-). Bas - Original Message - From: "Gavin Sharp" To: "Bas Schouten" Cc: "dev-tree-management" , dev-tech-...@lists.mozilla.org, "release-drivers" , "mozilla.dev.platform group" Sent: Sunday, May 18, 2014 6

Re: OMTC on Windows

2014-05-18 Thread Chris Peterson
That's awesome news, Bas! OMTC on Windows has been one of the major dependencies for e10s. AFAIU, Nightly users on Windows should now be able to test per-window e10s without tweaking any prefs or restarting the browser. To open an e10s window, open "File (or Hamburger)" menu

Re: OMTC on Windows

2014-05-18 Thread Gavin Sharp
, and the thought of taking a 20% regression (huge compared to some of the improvements we fought for) is pretty disheartening. Gavin On Sun, May 18, 2014 at 12:16 AM, Bas Schouten wrote: > Hey all, > > After quite a lot of waiting we've switched on OMTC on Windows by default &

Re: OMTC on Windows

2014-05-18 Thread Armen Zambrano G.
What kind of bugs could we expect seeing? Any place you would like us to put focus on testing? Thanks for all the hard work to get this in. cheers, Armen On 2014-05-18, 3:16 AM, Bas Schouten wrote: > Hey all, > > After quite a lot of waiting we've switched on OMTC on Wind

OMTC on Windows

2014-05-18 Thread Bas Schouten
Hey all, After quite a lot of waiting we've switched on OMTC on Windows by default today (bug 899785). This is a great move towards moving all our platforms onto OMTC (only linux is left now), and will allow us to remove a lot of code that we've currently been duplicating. Furthermo