Re: New character encoding conversion API

2017-06-16 Thread Henri Sivonen
On Thu, Jun 15, 2017 at 3:58 PM, Nathan Froyd wrote: > Can you file a bug so `mach vendor rust` complains about vendoring > rust-encoding? Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1373554 -- Henri Sivonen hsivo...@hsivonen.fi https://hsivonen.fi/ __

Re: New character encoding conversion API

2017-06-15 Thread Simon Sapin
On 15/06/2017 12:32, Henri Sivonen wrote: * We don't have third-party crates in m-c that (unconditionally) require rust-encoding. However, if you need to import such a crate and it's infeasible to make it use encoding_rs directly, please do not vendor rust-encoding into the tree. Vendoring rust

Re: New character encoding conversion API

2017-06-15 Thread Nathan Froyd
On Thu, Jun 15, 2017 at 6:32 AM, Henri Sivonen wrote: > encoding_rs landed delivering correctness, safety, performance and > code size benefits as well as new functionality. Thanks for working on this. > * We don't have third-party crates in m-c that (unconditionally) > require rust-encoding. H

New character encoding conversion API

2017-06-15 Thread Henri Sivonen
encoding_rs landed delivering correctness, safety, performance and code size benefits as well as new functionality. Here's a summary of need-to-know stuff from the perspective of using it. The docs for the Rust-visible API are at: https://docs.rs/encoding_rs/ The docs for the C++-visible API are a