On 15/06/2017 12:32, Henri Sivonen wrote:
* We don't have third-party crates in m-c that (unconditionally) require rust-encoding. However, if you need to import such a crate and it's infeasible to make it use encoding_rs directly, please do not vendor rust-encoding into the tree. Vendoring rust-encoding into the tree would bring in another set of lookup tables, which encoding_rs is specifically trying to avoid. I have a compatibily shim ready in case the need to vendor rust-encoding-dependent crates arises. https://github.com/hsivonen/encoding_rs_compat
I’ve recently made the rust-encoding dependency in Tendril optional and disabled by default. (Tendril is the refcounted buffer type used in html5ever, Servo’s HTML parser.) So this won’t be an issue if we ever want to use html5ever in m-c.
I’ve also removed the "parse from bytes" (as opposed to Unicode &str) API from html5ever because it couldn’t support interrupting parsing on </script> correctly. When adding something again we’ll do it using encoding_rs.
-- Simon Sapin _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
