Re: Forcing alphabetical order in moz.build files

2013-05-16 Thread Gregory Szorc
On 4/16/13 10:15 PM, Robert O'Callahan wrote: I have a request ... can we require lists in moz.build files to be in alphabetical order, and actually enforce with some build-system check? I'm always annoyed by Makefiles where lists are sometimes unordered and it's hard to find items and know where

Re: Forcing alphabetical order in moz.build files

2013-04-17 Thread Gregory Szorc
On 4/17/13 2:37 PM, Robert O'Callahan wrote: On Thu, Apr 18, 2013 at 3:40 AM, Ms2ger wrote: On 04/17/2013 07:15 AM, Robert O'Callahan wrote: I have a request ... can we require lists in moz.build files to be in alphabetical order, and actually enforce with some build-system check? I'm always

Re: Forcing alphabetical order in moz.build files

2013-04-17 Thread Robert O'Callahan
On Thu, Apr 18, 2013 at 3:40 AM, Ms2ger wrote: > On 04/17/2013 07:15 AM, Robert O'Callahan wrote: > >> I have a request ... can we require lists in moz.build files to be in >> alphabetical order, and actually enforce with some build-system check? I'm >> always annoyed by Makefiles where lists are

Re: Forcing alphabetical order in moz.build files

2013-04-17 Thread Mike Hommey
On Wed, Apr 17, 2013 at 07:36:40PM +0200, Robert Kaiser wrote: > Gregory Szorc schrieb: > >Theoretically, yes. And I do empathize with the desire to have them > >alphabetical. > > As Ms2ger notes, we probably cannot have that for *DIRS, though. I > know at least one case where this is crucial, and

Re: Forcing alphabetical order in moz.build files

2013-04-17 Thread Ralph Giles
On 13-04-17 8:40 AM, Ms2ger wrote: > Fully agree, with the exception that I'm not sure this is a safe > transformation for *DIRS. It certainly isn't for add_tier_dir. -r ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozil

Re: Forcing alphabetical order in moz.build files

2013-04-17 Thread Robert Kaiser
Gregory Szorc schrieb: Theoretically, yes. And I do empathize with the desire to have them alphabetical. As Ms2ger notes, we probably cannot have that for *DIRS, though. I know at least one case where this is crucial, and that's Mac packaging. I added a comment for that a long time ago in Sea

Re: Forcing alphabetical order in moz.build files

2013-04-17 Thread Ms2ger
On 04/17/2013 07:15 AM, Robert O'Callahan wrote: I have a request ... can we require lists in moz.build files to be in alphabetical order, and actually enforce with some build-system check? I'm always annoyed by Makefiles where lists are sometimes unordered and it's hard to find items and know wh

Re: Forcing alphabetical order in moz.build files

2013-04-16 Thread Gregory Szorc
On 4/16/2013 10:15 PM, Robert O'Callahan wrote: > I have a request ... can we require lists in moz.build files to be in > alphabetical order, and actually enforce with some build-system check? I'm > always annoyed by Makefiles where lists are sometimes unordered and it's > hard to find items and kn

Forcing alphabetical order in moz.build files

2013-04-16 Thread Robert O'Callahan
I have a request ... can we require lists in moz.build files to be in alphabetical order, and actually enforce with some build-system check? I'm always annoyed by Makefiles where lists are sometimes unordered and it's hard to find items and know where to add items. Rob -- q“qIqfq qyqoquq qlqoqvqe