On 4/16/13 10:15 PM, Robert O'Callahan wrote:
I have a request ... can we require lists in moz.build files to be in
alphabetical order, and actually enforce with some build-system check? I'm
always annoyed by Makefiles where lists are sometimes unordered and it's
hard to find items and know where to add items.
This just landed in inbound. For variables where order isn't important
(pretty much everything except *DIRS), every incoming list append or
replacement must be sorted by byte order of the UTF-8 encoding of the
string (typically strings are ASCII). If it isn't, you'll see an error
message like:
ERROR PROCESSING MOZBUILD FILE
==============================
The error occurred while processing the following file:
/Users/gps/src/firefox/dom/devicestorage/moz.build
The error was triggered on line 15 of this file:
'DeviceStorage.h',
An error was encountered as part of executing the file itself. The error
appears to be the fault of the script.
The error as reported by Python is:
['UnsortedError: An attempt was made to add an unsorted sequence to
a list. The incoming list is unsorted starting at element 0. We expected
"DeviceStorage.h" but got "nsDeviceStorage.h"\n']
As you can see, it tells you exactly what it expects to aid you in
fixing the problem.
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
