Re: Coding style question: Meaningless argument names in declarations

2017-09-08 Thread Kan-Ru Chen
On Thu, Sep 7, 2017, at 11:16 PM, Emilio Cobos Álvarez wrote: > This is very context dependent, I'd never omit a name in a function that > takes (Element& aParent, Element& aChild), but it seems reasonable to > omit it in the case where there's no better name, like (InsertionKind > aInsertionKind)

Re: Coding style question: Meaningless argument names in declarations

2017-09-07 Thread Xidorn Quan
On Fri, Sep 8, 2017, at 01:16 AM, Emilio Cobos Álvarez wrote: > This is very context dependent, I'd never omit a name in a function that > takes (Element& aParent, Element& aChild), but it seems reasonable to > omit it in the case where there's no better name, like (InsertionKind > aInsertionKind)

Re: Coding style question: Meaningless argument names in declarations

2017-09-07 Thread Ehsan Akhgari
On 09/07/2017 11:16 AM, Emilio Cobos Álvarez wrote: On 09/07/2017 04:01 PM, Andrew McCreight wrote: I don't know if it rises to the level of something that should be in the style guide, but I find the names very useful as a form of lightweight documentation. Sure, if you are naming your Foo arg

Re: Coding style question: Meaningless argument names in declarations

2017-09-07 Thread Emilio Cobos Álvarez
On 09/07/2017 04:01 PM, Andrew McCreight wrote: > I don't know if it rises to the level of something that should be in the > style guide, but I find the names very useful as a form of lightweight > documentation. Sure, if you are naming your Foo arguments aFoo the names > aren't useful, but for m

Re: Coding style question: Meaningless argument names in declarations

2017-09-07 Thread Andrew McCreight
On Thu, Sep 7, 2017 at 5:07 AM, Emilio Cobos Álvarez wrote: > Hi, > > I have a coding style question which I don't see addressed in the coding > style page. > > Given there have been a few threads lately on coding style, I guess I > should just ask. > > We have a lot of meaningless argument names

Re: Coding style question: Meaningless argument names in declarations

2017-09-07 Thread Jean-Yves Avenard
not answering your question yet, but... On Thu, Sep 7, 2017 at 2:07 PM, Emilio Cobos Álvarez wrote: > > enum class Operation { > // .. > }; that should be: enum class Operation { // ... }; https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Control_Structur

Coding style question: Meaningless argument names in declarations

2017-09-07 Thread Emilio Cobos Álvarez
Hi, I have a coding style question which I don't see addressed in the coding style page. Given there have been a few threads lately on coding style, I guess I should just ask. We have a lot of meaningless argument names in function declarations, like: void DoFoo(Element& aElement); Or: en