Re: [RFC] Linux HiDPI support: choose default scale factor based on DPI

2014-10-13 Thread Robert O'Callahan
On Sun, Oct 12, 2014 at 10:26 PM, Giuseppe Bilotta < giuseppe.bilo...@gmail.com> wrote: > Yes, sorry, I should have clarified that I meant the DPI for the > scaling. I can prepare a patch for this too. Should I submit it as a > second patch in addition to the first I submitted to the bugzilla, or

Re: [RFC] Linux HiDPI support: choose default scale factor based on DPI

2014-10-13 Thread Giuseppe Bilotta
On Fri, Oct 10, 2014 at 4:46 PM, Nicolas Silva wrote: > In the mean time we should really detect hidpi screens and default to an > appropriate scale. > The current scale is a terrible experience on a hidpi screen. I filed bug > 1081142. My finding is that the DPI is detected correctly, but the

Re: [RFC] Linux HiDPI support: choose default scale factor based on DPI

2014-10-13 Thread Giuseppe Bilotta
On Sun, Oct 12, 2014 at 6:37 PM, Robert O'Callahan wrote: > On Sun, Oct 12, 2014 at 1:41 AM, Giuseppe Bilotta > wrote: >> >> My finding is that the DPI is detected correctly, but the scale is not >> set according to it. This is exactly what my RFC patch does. I'll push >> the patch as a proposed

Re: [RFC] Linux HiDPI support: choose default scale factor based on DPI

2014-10-13 Thread Giuseppe Bilotta
On Mon, Oct 13, 2014 at 4:23 AM, Robert O'Callahan wrote: > On Sun, Oct 12, 2014 at 12:06 PM, Giuseppe Bilotta > wrote: >> >> Indeed. My patch only aims at providing a generic fallback. In >> contexts where it is known how the desktop environment handles the DPI >> settings, that convention shoul

Re: [RFC] Linux HiDPI support: choose default scale factor based on DPI

2014-10-12 Thread Robert O'Callahan
On Sun, Oct 12, 2014 at 12:06 PM, Giuseppe Bilotta < giuseppe.bilo...@gmail.com> wrote: > Indeed. My patch only aims at providing a generic fallback. In > contexts where it is known how the desktop environment handles the DPI > settings, that convention should be followed. But in most cases, this

Re: [RFC] Linux HiDPI support: choose default scale factor based on DPI

2014-10-12 Thread Robert O'Callahan
On Sun, Oct 12, 2014 at 1:41 AM, Giuseppe Bilotta < giuseppe.bilo...@gmail.com> wrote: > On Fri, Oct 10, 2014 at 4:46 PM, Nicolas Silva > wrote: > > In the mean time we should really detect hidpi screens and default to an > appropriate scale. > > The current scale is a terrible experience on a hi

Re: [RFC] Linux HiDPI support: choose default scale factor based on DPI

2014-10-10 Thread Giuseppe Bilotta
On Fri, Oct 10, 2014 at 8:39 AM, Mike Hommey wrote: > On Thu, Oct 09, 2014 at 11:18:28PM -0700, Robert O'Callahan wrote: >> >> We should really follow what GTK does. E.g. whatever scale factor GTK uses >> for system/application icons by default, we should match it. Icons in the >> Firefox UI shoul

Re: [RFC] Linux HiDPI support: choose default scale factor based on DPI

2014-10-10 Thread Nicolas Silva
In the mean time we should really detect hidpi screens and default to an appropriate scale. The current scale is a terrible experience on a hidpi screen. I filed bug 1081142. Cheers, Nical On Fri, Oct 10, 2014 at 8:39 AM, Mike Hommey wrote: > On Thu, Oct 09, 2014 at 11:18:28PM -0700, Robert O'

Re: [RFC] Linux HiDPI support: choose default scale factor based on DPI

2014-10-09 Thread Mike Hommey
On Thu, Oct 09, 2014 at 11:18:28PM -0700, Robert O'Callahan wrote: > On Thu, Oct 9, 2014 at 10:31 PM, wrote: > > > I recently got a HiDPI monitor (15" at 3200x1800, 234 dpi) and I noticed > > that Firefox (32) doesn't automatically scale UI/content to take advantage > > of the hidpi, with the res

Re: [RFC] Linux HiDPI support: choose default scale factor based on DPI

2014-10-09 Thread Robert O'Callahan
On Thu, Oct 9, 2014 at 10:31 PM, wrote: > I recently got a HiDPI monitor (15" at 3200x1800, 234 dpi) and I noticed > that Firefox (32) doesn't automatically scale UI/content to take advantage > of the hidpi, with the result that stuff renders uncomfortably small by > default. If I manually set de

[RFC] Linux HiDPI support: choose default scale factor based on DPI

2014-10-09 Thread giuseppe . bilotta
Hello all. I recently got a HiDPI monitor (15" at 3200x1800, 234 dpi) and I noticed that Firefox (32) doesn't automatically scale UI/content to take advantage of the hidpi, with the result that stuff renders uncomfortably small by default. If I manually set devPixelsPerPx to 2, I seem to get a