On Mon, Oct 13, 2014 at 4:23 AM, Robert O'Callahan <[email protected]> wrote: > On Sun, Oct 12, 2014 at 12:06 PM, Giuseppe Bilotta > <[email protected]> wrote: >> >> Indeed. My patch only aims at providing a generic fallback. In >> contexts where it is known how the desktop environment handles the DPI >> settings, that convention should be followed. But in most cases, this >> reduces to just changing the way the DPI is computed (e.g. by reading >> it from the Xft.dpi resource rather than by computing the actual DPI >> from the screen dimensions) rather than changing how we compute the >> scale based on the DPI. > > > We shouldn't change how the DPI is computed. In particular the mozmm unit > should be "life size" regardless of what Xft.dpi says. > > But I think in some situations we should be checking Xft.dpi in > GetDefaultScaleInternal. >
Yes, sorry, I should have clarified that I meant the DPI for the scaling. I can prepare a patch for this too. Should I submit it as a second patch in addition to the first I submitted to the bugzilla, or should I submit a v2 that includes both changes? -- Giuseppe "Oblomov" Bilotta _______________________________________________ dev-platform mailing list [email protected] https://lists.mozilla.org/listinfo/dev-platform
