Re: On builds getting slower

2013-08-04 Thread Nicholas Nethercote
On Sun, Aug 4, 2013 at 11:05 PM, Justin Lebar wrote: > Nick, when you made changes to the JS engine's #includes, did you > observe a change in build times? I don't have good measurements, largely because I've been doing it in small chunks over time. I'll try to do https://bugzilla.mozilla.org/sh

Re: On builds getting slower

2013-08-04 Thread Nicholas Nethercote
>> I fixed these in https://bugzilla.mozilla.org/show_bug.cgi?id=881579. >> Unlike the #include minimization, these don't require domain-specific >> expertise and are easy to fix. > > Did you measure a noticeable performance improvement? I can't imagine > that it would take too much time to includ

Re: On builds getting slower

2013-08-04 Thread Justin Lebar
Nick, when you made changes to the JS engine's #includes, did you observe a change in build times? On Sat, Aug 3, 2013 at 1:14 AM, Nicholas Nethercote wrote: > On Sat, Aug 3, 2013 at 5:47 PM, Mike Hommey wrote: >> >> One piece of the puzzle, at least in Mozilla code, is the tendency to >> #inclu

Re: On builds getting slower

2013-08-04 Thread Nicholas Nethercote
On Sun, Aug 4, 2013 at 10:12 PM, Nicholas Nethercote wrote: > > I tried --enable-debug-symbols=-gsplit-dwarf in a debug build like this: > > CC='clang' CXX='clang++' ../configure --enable-debug > --enable-debug-symbols=-gsplit-dwarf --enable-optimize='-O0' > --enable-valgrind > > and it reduced

Re: On builds getting slower

2013-08-04 Thread Joshua Cranmer 🐧
On 8/2/2013 4:13 PM, Gregory Szorc wrote: # Header dependency hell We have hundreds of header files that are included in hundreds or even thousands of other C++ files. Any time one of these widely-used headers changes, the object files get invalidated by the build system dependencies and we h

Re: On builds getting slower

2013-08-04 Thread Nicholas Nethercote
On Sat, Aug 3, 2013 at 5:47 PM, Mike Hommey wrote: >> >> If I could speed up any part of the builds, it would be linking. >> Waiting a long time to test a one file change sucks. > > If you're on linux, you can try --enable-debug-symbols=-gsplit-dwarf. That worked nicely. Before I get there, some

Re: reminder: content processes (e10s) are now used by desktop Firefox

2013-08-04 Thread Brian Smith
On Wed, Jul 31, 2013 at 1:10 AM, Gavin Sharp wrote: > Bug 870100 enabled use of the background thumbnail service in Firefox > desktop, which uses a to do thumbnailing of pages in > the background. > > That means that desktop Firefox now makes use of E10S content processes. > They have a short li

Re: reminder: content processes (e10s) are now used by desktop Firefox

2013-08-04 Thread Justin Lebar
On Sun, Aug 4, 2013 at 8:15 AM, Robert Kaiser wrote: > Mark Hammond schrieb: > >> We ask the docShell to not allow plugins or media > > So that means that for any page with a video or a big Flash/Java thing on > it, I would get a completely wrong thumbnail? That's unfortunate. It's a lot better t

Re: reminder: content processes (e10s) are now used by desktop Firefox

2013-08-04 Thread Robert Kaiser
Mark Hammond schrieb: We ask the docShell to not allow plugins or media So that means that for any page with a video or a big Flash/Java thing on it, I would get a completely wrong thumbnail? That's unfortunate. Robert Kaiser ___ dev-platform mail

Re: On builds getting slower

2013-08-04 Thread Aryeh Gregor
On Sat, Aug 3, 2013 at 6:36 AM, Nicholas Nethercote wrote: > Gregory suggested that headers aren't something that the build config > group can tackle, and I agree. Modifying #include statements en masse > is much easier if you have some familiarity with the code. You need a > sense of which head