>> I fixed these in https://bugzilla.mozilla.org/show_bug.cgi?id=881579. >> Unlike the #include minimization, these don't require domain-specific >> expertise and are easy to fix. > > Did you measure a noticeable performance improvement? I can't imagine > that it would take too much time to include a file that's scanned and > skipped in its entirety by the preprocessor without invoking the > actual compiler, even without this optimization.
I just measured it carefully. I tried adding a useless |#if 0 / #endif| pair of lines to the top of every .h file in SpiderMonkey. As an example of the effect, this increased the number of times jsapi.h was read from 228 to 3116. However, the effect on a rebuild-everything-in-the-JS-shell-except-ICU was minimal. The results are a bit noisy, but it maybe reduced the time from ~59.5s to ~58.5s. Pretty weak tea :( Nick _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
