Re: Why we avoid making private modifications to NSPR and NSS (was Re: Imported code)

2012-10-12 Thread Ehsan Akhgari
On 2012-10-12 8:15 PM, Wan-Teh Chang wrote: Hi Ehsan, If you work in Mountain View, I'd like to meet with you to discuss our options for the OpenBSD integer types problem (bug 634793). (One of the options is to accept the requested change.) I am sure we can avoid a Mozilla local patch for this p

Re: Proposal: Remove Linux PGO Testing

2012-10-12 Thread Chris AtLee
On 12/10/12 01:01 PM, Chris Peterson wrote: > On 10/11/12 7:36 PM, Justin Lebar wrote: >>> 2. Linux is the foundation of B2G and Firefox for Android, where we >>> *definitely* must deliver >>> the fastest product we can >> >> I totally agree, but it's not clear to me whether continuing to do PGO >>

Re: Why we avoid making private modifications to NSPR and NSS (was Re: Imported code)

2012-10-12 Thread Wan-Teh Chang
Hi Ehsan, If you work in Mountain View, I'd like to meet with you to discuss our options for the OpenBSD integer types problem (bug 634793). (One of the options is to accept the requested change.) I am sure we can avoid a Mozilla local patch for this problem. I came from the era of Unix balkaniza

Re: Why we avoid making private modifications to NSPR and NSS (was Re: Imported code)

2012-10-12 Thread Ehsan Akhgari
On 2012-10-12 12:18 PM, Wan-Teh Chang wrote: Hi Ehsan, Thank you for your reply. Hi! Thank you for your swift replies too! :-) On Fri, Oct 12, 2012 at 7:25 AM, Ehsan Akhgari wrote: Do we require to maintain source or binary compatibility, or both? As BDS said, both are required in gene

Re: Proposal: Remove Linux PGO Testing

2012-10-12 Thread Taras Glek
On 10/11/2012 1:34 PM, Mike Hommey wrote: On Thu, Oct 11, 2012 at 02:26:33PM -0400, Rafael Ávila de Espíndola wrote: On 10/11/2012 02:33 AM, Mike Hommey wrote: On Wed, Oct 10, 2012 at 05:57:53PM -0400, Justin Lebar wrote: By "turning off Linux PGO testing", you really mean "stop making and dis

Gfx meeting, Monday 2:30 pm pst

2012-10-12 Thread Benoit Jacob
Hello, The Graphics meeting will take place this Monday at 2:30 PM US/Pacific time. That could be Tuesday in your timezone. Please first add your agenda items there: https://wiki.mozilla.org/Platform/GFX/2012-October-15 * Not every Monday at 2:30 PM Pacific Time * +1 650 903 0800 x92 Conf# 9936

Re: Proposal: Remove Linux PGO Testing

2012-10-12 Thread Brian Smith
David Anderson wrote: > It's still unclear to me what our Linux PGO builds mean. Do > distributions use them? If not, are they using the exact same > compiler version and PGO environment data? If not, then they have a > different configuration that we haven't tested. I agree that we should make su

Re: Proposal: Remove Linux PGO Testing

2012-10-12 Thread Chris Peterson
On 10/11/12 7:36 PM, Justin Lebar wrote: 2. Linux is the foundation of B2G and Firefox for Android, where we *definitely* must deliver the fastest product we can I totally agree, but it's not clear to me whether continuing to do PGO on desktop Linux has any effect on our ability to potentially

Re: Why we avoid making private modifications to NSPR and NSS (was Re: Imported code)

2012-10-12 Thread Wan-Teh Chang
Hi Ehsan, Thank you for your reply. On Fri, Oct 12, 2012 at 7:25 AM, Ehsan Akhgari wrote: > > Do we require to maintain source or binary compatibility, or both? As BDS said, both are required in general. Source compatibility can be broken if it is not disruptive, and that's often hard to assess

Re: Why we avoid making private modifications to NSPR and NSS (was Re: Imported code)

2012-10-12 Thread Brian Smith
Ehsan Akhgari wrote: > Do we require to maintain source or binary compatibility, or both? > Also, is it acceptable for us to add new preprocessor definitions > such as NO_NSPR_10_SUPPORT to optionally remove some of the NSPR > feature which we would like Gecko to avoid, without changing the > defau

Re: Why we avoid making private modifications to NSPR and NSS (was Re: Imported code)

2012-10-12 Thread Benjamin Smedberg
On 10/12/2012 10:25 AM, Ehsan Akhgari wrote: Do we require to maintain source or binary compatibility, or both? Also, is it acceptable for us to add new preprocessor definitions such as NO_NSPR_10_SUPPORT to optionally remove some of the NSPR feature which we would like Gecko to avoid, withou

Re: Why we avoid making private modifications to NSPR and NSS (was Re: Imported code)

2012-10-12 Thread Ehsan Akhgari
On 2012-10-11 8:52 PM, Wan-Teh Chang wrote: Ehsan wrote: It is entirely unreasonable to render ourselves unable to modify our imported code (just look at the current situation with NSPR which causes developers to go through huge pain in order to work around things which would be very simply deal

onHTTPSpyReadyStateChange not sent for aborted XHR?

2012-10-12 Thread Jan Honza Odvarko
One of the Firebug automated tests is using following script to check that XHR displayed in the Console panel (and the Net panel) is properly finished if aborted: var request = new XMLHttpRequest(); request.open("POST", "", true); request.send(null); request.abort(); It works in Firefox 17, where

Re: How to be notified when a node gets detached/reparented?

2012-10-12 Thread Paul Rouget
Marcio Galli wrote: > @Paul, > > What is your use case BTW? when you say "update views" based on mutations, > is the goal is to let the user know what is going on? Or you actually > performing other mutations back to the DOM or logging things or creating > reports? For example: if you start the

Re: How to be notified when a node gets detached/reparented?

2012-10-12 Thread Paul Rouget
smaug wrote: > On 10/11/2012 02:40 PM, Paul Rouget wrote: > >Context: in the firefox devtools, we need to track some nodes and update > >different "views" based on what's happening to this node (show its parents, > >show its child, show its attributes, …). > > > >The new Mutation observers are very

Re: How to be notified when a node gets detached/reparented?

2012-10-12 Thread Paul Rouget
Jonas Sicking wrote: > On Thu, Oct 11, 2012 at 6:04 AM, Paul Rouget wrote: > > Paul Rouget wrote: > >> Context: in the firefox devtools, we need to track some nodes and update > >> different "views" based on what's happening to this node (show its parents, > >> show its child, show its attributes,

Re: Proposal: Remove Linux PGO Testing

2012-10-12 Thread Mike Hommey
On Fri, Oct 12, 2012 at 12:28:43AM -0700, David Anderson wrote: > On Thursday, October 11, 2012 5:49:07 PM UTC-7, Brian Smith wrote: > > I think it is important to give Linux users the fastest browser we > > can give them, because: > > It's still unclear to me what our Linux PGO builds mean. Do >

Re: Proposal: Remove Linux PGO Testing

2012-10-12 Thread David Anderson
On Thursday, October 11, 2012 5:49:07 PM UTC-7, Brian Smith wrote: > I think it is important to give Linux users the fastest browser we can give > them, because: It's still unclear to me what our Linux PGO builds mean. Do distributions use them? If not, are they using the exact same compiler ver