Re: Disabling tests

2012-07-24 Thread Ted Mielczarek
On Tue, Jul 24, 2012 at 8:05 PM, ben turner wrote: > Any thoughts or objections? This sums up my feelings on the matter pretty well. If we disable tests we lose test coverage. Sometimes flaky tests just means we have flaky tests, but sometimes it means we're shipping flaky features, which is the

Disabling tests

2012-07-24 Thread ben turner
Hi folks, Recently we've started writing some platform tests that exercise content processes for B2G, and as you can probably imagine those tests are somewhat fragile. I think it's safe to say that no one likes randomly failing tests. Our extremely overworked and underpaid sheriffs and volunteers

Re: c++ put custom implementation of stream listener into traceable channels SetNewListener method

2012-07-24 Thread justSomeGuy
Dne torek, 24. julij 2012 21:13:53 UTC+2 je oseba Josh Matthews napisala: > On 12-07-24 2:31 PM, justSomeGuy wrote: > > NS_IMPL_ISUPPORTS2(Crypt_o_niteListener, nsIRequestObserver, > nsIStreamListener) > > Given that the class is called MyListener, I don't see how this is > expected to work. >

Re: c++ put custom implementation of stream listener into traceable channels SetNewListener method

2012-07-24 Thread Josh Matthews
On 12-07-24 2:31 PM, justSomeGuy wrote: NS_IMPL_ISUPPORTS2(Crypt_o_niteListener, nsIRequestObserver, nsIStreamListener) Given that the class is called MyListener, I don't see how this is expected to work. Cheers, Josh ___ dev-platform mailing list

Re: c++ put custom implementation of stream listener into traceable channels SetNewListener method

2012-07-24 Thread Boris Zbarsky
On 7/24/12 2:31 PM, justSomeGuy wrote: Here is the code: Hmm. That's pretty odd. Looks like that should work. -Boris ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: building firefox with tup

2012-07-24 Thread Gregory Szorc
Mike, et al, I wanted to let you know that I have rebased my build-splendid branch on top of current mozilla-central and have refactored it to work with mach. The branch is still at [1]. All the code now lives under build/pylib/mozbuild. What's left of the old code lives in build/pylib/mozbu

Re: c++ put custom implementation of stream listener into traceable channels SetNewListener method

2012-07-24 Thread justSomeGuy
Dne torek, 24. julij 2012 16:17:27 UTC+2 je oseba Boris Zbarsky napisala: > On 7/24/12 6:54 AM, justSomeGuy wrote: > >MyListener *myListener = new MyListener; > >rv = traceableChannel->SetNewListener(myListener, > getter_AddRefs(myListener->mListener)); //I put the > nsCOMPtr

Re: Porting B2G to a HTC Desire HD

2012-07-24 Thread Robert Kaiser
doomsplayer schrieb: I'm also seeking a way to port FirefoxOS to my Galaxy Nexus AFAIK there's instructions on how to compile B2G for the Galaxy Nexus up on MDC. Robert Kaiser ___ dev-platform mailing list dev-platform@lists.mozilla.org https://li

Re: How can I volunteer in Firefox OS ?

2012-07-24 Thread Dave Hylands
Hi, > On 24/07/2012 06:11, doomsplayer wrote: > > But how to modify the gonk to make firefox os running on my Galaxy > > Nexus? I thought that the Galaxy Nexus was one of the phones that was already supported? It shows up when you run ./config.sh with no arguments. Dave Hylands ___

Re: c++ put custom implementation of stream listener into traceable channels SetNewListener method

2012-07-24 Thread Boris Zbarsky
On 7/24/12 6:54 AM, justSomeGuy wrote: MyListener *myListener = new MyListener; rv = traceableChannel->SetNewListener(myListener, getter_AddRefs(myListener->mListener)); //I put the nsCOMPtr mListener; into the implementation of nsIStreamListener As a side note, this seems to pass in my

Re: shEntry passed to nsIDocShell::LoadURI

2012-07-24 Thread Boris Zbarsky
On 7/24/12 9:01 AM, Henri Sivonen wrote: What are the semantics of the shEntry passed to nsIDocShell::LoadURI (mxr.mozilla.org/mozilla-central/source/docshell/base/nsDocShell.cpp#1279)? It's the session history entry being loaded when the load is a history traversal, I believe... -Boris ___

Re: How to get Docshell for plugin?

2012-07-24 Thread Josh Matthews
On 12-07-24 1:40 AM, Boris Zbarsky wrote: On 7/24/12 12:36 AM, Jason Duell wrote: Do we have any way within our NPAPI functions to determine what docshell the plugin is displaying content in? In the code you're looking at (nsNPAPIPlugin.cpp), use GetDocumentFromNPP() and then get the docshell

shEntry passed to nsIDocShell::LoadURI

2012-07-24 Thread Henri Sivonen
What are the semantics of the shEntry passed to nsIDocShell::LoadURI (mxr.mozilla.org/mozilla-central/source/docshell/base/nsDocShell.cpp#1279)? What does it mean for it to be non-null? What does it mean for it to be null? Doesn't make sense for shEntry to be non-null when replacing the previous se

c++ put custom implementation of stream listener into traceable channels SetNewListener method

2012-07-24 Thread justSomeGuy
Hi, I'm trying to get responses but I can't seem to figure out how to use nsiTraceableChannel. What I already did is that i registered an observer for http-on-modify-request and http-on-examine-response, which is working just fine. Now what I'm trying to do is use nsiTraceableChannel to replace

Re: How can I volunteer in Firefox OS ?

2012-07-24 Thread Jonathan Watt
On 24/07/2012 06:11, doomsplayer wrote: But how to modify the gonk to make firefox os running on my Galaxy Nexus? Does https://wiki.mozilla.org/B2G/Porting help? ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/