Re: [apache/tvm-rfcs] [RFC][BYOC] Marvell ML/AI Accelerator Integration (PR #48)

2022-02-24 Thread Joe Chou
@areusch: Yes, using one or two zoom sessions to go over some questions of yours and some questions of ours will definitely be very, very helpful. This way we can sync up quicker. I am open tomorrow (2/25) as well as Monday (2/28) in the afternoons from 1:30 pm to 6 pm Pacific time zone. Will yo

Re: [apache/tvm-rfcs] [RFC][BYOC] Marvell ML/AI Accelerator Integration (PR #48)

2022-02-15 Thread Joe Chou
@areusch: No worries. I saw lots TVM emails coming from you & others working on other also important stuffs. We will wait for your feedback. -- Reply to this email directly or view it on GitHub: https://github.com/apache/tvm-rfcs/pull/48#issuecomment-1040923708 You are receiving this because you

Re: [apache/tvm-rfcs] [RFC][BYOC] Marvell ML/AI Accelerator Integration (PR #48)

2022-02-08 Thread Joe Chou
@areusch: Hello, I believe I have cleaned up the PR's commits now (reset a few commits and re-add changes). Sorry about that. Can you take a look again (my latest changes are with this commit: 8a7fd01)? Thanks. -- Reply to this email directly or view it on GitHub: https://github.com/apache/tvm-r

Re: [apache/tvm-rfcs] [RFC][BYOC] Marvell ML/AI Accelerator Integration (PR #48)

2022-02-08 Thread Joe Chou
@areusch: You are correct that I must did something wrong the last time and now I lost the linkage between my GitHub forked byoc-mrvl branch and this tvm-rfc PR-#48. Therefore, my changes done a week ago are still staying on my personal GitHub forked byoc-mrvl branch and did not get push to the

Re: [apache/tvm-rfcs] [RFC][BYOC] Marvell ML/AI Accelerator Integration (PR #48)

2022-02-08 Thread Joe Chou
Reopened #48. -- Reply to this email directly or view it on GitHub: https://github.com/apache/tvm-rfcs/pull/48#event-6029889657 You are receiving this because you are subscribed to this thread. Message ID:

Re: [apache/tvm-rfcs] [RFC][BYOC] Marvell ML/AI Accelerator Integration (PR #48)

2022-02-08 Thread Joe Chou
Closed #48. -- Reply to this email directly or view it on GitHub: https://github.com/apache/tvm-rfcs/pull/48#event-6029888416 You are receiving this because you are subscribed to this thread. Message ID:

Re: [apache/tvm-rfcs] [RFC][BYOC] Marvell ML/AI Accelerator Integration (PR #48)

2022-02-08 Thread Joe Chou
> @ccjoechou hey I think you may have had a bad merge--I see a bunch of > unrelated RFCs listed as changed underneath "Files changed." Could you take a > look and rebase/re-merge? Let me check. -- Reply to this email directly or view it on GitHub: https://github.com/apache/tvm-rfcs/pull/48#iss

Re: [apache/tvm-rfcs] [RFC][BYOC] Marvell ML/AI Accelerator Integration (PR #48)

2022-02-01 Thread Joe Chou
Hi @areusch: I have updated RFC-#48 based on most of your feedback. New RFC md file and 4 new figures have been uploaded. Please take a look again (in a view document mode I can see new figures being displayed inside RFC). We are taking couple of your TIR-related advices and will start reviewing

Re: [apache/tvm-rfcs] [RFC][BYOC] Marvell ML/AI Accelerator Integration (PR #48)

2022-01-26 Thread Joe Chou
@areusch: Forgot to answer your first question. Yes, for now, we like to generate external JSON files, only for the accelerator sub graph(s), in the BuildResult step so that we can pass them to our not-(yet-)in-TVM-general-flow, external-accelerator-specific compiler backend program to do furthe

Re: [apache/tvm-rfcs] [RFC][BYOC] Marvell ML/AI Accelerator Integration (PR #48)

2022-01-26 Thread Joe Chou
@areusch: Thanks again for your latest responses. Don't worry about timing (we all have our real jobs to do too). I am going to update the RFC #48 doc based on many of your feedback in the next few days -- including to add figures by following the example you gave and to add descriptions to clar

Re: [apache/tvm-rfcs] [RFC][BYOC] Marvell ML/AI Accelerator Integration (PR #48)

2022-01-18 Thread Joe Chou
oc-marvell-ml-ai-accelerator-integration/11691]. Thanks again and please let us know, if you like to discuss more. * Joe From: Andrew Reusch ***@***.***> Sent: Tuesday, January 18, 2022 12:48 PM To: apache/tvm-rfcs ***@***.***> Cc: Joe Chou ***@***.***>; Mention ***@***.

Re: [apache/tvm-rfcs] [RFC][BYOC] Marvell ML/AI Accelerator Integration (PR #48)

2022-01-12 Thread Joe Chou
Hello, How can we request a reviewer to review our RFC? Also, we have followed the RFC template and listed several unresolved questions, which need help from reviewer and/or TVM community to resolve? The first few issues are related TVM Jenkins build's rust/cargo failure. I.e., we like to add tw

Re: [apache/tvm] [pre-RFC][BYOC] Marvell ML/AI Accelerator Integration (PR #9730)

2021-12-17 Thread Joe Chou
Hi @jroesch, We have filed a RFC PR-48 (RFC][BYOC] Marvell ML/AI Accelerator Integration) at the TVM GitHub https://github.com/apache/tvm-rfcs repo. Thanks, - Joe -- Reply to this email directly or view it on GitHub: https://github.com/apache/tvm/pull/9730#issuecomment-997046258 You are rece

[apache/tvm-rfcs] [RFC][BYOC] Marvell ML/AI Accelerator Integration (PR #48)

2021-12-17 Thread Joe Chou
* Integrate Marvell’s ML/AI accelerator with TVM BYOC framework in order to bring the TVM ecosystem to Marvell customers. We have also posted a pre-RFC at https://discuss.tvm.apache.org/t/pre-rfc-byoc-marvell-ml-ai-accelerator-integration/11691. Plus, we have up-streamed our POC code changes in:

Re: [apache/tvm] [pre-RFC][BYOC] Marvell ML/AI Accelerator Integration (PR #9730)

2021-12-17 Thread Joe Chou
Hello @jroesch, We have followed the tvm-RFC steps; and we have converted contents in our pre-RFC posting into a RFC one, plus, added more required sub sections as explained by the RFC template format. Please see a copy below. We will find time to upload our RFC to the GitHub repo https://githu

Re: [apache/tvm] [pre-RFC][BYOC] Marvell ML/AI Accelerator Integration (PR #9730)

2021-12-14 Thread Joe Chou
Hello @jroesch, After done more self-discovery from reviewing other BYOC code files and CMake setup files, I think now I am aware of that, in the Mrvl.cmake file, the source file lists for libtvm_runtime.so (e.g., RUNTIME_SRCS) and for libtvm.so (e.g., COMPILER_SRCS) need to be separated. I have

Re: [apache/tvm] [pre-RFC][BYOC] Marvell ML/AI Accelerator Integration (PR #9730)

2021-12-13 Thread Joe Chou
Hello @tqchen, @jroesch, or any other reviewer: We have also posted a pre-RFC ([11691](https://discuss.tvm.apache.org/t/pre-rfc-byoc-marvell-ml-ai-accelerator-integration/11691) with the same title for discussion along with this POC PR and code changes. Once we can get some feedback, we (Marvel

[apache/tvm] [pre-RFC][BYOC] Marvell ML/AI Accelerator Integration (PR #9730)

2021-12-13 Thread Joe Chou
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) b

RE: [EXT] [Apache TVM Discuss] [Application] TVM Community Survey

2021-06-23 Thread Joe Chou
-Original Message- From: nore...@discuss.tvm.ai Sent: Wednesday, June 23, 2021 11:11 AM To: tvm.archi...@gmail.com Subject: [EXT] [Apache TVM Discuss] [Application] TVM Community Survey External Email -- Hi everyone