Re: [apache/tvm-rfcs] Embedded Rust API RFC (PR #96)

2023-01-05 Thread Tianqi Chen
I still think you still misunderstood my comment :) The particular comment is suggesting possible approaches that would help give clarity of the rust embedded API in this RFC. You might feel that I am implying changes to embedded C API. While it is OK to for myself or others to give suggestion

Re: [apache/tvm-rfcs] Embedded Rust API RFC (PR #96)

2023-01-05 Thread Christopher Sidebottom
> I am only referring to the clarifying the module with proper namespace, > folder structure and naming convention helps to bring the clarity to > developers and users as they start to interact with the APIs. > > For example, putting some of the API under `micro` namespace(actually any > namesp

Re: [apache/tvm-rfcs] Embedded Rust API RFC (PR #96)

2023-01-05 Thread Tianqi Chen
Hi @Mousius I think you misunderstood my comments. Perhaps due to the possible confusion "scoping". I am not suggesting to change the interface design or re-define the way to interact with embedded C APIs. I am only referring to the clarifying the module with proper namespace, folder structure

Re: [apache/tvm-rfcs] Embedded Rust API RFC (PR #96)

2023-01-05 Thread Christopher Sidebottom
I acknowledge your concerns @tqchen, the diversity of API in TVM is a problem beyond this RFC though. This RFC is aligned with the Embedded C APIs, which have a multitude of examples within the TVM repo. If we want to re-scope the embedded interfaces then I'd suggest we do that in a separate R

Re: [apache/tvm-rfcs] Embedded Rust API RFC (PR #96)

2023-01-05 Thread Tianqi Chen
Thanks for the RFC. The main thing that I think worth doing is scoping, so that the relation of the proposed module can be reasonably understandable by the overall community. Here are two things ## Clarifying the interface - X0: TVM had a heavy focus on a fixed, small set of universal interfa

Re: [apache/tvm-rfcs] Embedded Rust API RFC (PR #96)

2023-01-05 Thread Christopher Sidebottom
New APIs are now documented and I've raised https://github.com/apache/tvm/issues/13705 😸 -- Reply to this email directly or view it on GitHub: https://github.com/apache/tvm-rfcs/pull/96#issuecomment-137596 You are receiving this because you are subscribed to this thread. Message ID: