I still think you still misunderstood my comment :) The particular comment is suggesting possible approaches that would help give clarity of the rust embedded API in this RFC.
You might feel that I am implying changes to embedded C API. While it is OK to for myself or others to give suggestions in the context of reviewing this RFC. If any, they are just helpful context for discussion and future developent. They will not be used as a pre-condition to merge this RFC though. To be absolutely clear, I did not ask for a change of the embedded C interface. Coming back to the embedded C interface for example, most of the apis are organized under a specific folder (crt). Because C language do not come with a namespace, that was a proper choice we made to help the developer know which group of APIs they are targetting. Additionally, because C language is mostly associated with embedded space, there is less possibility of confusion. Rust, on the other hand, is commonly being used beyond embedded settings. Rust on the other hand comes with proper namespace support. It is also possible to have [C FFI interface within a namesapce](https://stackoverflow.com/questions/38948997/is-it-possible-to-declare-extern-c-functions-without-polluting-the-namespace) and [define export name](https://doc.rust-lang.org/reference/abi.html#the-export_name-attribute) for a function with C mangling. Additionally, rust is more commonly used as non-embedded language, and it is possible to for rust to interact with libtvm_runtime or libtvm through object system. So that creates a point of confusion for developers and users. So what I was suggesting is the following actionable item: Propose an approach to clarify the embedded API so the user/developer clearly know the intent. - This can be done through say (a) introducing a new namespace; (b) use a particular folder structure that indicate it is embedded API (c) other possible approaches that helps the calrification. -- Reply to this email directly or view it on GitHub: https://github.com/apache/tvm-rfcs/pull/96#issuecomment-1372730794 You are receiving this because you are subscribed to this thread. Message ID: <apache/tvm-rfcs/pull/96/c1372730...@github.com>
