Re: [apache/tvm] [TIR][REFACTOR][RFC] ForNode -- Introduce Annotations and ThreadBinding to for_type (#7302)

2021-01-18 Thread Tianqi Chen
@spectrometerHBH it would be great if you can take a stab to get the first strawman syntax and parser -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/apache/tvm/issues/7302#issuecomment-762330423

Re: [apache/tvm] [TIR][REFACTOR][RFC] ForNode -- Introduce Annotations and ThreadBinding to for_type (#7302)

2021-01-18 Thread Tianqi Chen
I see, I don't think the thread binding can come with additional annotations, which might simplify the problem (if we enforce such check in IR validation). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/

Re: [apache/tvm] [TIR][REFACTOR][RFC] ForNode -- Introduce Annotations and ThreadBinding to for_type (#7302)

2021-01-18 Thread Bohan Hou
The problem is that launch_thread was not designed to print those additional hints,since launch_thread was syntax for Attr now. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/apache/tvm/issues/7302#issue

Re: [apache/tvm] [TIR][REFACTOR][RFC] ForNode -- Introduce Annotations and ThreadBinding to for_type (#7302)

2021-01-18 Thread Tianqi Chen
Thanks @junrushao1994 We have already some mechanism to print the low level thread binding via attr (printed as launch_thread). When the threadIdx is shared in multiple launch point, the var is printed separately. Otherwise it is printed inline to the code. I believe we could adopt a similar st