[TVM Discuss] [Development] Can `slice` from relay support empty result?

2020-03-26 Thread Yao Wang via TVM Discuss
[quote="heliqi, post:6, topic:5889"] ``` ``` When have an ‘end_v < begin_v error’ , it still seems to throw [/quote] In this case, same change need to be made for relay: ```CHECK_LT(begin_v, end_v)``` -> ```CHECK_LE(begin_v, end_v)``` --- [Visit Topic](https://discuss.tvm.ai/t/can-slice

Re: [apache/incubator-tvm] [VOTE] VTA HW/SW refactor (#5102)

2020-03-26 Thread Thierry Moreau
I'm glad to announce the results of the vote on VTA HW/SW refactor. This vote passes with 11 +1 votes, no 0 votes, and 0 -1 vote. +1 votes Tianqi Chen Jared Roesch Luis Vega Krzysztof Parzyszek Haichen Shen Pasquale Cocchini Kazutaka Morita Liangfu Chen Neo Ch

Re: [apache/incubator-tvm] [VOTE] VTA HW/SW refactor (#5102)

2020-03-26 Thread Thierry Moreau
Closed #5102. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/apache/incubator-tvm/issues/5102#event-3170066386

Re: [apache/incubator-tvm] [VOTE] VTA HW/SW refactor (#5102)

2020-03-26 Thread Thierry Moreau
Thanks for everyone that voted closing the vote now. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/apache/incubator-tvm/issues/5102#issuecomment-604683379

[TVM Discuss] [Development/RFC] [RFC] Relay to ONNX

2020-03-26 Thread tqchen via TVM Discuss
Thanks for the proposal. It would be great to list alternatives with labels (see example https://discuss.tvm.ai/t/target-and-attributes/6013), discuss pros and cons, so others can share their opinions easily. Given that onnx is not rich enough to cover all the operators, such conversion might

[TVM Discuss] [Development/RFC] [RFC] Relay to ONNX

2020-03-26 Thread Mahesh Ambule via TVM Discuss
@jroesch, @tqchen, Regarding the naming convention discussion on the PR, I agree the converter does not seem to be the correct word. The suggested words by you are either 'export' or 'target'. I think 'export' should be used as it is more in line with other DL frameworks. Please let me know

[TVM Discuss] [Development/RFC] [RFC] Relay to ONNX

2020-03-26 Thread Mahesh Ambule via TVM Discuss
## Motivation: We want to port the DL models in Relay IR. For that, we want to serialize the Relay IR to disk. Once serialized third-party frameworks, compilers should be able to import those. We want the serialization format to be compact, portable, widely adopted and having well-documented

[TVM Discuss] [Development] Can `slice` from relay support empty result?

2020-03-26 Thread Heliqi via TVM Discuss
@kevinthesun My code has been updated recently, but still error: ``` tvm/src/relay/op/tensor/transform.cc: Check failed: begin_v < end_v (0 vs 0) :stride_slice get empty slice at axis 1 begin = [0,0] end = [15,0] ``` When have an 'end_v < begin_v error' , it still seems to throw an error inste

[TVM Discuss] [Development] Can `slice` from relay support empty result?

2020-03-26 Thread Yao Wang via TVM Discuss
https://github.com/apache/incubator-tvm/blob/e89b19d95d/topi/include/topi/transform.h#L620 begin == end case is already supported. --- [Visit Topic](https://discuss.tvm.ai/t/can-slice-from-relay-support-empty-result/5889/5) to respond. You are receiving this because you enabled mailing l

Re: [apache/incubator-tvm] [Doc] TVM release process (#5151)

2020-03-26 Thread Tianqi Chen
Merged #5151 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/apache/incubator-tvm/pull/5151#event-3168931013

[TVM Discuss] [Development] Can `slice` from relay support empty result?

2020-03-26 Thread Heliqi via TVM Discuss
@kevinthesun As @lsy643 said, Can we adjust the code so `strided_slice` will return an empty array instead of raising an error? Such as when 'begin > end' or 'end == 0' or etc, we return an empty array or '_expr.const([],dtype = dtype)' --- [Visit Topic](https://discuss.tvm.ai/t/can-s

[TVM Discuss] [Development] Can `slice` from relay support empty result?

2020-03-26 Thread Heliqi via TVM Discuss
There's another piece of information,an error occurred while obtaining the end value: ``` def _stridedSlice(): end = _get_list_param(params, inputs[2]) error info: has no attribute name_hint ``` So,I change the code: ``` try: end = _get_list_param(params, inputs[2]

[TVM Discuss] [Development] Can `slice` from relay support empty result?

2020-03-26 Thread Heliqi via TVM Discuss
I have the same problem and add judgment: ``` if end == 0: return _expr.const([],dtype = dtype) ``` A new error is encountered later, and I'm not sure if it's related to this return value --- [Visit Topic](https://discuss.tvm.ai/t/can-slice-from-relay-support-empty-result/5889/2) to r

[TVM Discuss] [Development] [PyTorch] [Frontend] graph input names can change using loaded torchscript

2020-03-26 Thread Jeremy Johnson via TVM Discuss
Thanks for the comments - they have helped to shed light on things - :bulb:! I agree with the removal of the `output_map_index`, though my suggestion was to actually use this as a redirect to the same entries for the user supplied names. I.e. It would have entries for the user specified names

[TVM Discuss] [Development/RFC] [Relay] Improved graph partitioning algorithm

2020-03-26 Thread Manupa Karunaratne via TVM Discuss
@tico Have a look at our proposal : https://discuss.tvm.ai/t/rfc-byoc-an-extended-graph-partitioning-flow/6028. I think the "optimal" graph partitioning/mapping could be easily plugged in as the "De-conflict" step that we are proposing (Although, we are currently proposing a generic simple gr