Re: [PR] revoke early hints support on HTTP 1.1 [tomcat]

2024-11-22 Thread via GitHub
Chenjp commented on PR #783: URL: https://github.com/apache/tomcat/pull/783#issuecomment-2493135169 > Not interested in that one, sorry, Tomcat will implement what the Servlet specification says. @rmaucher till now, the 6.2 Spec is not officially published. -- This is an automated

Re: [PR] revoke early hints support on HTTP 1.1 [tomcat]

2024-11-22 Thread via GitHub
rmaucher closed pull request #783: revoke early hints support on HTTP 1.1 URL: https://github.com/apache/tomcat/pull/783 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] revoke early hints support on HTTP 1.1 [tomcat]

2024-11-22 Thread via GitHub
rmaucher commented on PR #783: URL: https://github.com/apache/tomcat/pull/783#issuecomment-2493131301 Not interested in that one, sorry, Tomcat will implement what the Servlet specification says. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[PR] enhanced http/2 early hints behavior [tomcat]

2024-11-22 Thread via GitHub
Chenjp opened a new pull request, #784: URL: https://github.com/apache/tomcat/pull/784 1. automatically flush when earlyHints called, to enable the possibility of server-think-time (programmatic code in web app) between the Early Hints headers and the final response. Speeding up page load

Re: [PR] enhanced http/2 early hints behavior [tomcat]

2024-11-22 Thread via GitHub
Chenjp commented on code in PR #784: URL: https://github.com/apache/tomcat/pull/784#discussion_r1853754550 ## java/org/apache/coyote/http2/Stream.java: ## @@ -604,10 +611,23 @@ final void writeAck() throws IOException { final void writeEarlyHints() throws IOException {

Re: [PR] minor update on .gitignore [tomcat]

2024-11-28 Thread via GitHub
Chenjp commented on PR #788: URL: https://github.com/apache/tomcat/pull/788#issuecomment-2505613190 > I've removed the `.DS_Store` file and added it to `.gitignore`. The presence of the other files is an indicator that something has gone wrong so they should not be ignored. I can see an iss

Re: [PR] fix typo [tomcat]

2024-11-28 Thread via GitHub
markt-asf commented on PR #789: URL: https://github.com/apache/tomcat/pull/789#issuecomment-2505615298 Yes, there should be an extra `)`. This has been fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] fix typo [tomcat]

2024-11-28 Thread via GitHub
markt-asf closed pull request #789: fix typo URL: https://github.com/apache/tomcat/pull/789 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr

Re: [PR] BZ69355: ExactRateLimiter [tomcat]

2024-11-28 Thread via GitHub
markt-asf commented on PR #767: URL: https://github.com/apache/tomcat/pull/767#issuecomment-2505639468 No changes to merge here. Looking forward to additional PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] BZ69355: ExactRateLimiter [tomcat]

2024-11-28 Thread via GitHub
markt-asf closed pull request #767: BZ69355: ExactRateLimiter URL: https://github.com/apache/tomcat/pull/767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] BZ69355: ExactRateLimiter [tomcat]

2024-11-28 Thread via GitHub
Chenjp commented on PR #767: URL: https://github.com/apache/tomcat/pull/767#issuecomment-2505642213 another one next week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] minor update on .gitignore [tomcat]

2024-11-28 Thread via GitHub
rmaucher commented on PR #788: URL: https://github.com/apache/tomcat/pull/788#issuecomment-2505661595 Slack in #tomcat ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] minor update on .gitignore [tomcat]

2024-11-28 Thread via GitHub
markt-asf commented on PR #788: URL: https://github.com/apache/tomcat/pull/788#issuecomment-2505594672 I've removed the `.DS_Store` file and added it to `.gitignore`. The presence of the other files is an indicator that something has gone wrong so they should not be ignored. I can see an is

Re: [PR] minor update on .gitignore [tomcat]

2024-11-28 Thread via GitHub
markt-asf closed pull request #788: minor update on .gitignore URL: https://github.com/apache/tomcat/pull/788 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] minor update on .gitignore [tomcat]

2024-11-28 Thread via GitHub
markt-asf commented on PR #788: URL: https://github.com/apache/tomcat/pull/788#issuecomment-2505633255 Apache projects prefer to communicate via public channels - typically the mailing list - rather than IM or other non-public channels. What we lose in terms of speed we more than gain in te

Re: [PR] Correctly Proxy Statement returned from ResultSet [tomcat]

2024-11-28 Thread via GitHub
robertonr commented on PR #742: URL: https://github.com/apache/tomcat/pull/742#issuecomment-2505865395 Hello proxies could be implemented dynamically using one of ASM libraries; Reflection is very expensive and taking into consideration the huge number of applications using Tomcat this chan

[PR] fix typo [tomcat]

2024-11-27 Thread via GitHub
Chenjp opened a new pull request, #789: URL: https://github.com/apache/tomcat/pull/789 minor typo fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[PR] minor update on .gitignore [tomcat]

2024-11-27 Thread via GitHub
Chenjp opened a new pull request, #788: URL: https://github.com/apache/tomcat/pull/788 ignore ds_store and ant test related outputs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Correctly Proxy Statement returned from ResultSet [tomcat]

2024-11-27 Thread via GitHub
robertonr commented on PR #742: URL: https://github.com/apache/tomcat/pull/742#issuecomment-2504365369 Hello, I think this change introduced an important performance penalty comparing my tests using 10.1.26 vs 10.1.27 -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Correctly Proxy Statement returned from ResultSet [tomcat]

2024-11-27 Thread via GitHub
markt-asf commented on PR #742: URL: https://github.com/apache/tomcat/pull/742#issuecomment-2504405168 You should test the latest version (although I suspect you'll see the same results). Use of proxies rather than wrappers was a design decision for jdbc-pool so it could handle chang

Re: [PR] Make status code configurable [tomcat]

2024-11-28 Thread via GitHub
markt-asf commented on PR #723: URL: https://github.com/apache/tomcat/pull/723#issuecomment-2506537080 I'm not seeing a clean way to differentiate between container set 400 status and application set. Closing this draft PR. I'd be happy to consider a PR if a clean solution can be found. -

Re: [PR] Make status code configurable [tomcat]

2024-11-28 Thread via GitHub
markt-asf closed pull request #723: Make status code configurable URL: https://github.com/apache/tomcat/pull/723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Partial put - enhance content range verification [tomcat]

2024-11-27 Thread via GitHub
markt-asf merged PR #778: URL: https://github.com/apache/tomcat/pull/778 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

Re: [PR] send 416 error to overlapping ranges request [tomcat]

2024-11-27 Thread via GitHub
markt-asf commented on PR #782: URL: https://github.com/apache/tomcat/pull/782#issuecomment-2504291618 Tx. Applied a variation manually. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] send 416 error to overlapping ranges request [tomcat]

2024-11-27 Thread via GitHub
markt-asf closed pull request #782: send 416 error to overlapping ranges request URL: https://github.com/apache/tomcat/pull/782 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] fix typo [tomcat]

2024-11-27 Thread via GitHub
ebourg commented on code in PR #789: URL: https://github.com/apache/tomcat/pull/789#discussion_r1861630238 ## java/org/apache/catalina/servlets/DefaultServlet.java: ## @@ -1487,7 +1487,7 @@ protected Ranges parseRange(HttpServletRequest request, HttpServletResponse resp

Re: [PR] Bump org.apache.tomcat:tomcat-catalina from 11.0.0-M22 to 11.0.0 in /modules/stuffed [tomcat]

2024-11-18 Thread via GitHub
dependabot[bot] closed pull request #781: Bump org.apache.tomcat:tomcat-catalina from 11.0.0-M22 to 11.0.0 in /modules/stuffed URL: https://github.com/apache/tomcat/pull/781 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Bump org.apache.tomcat:tomcat-catalina from 11.0.0-M22 to 11.0.0 in /modules/stuffed [tomcat]

2024-11-18 Thread via GitHub
dependabot[bot] commented on PR #781: URL: https://github.com/apache/tomcat/pull/781#issuecomment-2484937892 Looks like org.apache.tomcat:tomcat-catalina is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] send 416 error to overlapping ranges request [tomcat]

2024-11-19 Thread via GitHub
gmshake commented on PR #782: URL: https://github.com/apache/tomcat/pull/782#issuecomment-2485163715 Nice catch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] fix multipart/byteranges response body - length attri of ContentRange [tomcat]

2024-11-18 Thread via GitHub
rmaucher commented on PR #780: URL: https://github.com/apache/tomcat/pull/780#issuecomment-2483051390 Merged in main, 11 and 10.1. Test case added to 9.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] fix multipart/byteranges response body - length attri of ContentRange [tomcat]

2024-11-18 Thread via GitHub
rmaucher closed pull request #780: fix multipart/byteranges response body - length attri of ContentRange URL: https://github.com/apache/tomcat/pull/780 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[PR] Bump org.apache.tomcat:tomcat-catalina from 11.0.0-M22 to 11.0.0 in /modules/stuffed [tomcat]

2024-11-18 Thread via GitHub
dependabot[bot] opened a new pull request, #781: URL: https://github.com/apache/tomcat/pull/781 Bumps org.apache.tomcat:tomcat-catalina from 11.0.0-M22 to 11.0.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=

[PR] send 416 error to overlapping ranges request [tomcat]

2024-11-18 Thread via GitHub
Chenjp opened a new pull request, #782: URL: https://github.com/apache/tomcat/pull/782 request ranges validation - overlap detection added. * invalid ranges - overlapping: ``` D:\git\github.com>curl http://localhost:55464/index.html -i -H "Range: bytes=10-40,35-50" HTTP/1.1 4

Re: [PR] bz69439 - fix: improper handling of conflicting cache-control directives [tomcat]

2024-11-20 Thread via GitHub
markt-asf closed pull request #777: bz69439 - fix: improper handling of conflicting cache-control directives URL: https://github.com/apache/tomcat/pull/777 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] bz69439 - fix: improper handling of conflicting cache-control directives [tomcat]

2024-11-20 Thread via GitHub
markt-asf commented on PR #777: URL: https://github.com/apache/tomcat/pull/777#issuecomment-2489364168 Thanks for the PR. I have applied a fix based on this PR. Removing the cache-control header caching removes a deliberate performance optimisation (and doesn't update the Javadoc to r

[PR] Partial put - enhance content range verification [tomcat]

2024-11-14 Thread via GitHub
Chenjp opened a new pull request, #778: URL: https://github.com/apache/tomcat/pull/778 per [rfc 9110 - 14.4](https://httpwg.org/specs/rfc9110.html#field.content-range) - ContentRange - add isValid(), more length check. - ContentRange - parse(): make sure the not-null return of pars

Re: [PR] Partial put - enhance content range verification [tomcat]

2024-11-15 Thread via GitHub
rmaucher commented on PR #778: URL: https://github.com/apache/tomcat/pull/778#issuecomment-2479048290 Ok, that's correct, the end is also inclusive. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Partial put - enhance content range verification [tomcat]

2024-11-15 Thread via GitHub
Chenjp commented on PR #778: URL: https://github.com/apache/tomcat/pull/778#issuecomment-2478953548 > -1 Other that the lower case range, the shuffling around of the checks introduces a much more serious bug (&& length > end). A Content-Range field value is invalid if it contains a [

Re: [PR] Partial put - enhance content range verification [tomcat]

2024-11-15 Thread via GitHub
rmaucher commented on PR #778: URL: https://github.com/apache/tomcat/pull/778#issuecomment-2478347337 -1 Other that the lower case range, the shuffling around of the checks introduces a much more serious bug (&& length > end). -- This is an automated message from the Apache Git Service

Re: [PR] bz69442: Content type testcase [tomcat]

2024-11-25 Thread via GitHub
markt-asf commented on PR #779: URL: https://github.com/apache/tomcat/pull/779#issuecomment-2497763433 Thanks for the PR. I have applied a variation to 9.0.x, 10.1.x 11.0.x and main. The main changes were: - use a Servlet rather than a JSP - refactored the code to make `application

Re: [PR] bz69442: Content type testcase [tomcat]

2024-11-25 Thread via GitHub
markt-asf closed pull request #779: bz69442: Content type testcase URL: https://github.com/apache/tomcat/pull/779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[PR] BZ 69477: Wrong 'allowedInternalProxies' param name in the Remote IP Filter documentation [tomcat]

2024-11-27 Thread via GitHub
jorgediaz-lr opened a new pull request, #786: URL: https://github.com/apache/tomcat/pull/786 https://bz.apache.org/bugzilla/show_bug.cgi?id=69477 I have detected that the 'allowedInternalProxies' param name in the Remote IP Filter documentation here https://tomcat.apache.org/tomcat-1

Re: [PR] BZ 69477: Wrong 'allowedInternalProxies' param name in the Remote IP Filter documentation [tomcat]

2024-11-27 Thread via GitHub
markt-asf merged PR #786: URL: https://github.com/apache/tomcat/pull/786 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

[PR] Fix unsetting of httpOnly and secure flag [tomcat]

2024-11-27 Thread via GitHub
kriths opened a new pull request, #787: URL: https://github.com/apache/tomcat/pull/787 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] BZ 69477: Wrong 'allowedInternalProxies' param name in the Remote IP Filter documentation [tomcat]

2024-11-27 Thread via GitHub
jorgediaz-lr commented on PR #786: URL: https://github.com/apache/tomcat/pull/786#issuecomment-2503706162 Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] RateLimitFilter - enhance exposeHeaders to support "ietf rate limit h… [tomcat]

2024-11-27 Thread via GitHub
markt-asf commented on PR #775: URL: https://github.com/apache/tomcat/pull/775#issuecomment-2503658944 Thanks for the PR. I have applied a modified version to 12.0.x, 11.0.x, 10.1.x and 9.0.x. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] RateLimitFilter - enhance exposeHeaders to support "ietf rate limit h… [tomcat]

2024-11-27 Thread via GitHub
markt-asf closed pull request #775: RateLimitFilter - enhance exposeHeaders to support "ietf rate limit h… URL: https://github.com/apache/tomcat/pull/775 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Fix unsetting of httpOnly and secure flag [tomcat]

2024-11-27 Thread via GitHub
markt-asf commented on PR #787: URL: https://github.com/apache/tomcat/pull/787#issuecomment-2503730093 Sorry. Looks like our work on this overlapped. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Fix unsetting of httpOnly and secure flag [tomcat]

2024-11-27 Thread via GitHub
markt-asf closed pull request #787: Fix unsetting of httpOnly and secure flag URL: https://github.com/apache/tomcat/pull/787 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] fix incomplete chunked request body in testcase [tomcat]

2024-12-02 Thread via GitHub
Chenjp opened a new pull request, #792: URL: https://github.com/apache/tomcat/pull/792 add CRLF after the last-chunk to build a valid chunked request body. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] BZ69355: ExactRateLimiter [tomcat]

2024-11-16 Thread via GitHub
Chenjp commented on PR #767: URL: https://github.com/apache/tomcat/pull/767#issuecomment-2480547768 > I'm in favour of adding both the headers and the exact rate limiter. The PR just needs some refactoring and clean-up. Generally, several small changes are easier to review than one big chan

Re: [PR] send 416 error to overlapping ranges request [tomcat]

2024-11-25 Thread via GitHub
Chenjp commented on code in PR #782: URL: https://github.com/apache/tomcat/pull/782#discussion_r1857791659 ## java/org/apache/catalina/servlets/DefaultServlet.java: ## @@ -1231,10 +1231,25 @@ private static boolean validate(ContentRange range) { (range.getEnd()

Re: [PR] send 416 error to overlapping ranges request [tomcat]

2024-11-25 Thread via GitHub
Chenjp commented on code in PR #782: URL: https://github.com/apache/tomcat/pull/782#discussion_r1857791659 ## java/org/apache/catalina/servlets/DefaultServlet.java: ## @@ -1231,10 +1231,25 @@ private static boolean validate(ContentRange range) { (range.getEnd()

Re: [PR] fix incomplete chunked request body in testcase [tomcat]

2024-12-03 Thread via GitHub
markt-asf merged PR #792: URL: https://github.com/apache/tomcat/pull/792 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

Re: [PR] Reject Range-Request if those ranges are not strictly in ascending order [tomcat]

2024-12-03 Thread via GitHub
markt-asf merged PR #791: URL: https://github.com/apache/tomcat/pull/791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

Re: [PR] fix incorrect partial content response to HEAD request with-Range-header, or from Not-accept-range server [tomcat]

2024-12-03 Thread via GitHub
markt-asf commented on PR #790: URL: https://github.com/apache/tomcat/pull/790#issuecomment-2514678141 Note: It is not required for a server to send `Accept-Ranges` for it to process a request with `Range`. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] fix incorrect partial content response to HEAD request with-Range-header, or from Not-accept-range server [tomcat]

2024-12-03 Thread via GitHub
markt-asf merged PR #790: URL: https://github.com/apache/tomcat/pull/790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

Re: [PR] fix incorrect partial content response to HEAD request with-Range-header, or from Not-accept-range server [tomcat]

2024-12-03 Thread via GitHub
markt-asf commented on PR #790: URL: https://github.com/apache/tomcat/pull/790#issuecomment-2514634738 Needs some small changes but I'll do that after merging but before back-porting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] fix incorrect partial content response to HEAD request with-Range-header, or from Not-accept-range server [tomcat]

2024-12-03 Thread via GitHub
Chenjp commented on PR #790: URL: https://github.com/apache/tomcat/pull/790#issuecomment-2515063984 > Note: It is not required for a server to send `Accept-Ranges` for it to process a request with `Range`. Does value of ```useAcceptRanges``` determine the server enable / disable feat

Re: [PR] fix incorrect partial content response to HEAD request with-Range-header, or from Not-accept-range server [tomcat]

2024-12-03 Thread via GitHub
markt-asf commented on PR #790: URL: https://github.com/apache/tomcat/pull/790#issuecomment-2515073630 No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] fix incorrect partial content response to HEAD request with-Range-header, or from Not-accept-range server [tomcat]

2024-12-03 Thread via GitHub
markt-asf commented on PR #790: URL: https://github.com/apache/tomcat/pull/790#issuecomment-2515112985 If they really want to do that - and I can't think of a valid reason they would - they can write a Filter (or Valve) to remove the Range header. -- This is an automated message from the

Re: [PR] fix incorrect partial content response to HEAD request with-Range-header, or from Not-accept-range server [tomcat]

2024-12-03 Thread via GitHub
Chenjp commented on PR #790: URL: https://github.com/apache/tomcat/pull/790#issuecomment-2515107111 If app developer decide to disable ***Range Requests*** feature, how to? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] Reject Range-Request if those ranges are not strictly in ascending order [tomcat]

2024-12-04 Thread via GitHub
Chenjp commented on PR #791: URL: https://github.com/apache/tomcat/pull/791#issuecomment-2516674415 @markt-asf any issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] Reject Range-Request if those ranges are not strictly in ascending order [tomcat]

2024-12-04 Thread via GitHub
markt-asf commented on PR #791: URL: https://github.com/apache/tomcat/pull/791#issuecomment-2516693987 Yes. This change has been reverted. It is not RFC 9110 compliant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] fix incorrect partial content response to HEAD request with-Range-header, or from Not-accept-range server [tomcat]

2024-12-04 Thread via GitHub
markt-asf commented on PR #790: URL: https://github.com/apache/tomcat/pull/790#issuecomment-2516715364 Look at the history of the code. You'll need to go back a long way. There is definitely an argument for deprecating this option and removing it in Tomcat 12. -- This is an automated mess

Re: [PR] Reject Range-Request if those ranges are not strictly in ascending order [tomcat]

2024-12-04 Thread via GitHub
Chenjp commented on PR #791: URL: https://github.com/apache/tomcat/pull/791#issuecomment-2516821173 > Yes. This change has been reverted. It is not RFC 9110 compliant. It is not rfc required, remove this detector if reasonable cases endorse. Rfc uses term MAY, not MUST: A server

Re: [PR] Reject Range-Request if those ranges are not strictly in ascending order [tomcat]

2024-12-04 Thread via GitHub
rmaucher commented on PR #791: URL: https://github.com/apache/tomcat/pull/791#issuecomment-2516870493 Konstantin has provided examples of requests out there with these kind of ranges. Rejecting them provides no value to Tomcat, so the change was reverted. -- This is an automated message f

Re: [PR] Use UTF-8 for logging in Http11InputBuffer [tomcat]

2024-12-05 Thread via GitHub
markt-asf commented on PR #793: URL: https://github.com/apache/tomcat/pull/793#issuecomment-2519959571 We are only interested in the headers. The body could be using any encoding so whatever is chosen the body will be corrupted for some requests. -- This is an automated message from the A

Re: [PR] Use UTF-8 for logging in Http11InputBuffer [tomcat]

2024-12-05 Thread via GitHub
markt-asf closed pull request #793: Use UTF-8 for logging in Http11InputBuffer URL: https://github.com/apache/tomcat/pull/793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Use UTF-8 for logging in Http11InputBuffer [tomcat]

2024-12-05 Thread via GitHub
markt-asf commented on PR #793: URL: https://github.com/apache/tomcat/pull/793#issuecomment-2519884919 HTTP headers are expected to be ASCII, not UTF-8. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Use UTF-8 for logging in Http11InputBuffer [tomcat]

2024-12-05 Thread via GitHub
izeye commented on PR #793: URL: https://github.com/apache/tomcat/pull/793#issuecomment-2519950305 @markt-asf Thanks for the feedback! Did you mean to say that the log only contains headers? With [this sample](https://github.com/izeye/hello-spring-boot/tree/web), if I send the

Re: [PR] fix incorrect partial content response to HEAD request with-Range-header, or from Not-accept-range server [tomcat]

2024-12-03 Thread via GitHub
Chenjp commented on PR #790: URL: https://github.com/apache/tomcat/pull/790#issuecomment-2516346283 > No. If server enable Range-Requests feature and the target resource also support it, I think no good reason for the absence of ```Accept-Ranges: bytes``` response header. -- This

[PR] enhancemen: RateLimitFilter - Provides an exact rate limiting mechanism [tomcat]

2024-12-06 Thread via GitHub
Chenjp opened a new pull request, #794: URL: https://github.com/apache/tomcat/pull/794 smaller PR from https://github.com/apache/tomcat/pull/767 . If you need exact rate limiting and can accept a small decrease in efficiency, ExactRateLimiter may be an alternative option. -- This i

Re: [PR] Reject Range-Request if those ranges are not strictly in ascending order [tomcat]

2024-12-06 Thread via GitHub
Chenjp commented on PR #791: URL: https://github.com/apache/tomcat/pull/791#issuecomment-2522898421 Got it. If possible, send me those examples to study the scenario. thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] servlet profile added, covers javax.servlet only [tomcat-jakartaee-migration]

2025-01-06 Thread via GitHub
rw7 commented on PR #57: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/57#issuecomment-2573056116 Would be nice if there was any feedback on this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] Added wrapper class for SSLContext [tomcat]

2025-01-06 Thread via GitHub
Hakky54 opened a new pull request, #805: URL: https://github.com/apache/tomcat/pull/805 This PR is a followup of the following earlier PR https://github.com/apache/tomcat/pull/673 Although that pull request didn't get merged, the code changes has been comitted to the main branch by the main

Re: [PR] matchExcludesAgainstPathName not match with absolutePath and no rewrite file if not changed [tomcat-jakartaee-migration]

2025-01-07 Thread via GitHub
markt-asf commented on PR #60: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/60#issuecomment-2575956789 This PR is attempting to address two separate issues. It is better to stick to one issue per PR. I suggest moving the modification changes to a new PR (and include an ex

[I] Migration of defaultNamespaceRemap / com.sun.xml.bind references [tomcat-jakartaee-migration]

2025-01-07 Thread via GitHub
ahinc711 opened a new issue, #62: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/62 I'm using this tool with the `EE` profile to try converting some applications to Jakarta EE in the short term without uplifting all dependencies. I'm seeing runtime errors like the followin

Re: [I] Migration of defaultNamespaceRemap / com.sun.xml.bind references [tomcat-jakartaee-migration]

2025-01-08 Thread via GitHub
markt-asf commented on issue #62: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/62#issuecomment-2577142902 Hmm. The migration tool is designed on the basis that it "just" needs to rename some packages from `javax. ...` to `jakarta. ...`. What you are trying to do looks a

[PR] Bump org.apache.bcel:bcel from 6.9.0 to 6.10.0 [tomcat-jakartaee-migration]

2025-01-08 Thread via GitHub
dependabot[bot] opened a new pull request, #63: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/63 Bumps [org.apache.bcel:bcel](https://github.com/apache/commons-bcel) from 6.9.0 to 6.10.0. Changelog Sourced from https://github.com/apache/commons-bcel/blob/master/REL

[PR] Bump commons-io:commons-io from 2.16.1 to 2.18.0 [tomcat-jakartaee-migration]

2025-01-08 Thread via GitHub
dependabot[bot] opened a new pull request, #66: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/66 Bumps commons-io:commons-io from 2.16.1 to 2.18.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-nam

[PR] Bump org.apache.commons:commons-compress from 1.26.2 to 1.27.1 [tomcat-jakartaee-migration]

2025-01-08 Thread via GitHub
dependabot[bot] opened a new pull request, #67: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/67 Bumps org.apache.commons:commons-compress from 1.26.2 to 1.27.1. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?

[PR] Bump org.jacoco:jacoco-maven-plugin from 0.8.11 to 0.8.12 [tomcat-jakartaee-migration]

2025-01-08 Thread via GitHub
dependabot[bot] opened a new pull request, #65: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/65 Bumps [org.jacoco:jacoco-maven-plugin](https://github.com/jacoco/jacoco) from 0.8.11 to 0.8.12. Release notes Sourced from https://github.com/jacoco/jacoco/releases";>o

[PR] Bump org.apache.ant:ant from 1.10.14 to 1.10.15 [tomcat-jakartaee-migration]

2025-01-08 Thread via GitHub
dependabot[bot] opened a new pull request, #64: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/64 Bumps org.apache.ant:ant from 1.10.14 to 1.10.15. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name

Re: [PR] clean up org.apache.tomcat.util.http RequestUtil [tomcat]

2025-02-03 Thread via GitHub
koust6u commented on code in PR #818: URL: https://github.com/apache/tomcat/pull/818#discussion_r1939672492 ## java/org/apache/tomcat/util/http/RequestUtil.java: ## @@ -145,7 +138,7 @@ public static boolean isSameOrigin(HttpServletRequest request, String origin) {

Re: [PR] clean up org.apache.tomcat.util.http RequestUtil [tomcat]

2025-02-03 Thread via GitHub
markt-asf commented on code in PR #818: URL: https://github.com/apache/tomcat/pull/818#discussion_r1939680064 ## java/org/apache/tomcat/util/http/RequestUtil.java: ## @@ -123,19 +123,12 @@ public static boolean isSameOrigin(HttpServletRequest request, String origin) {

Re: [PR] clean up org.apache.tomcat.util.http RequestUtil [tomcat]

2025-02-03 Thread via GitHub
koust6u commented on code in PR #818: URL: https://github.com/apache/tomcat/pull/818#discussion_r1940452423 ## java/org/apache/tomcat/util/http/RequestUtil.java: ## @@ -123,19 +123,12 @@ public static boolean isSameOrigin(HttpServletRequest request, String origin) { //

Re: [PR] clean up org.apache.tomcat.util.http RequestUtil [tomcat]

2025-02-03 Thread via GitHub
koust6u commented on code in PR #818: URL: https://github.com/apache/tomcat/pull/818#discussion_r1940452423 ## java/org/apache/tomcat/util/http/RequestUtil.java: ## @@ -123,19 +123,12 @@ public static boolean isSameOrigin(HttpServletRequest request, String origin) { //

Re: [PR] log connectionId [tomcat]

2025-02-03 Thread via GitHub
Dmole commented on PR #814: URL: https://github.com/apache/tomcat/pull/814#issuecomment-2631971994 I added it to both AccessLogValve and ExtendedAccessLogValve because it is non-trivial for users to switch between them as the documentation does not provide a mapping (EG: %v = ?), and the ex

Re: [PR] certificate regression [tomcat]

2025-02-03 Thread via GitHub
Dmole commented on PR #815: URL: https://github.com/apache/tomcat/pull/815#issuecomment-2631976321 Looks like it was not "intentional" after all https://github.com/apache/tomcat/commit/904701a434325534b856b70f085dbe1dee05c43a -- This is an automated message from the Apache Git Service.

Re: [PR] Replace \r\n with SimpleHttpClient.CRLF in Http2TestBase & Cleanup RequestUtil [tomcat]

2025-02-03 Thread via GitHub
markt-asf commented on PR #817: URL: https://github.com/apache/tomcat/pull/817#issuecomment-2630498955 1 change per PR please. Note that we try to avoid static imports if at all possible. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] log connectionId [tomcat]

2025-02-03 Thread via GitHub
markt-asf commented on PR #814: URL: https://github.com/apache/tomcat/pull/814#issuecomment-2630509072 This is not the way to do this. Look at the ExtendedAccessLogValve. Look at `x-H(...)` options. -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] clean up org.apache.tomcat.util.http RequestUtil [tomcat]

2025-02-03 Thread via GitHub
funkman commented on code in PR #818: URL: https://github.com/apache/tomcat/pull/818#discussion_r1939578798 ## test/org/apache/tomcat/util/http/TestRequestUtilSameOrigin.java: ## @@ -42,6 +42,8 @@ public static Collection parameters() { TesterRequest request2 = new Test

Re: [PR] clean up org.apache.tomcat.util.http RequestUtil [tomcat]

2025-02-03 Thread via GitHub
koust6u commented on code in PR #818: URL: https://github.com/apache/tomcat/pull/818#discussion_r1939607782 ## test/org/apache/tomcat/util/http/TestRequestUtilSameOrigin.java: ## @@ -42,6 +42,8 @@ public static Collection parameters() { TesterRequest request2 = new Test

Re: [PR] certificate regression [tomcat]

2025-02-03 Thread via GitHub
rmaucher commented on PR #815: URL: https://github.com/apache/tomcat/pull/815#issuecomment-2631082908 > @rmaucher This is something worth mentioning in https://tomcat.apache.org/migration-9.html#Tomcat_9.0.x_noteable_changes for 9.0.83 and similar releases in the other branches. It's

Re: [PR] Replace \r\n with SimpleHttpClient.CRLF in Http2TestBase & Cleanup RequestUtil [tomcat]

2025-02-03 Thread via GitHub
koust6u closed pull request #817: Replace \r\n with SimpleHttpClient.CRLF in Http2TestBase & Cleanup RequestUtil URL: https://github.com/apache/tomcat/pull/817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] clean up org.apache.tomcat.util.http RequestUtil [tomcat]

2025-02-03 Thread via GitHub
koust6u opened a new pull request, #818: URL: https://github.com/apache/tomcat/pull/818 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix null stream issue for resource loading based on relative paths [tomcat]

2025-02-03 Thread via GitHub
markt-asf commented on PR #816: URL: https://github.com/apache/tomcat/pull/816#issuecomment-2630705976 `getResourceAsStream()` is documented to accept a name, not a URL. I'd like to understand the use case better before making any changes. Can you provide some sample code or a test case or

Re: [PR] certificate regression [tomcat]

2025-02-03 Thread via GitHub
Dmole commented on PR #815: URL: https://github.com/apache/tomcat/pull/815#issuecomment-2631122523 When editing the documentation please explain how requiring an empty password, in a text file, in an unrelated attribute, qualifies as security, and not just obscurity. -- This is an automa

Re: [PR] certificate regression [tomcat]

2025-02-03 Thread via GitHub
ChristopherSchultz commented on PR #815: URL: https://github.com/apache/tomcat/pull/815#issuecomment-2631002992 @rmaucher This is something worth mentioning in https://tomcat.apache.org/migration-9.html#Tomcat_9.0.x_noteable_changes for 9.0.83 and similar releases in the other branches. -

<    10   11   12   13   14   15   16   17   18   19   >