[GitHub] [tomcat] MikeNeilson commented on pull request #596: Use SELECT...FOR UPDATE to update session data in the database instead of DELETE, INSERT.

MikeNeilson commented on PR #596: URL: https://github.com/apache/tomcat/pull/596#issuecomment-1464984575 Considering the difficult of handling all situation for all databases perhaps the following: Punt the session update operation to a callback or interface, have one or two sensible

[GitHub] [tomcat] isapir commented on pull request #596: Use SELECT...FOR UPDATE to update session data in the database instead of DELETE, INSERT.

isapir commented on PR #596: URL: https://github.com/apache/tomcat/pull/596#issuecomment-1465001069 I would love to see an interface that goes a step further and allows for NoSQL implementations as well. For example, Redis is an excellent option for a data store IMO. -- This is an autom

[GitHub] [tomcat] isapir commented on pull request #596: Use SELECT...FOR UPDATE to update session data in the database instead of DELETE, INSERT.

isapir commented on PR #596: URL: https://github.com/apache/tomcat/pull/596#issuecomment-1465328932 > One way to fix this would be to add an optional PK column (columns?) to the configuration +1 for a Primary Key column. It improves performance and is supported by all SQL compliant

[GitHub] [tomcat] aooohan commented on pull request #596: Use SELECT...FOR UPDATE to update session data in the database instead of DELETE, INSERT.

aooohan commented on PR #596: URL: https://github.com/apache/tomcat/pull/596#issuecomment-1465410872 > One way to fix this would be to add an optional PK column (columns?) to the configuration. +1 -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [tomcat] isapir opened a new pull request, #598: Use available constants

isapir opened a new pull request, #598: URL: https://github.com/apache/tomcat/pull/598 We seem to have some duplication, e.g. `o.a.c.Globals.CATALINA_HOME_PROP` which is set from `o.a.c.startup.Constants.CATALINA_HOME_PROP`. Do we need `o.a.c.startup.Constants` to be separate for some

[GitHub] [tomcat] isapir commented on a diff in pull request #598: Use available constants

isapir commented on code in PR #598: URL: https://github.com/apache/tomcat/pull/598#discussion_r1133421847 ## java/org/apache/catalina/storeconfig/ConnectorStoreAppender.java: ## @@ -29,6 +29,7 @@ import java.util.List; import java.util.Set; +import org.apache.catalina.Globa

[GitHub] [tomcat] rmaucher commented on pull request #598: Use available constants

rmaucher commented on PR #598: URL: https://github.com/apache/tomcat/pull/598#issuecomment-1465711314 The thing to look for is to not add any dependencies to the bootstrap, but it looks ok here (I think). -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [tomcat] ChristopherSchultz commented on pull request #596: Use SELECT...FOR UPDATE to update session data in the database instead of DELETE, INSERT.

ChristopherSchultz commented on PR #596: URL: https://github.com/apache/tomcat/pull/596#issuecomment-1466223964 > I have a question that why we don't add a real **primary key**(auto-increment) to solve the problem that primary key constraint violation when insert data to database simultaneo

[GitHub] [tomcat] ChristopherSchultz commented on pull request #596: Use SELECT...FOR UPDATE to update session data in the database instead of DELETE, INSERT.

ChristopherSchultz commented on PR #596: URL: https://github.com/apache/tomcat/pull/596#issuecomment-1466230691 > I would love to see an interface that goes a step further and allows for NoSQL implementations as well. For example, Redis is an excellent option for a data store IMO. Th

[GitHub] [tomcat] ChristopherSchultz commented on pull request #596: Use SELECT...FOR UPDATE to update session data in the database instead of DELETE, INSERT.

ChristopherSchultz commented on PR #596: URL: https://github.com/apache/tomcat/pull/596#issuecomment-1466235515 > Punt the session update operation to a callback or interface, have one or two sensible defaults (like for the major databases and specific table configuration) and have a way fo

[GitHub] [tomcat] isapir commented on pull request #596: Use SELECT...FOR UPDATE to update session data in the database instead of DELETE, INSERT.

isapir commented on PR #596: URL: https://github.com/apache/tomcat/pull/596#issuecomment-1466395493 > This does bring up a good point: rather than having a new configuration option, I could simply have a subclass of DataSourceStore which overrides the store method to do the SELECT...FOR UPD

[GitHub] [tomcat] isapir commented on pull request #598: Use available constants

isapir commented on PR #598: URL: https://github.com/apache/tomcat/pull/598#issuecomment-1469170270 Thanks @rmaucher! I will watch out for that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [tomcat] isapir merged pull request #598: Use available constants

isapir merged PR #598: URL: https://github.com/apache/tomcat/pull/598 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

[GitHub] [tomcat] isapir opened a new pull request, #599: Use available constants

isapir opened a new pull request, #599: URL: https://github.com/apache/tomcat/pull/599 Created a branch and PR because my local git shows some new class files and I'm not sure where they came from so doing it this way so that I can safely review the patch before merging it -- This is an

[GitHub] [tomcat] isapir merged pull request #599: Use available constants

isapir merged PR #599: URL: https://github.com/apache/tomcat/pull/599 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

[GitHub] [tomcat] rmaucher commented on pull request #599: Use available constants

rmaucher commented on PR #599: URL: https://github.com/apache/tomcat/pull/599#issuecomment-1469470755 Personally, I hate these "work" branches. Please avoid them, and at the very least delete them afterwards. Thanks. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [tomcat] VirtualTim opened a new pull request, #600: echo the value of %JAVA_HOME% when it is invalid.

VirtualTim opened a new pull request, #600: URL: https://github.com/apache/tomcat/pull/600 This is useful for diagnosing %JAVA_HOME% issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [tomcat] rmaucher commented on pull request #473: Add support for additional user attributes to DataSourceRealm

rmaucher commented on PR #473: URL: https://github.com/apache/tomcat/pull/473#issuecomment-1473605786 Since I am looking at open PRs once in a while, I merged the pluming code for the user attributes with fd5b0fb6ea4aeeea8a3b3c95064b803068d531f9 I added more of the code to RealmBase, sinc

[GitHub] [tomcat] GHMOBILEMARCH opened a new pull request, #601: 8.5.x

GHMOBILEMARCH opened a new pull request, #601: URL: https://github.com/apache/tomcat/pull/601 Hello, Developer: I'd like to know if a header for client requests is useful, or how to enable a header that supports client requests. eg: accept eg: The client sets accept: image/jpeg and

[GitHub] [tomcat] VirtualTim commented on pull request #601: 8.5.x

VirtualTim commented on PR #601: URL: https://github.com/apache/tomcat/pull/601#issuecomment-1474802741 Yeah PR's aren't the place to ask questions. I believe that the only place for this is the tomcat mailing list - https://tomcat.apache.org/lists.html#tomcat-users. -- This is an auto

[GitHub] [tomcat] rmaucher closed pull request #601: 8.5.x

rmaucher closed pull request #601: 8.5.x URL: https://github.com/apache/tomcat/pull/601 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@

[GitHub] [tomcat] isapir commented on pull request #599: Use available constants

isapir commented on PR #599: URL: https://github.com/apache/tomcat/pull/599#issuecomment-1474902130 @rmaucher Sounds good. I added the branch because my local git repo had a bunch of class files and I wanted to make sure that I only push the changes that I meant to push. I will do better

[GitHub] [tomcat] kingjay66 commented on pull request #599: Use available constants

kingjay66 commented on PR #599: URL: https://github.com/apache/tomcat/pull/599#issuecomment-1475432850 Thanks for the update -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [tomcat-connectors] gjaekel opened a new pull request, #7: Possible issue in ajp_read_fully_from_server()

gjaekel opened a new pull request, #7: URL: https://github.com/apache/tomcat-connectors/pull/7 The the outer `while`-loop was changed to respect a padded length yeas before. But according to this, imho the `read()` should append the same number of bytes as a maximum, too. If I'm wrong, plea

[GitHub] [tomcat-connectors] markt-asf commented on pull request #7: Possible issue in ajp_read_fully_from_server()

markt-asf commented on PR #7: URL: https://github.com/apache/tomcat-connectors/pull/7#issuecomment-1476047870 The reason for this code: http://markmail.org/message/lowlwgb7fs4v3yuq It aims to ensure that there isn't an attempt to read when the buffer has insufficient space for a ch

[GitHub] [tomcat-connectors] markt-asf closed pull request #7: Possible issue in ajp_read_fully_from_server()

markt-asf closed pull request #7: Possible issue in ajp_read_fully_from_server() URL: https://github.com/apache/tomcat-connectors/pull/7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [tomcat-connectors] gjaekel commented on pull request #7: Possible issue in ajp_read_fully_from_server()

gjaekel commented on PR #7: URL: https://github.com/apache/tomcat-connectors/pull/7#issuecomment-1476084475 Dear Mark, first let my thank you for quick reply. I understand you in a way that this is already a "death code path" that can't rise issues anymore. I actually "staring

[GitHub] [tomcat-connectors] gjaekel commented on pull request #7: Possible issue in ajp_read_fully_from_server()

gjaekel commented on PR #7: URL: https://github.com/apache/tomcat-connectors/pull/7#issuecomment-1476151899 It seems, that the reason is very lame! With https://github.com/apache/httpd/commit/92499e20034485c5e2d29cb85940e309573d976e the default for _LimitRequestBody_ becomes **1GB** instead

[GitHub] [tomcat-connectors] rainerjung commented on pull request #7: Possible issue in ajp_read_fully_from_server()

rainerjung commented on PR #7: URL: https://github.com/apache/tomcat-connectors/pull/7#issuecomment-1476223841 Thanks for finding the reason. I guess there should have been a log message in the httpd error log. I now added the missing item for this change into the httpd CHANGES for under

[GitHub] [tomcat-connectors] gjaekel commented on pull request #7: Possible issue in ajp_read_fully_from_server()

gjaekel commented on PR #7: URL: https://github.com/apache/tomcat-connectors/pull/7#issuecomment-1476245704 Yes, it's in the error log. It's also quite easy to Google for it if you know that you have to search for the keyword `limitrequestbody`. :o The dev's of our application in scop

[GitHub] [tomcat] dependabot[bot] opened a new pull request, #603: Bump tomcat-catalina from 9.0.68 to 9.0.72 in /modules/openssl-java17

dependabot[bot] opened a new pull request, #603: URL: https://github.com/apache/tomcat/pull/603 Bumps tomcat-catalina from 9.0.68 to 9.0.72. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.tomcat:tomc

[GitHub] [tomcat] dependabot[bot] opened a new pull request, #602: Bump tomcat-catalina from 9.0.68 to 9.0.72 in /modules/openssl-foreign

dependabot[bot] opened a new pull request, #602: URL: https://github.com/apache/tomcat/pull/602 Bumps tomcat-catalina from 9.0.68 to 9.0.72. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.tomcat:tomc

[GitHub] [tomcat] markt-asf commented on pull request #602: Bump tomcat-catalina from 9.0.68 to 9.0.72 in /modules/openssl-foreign

markt-asf commented on PR #602: URL: https://github.com/apache/tomcat/pull/602#issuecomment-1481028384 Unwanted PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [tomcat] markt-asf closed pull request #602: Bump tomcat-catalina from 9.0.68 to 9.0.72 in /modules/openssl-foreign

markt-asf closed pull request #602: Bump tomcat-catalina from 9.0.68 to 9.0.72 in /modules/openssl-foreign URL: https://github.com/apache/tomcat/pull/602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [tomcat] dependabot[bot] commented on pull request #602: Bump tomcat-catalina from 9.0.68 to 9.0.72 in /modules/openssl-foreign

dependabot[bot] commented on PR #602: URL: https://github.com/apache/tomcat/pull/602#issuecomment-1481028450 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me

[GitHub] [tomcat] markt-asf commented on pull request #603: Bump tomcat-catalina from 9.0.68 to 9.0.72 in /modules/openssl-java17

markt-asf commented on PR #603: URL: https://github.com/apache/tomcat/pull/603#issuecomment-1481028719 Unwanted PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [tomcat] markt-asf closed pull request #603: Bump tomcat-catalina from 9.0.68 to 9.0.72 in /modules/openssl-java17

markt-asf closed pull request #603: Bump tomcat-catalina from 9.0.68 to 9.0.72 in /modules/openssl-java17 URL: https://github.com/apache/tomcat/pull/603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [tomcat] dependabot[bot] commented on pull request #603: Bump tomcat-catalina from 9.0.68 to 9.0.72 in /modules/openssl-java17

dependabot[bot] commented on PR #603: URL: https://github.com/apache/tomcat/pull/603#issuecomment-1481028838 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me

[GitHub] [tomcat] rmaucher commented on pull request #603: Bump tomcat-catalina from 9.0.68 to 9.0.72 in /modules/openssl-java17

rmaucher commented on PR #603: URL: https://github.com/apache/tomcat/pull/603#issuecomment-1481104406 I'll remember to update a bit more often to avoid this sort of unwanted noise ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [tomcat-jakartaee-migration] FSchumacher opened a new pull request, #45: Migrate SPI files in directories by renaming them to the jakartaee pr…

FSchumacher opened a new pull request, #45: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/45 …efix We already rename files in JAR files, so directory handling should follow here. A more correct way to handle this, would probably be to restrict the renaming to files,

[GitHub] [tomcat-jakartaee-migration] codecov-commenter commented on pull request #45: Migrate SPI files in directories by renaming them to the jakartaee pr…

codecov-commenter commented on PR #45: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/45#issuecomment-1483795564 ## [Codecov](https://codecov.io/gh/apache/tomcat-jakartaee-migration/pull/45?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=p

[GitHub] [tomcat-jakartaee-migration] ebourg commented on a diff in pull request #45: Migrate SPI files in directories by renaming them to the jakartaee pr…

ebourg commented on code in PR #45: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/45#discussion_r1148359861 ## src/test/java/org/apache/tomcat/jakartaee/MigrationTest.java: ## @@ -139,6 +139,39 @@ public void testMigrateDirectory() throws Exception { S

[GitHub] [tomcat-jakartaee-migration] ebourg commented on a diff in pull request #45: Migrate SPI files in directories by renaming them to the jakartaee pr…

ebourg commented on code in PR #45: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/45#discussion_r1148359876 ## src/test/java/org/apache/tomcat/jakartaee/MigrationTest.java: ## @@ -139,6 +139,39 @@ public void testMigrateDirectory() throws Exception { S

[GitHub] [tomcat] FSchumacher opened a new pull request, #604: Fix Bug 66543 - Wrong log message used in StandardContext#fireRequestDestroyEvent

FSchumacher opened a new pull request, #604: URL: https://github.com/apache/tomcat/pull/604 Give it its own log message instead of re-using the one from fireRequestInitEvent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [tomcat-jakartaee-migration] FSchumacher commented on a diff in pull request #45: Migrate SPI files in directories by renaming them to the jakartaee pr…

FSchumacher commented on code in PR #45: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/45#discussion_r1148360532 ## src/test/java/org/apache/tomcat/jakartaee/MigrationTest.java: ## @@ -139,6 +139,39 @@ public void testMigrateDirectory() throws Exception {

[GitHub] [tomcat-jakartaee-migration] ebourg merged pull request #45: Migrate SPI files in directories by renaming them to the jakartaee pr…

ebourg merged PR #45: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@

[GitHub] [tomcat] markt-asf commented on a diff in pull request #604: Fix Bug 66543 - Wrong log message used in StandardContext#fireRequestDestroyEvent

markt-asf commented on code in PR #604: URL: https://github.com/apache/tomcat/pull/604#discussion_r1148503570 ## webapps/docs/changelog.xml: ## @@ -174,6 +174,10 @@ with some OSGi custom URL schemes that can trigger potentially slow DNS lookups in some configur

[GitHub] [tomcat] markt-asf commented on pull request #594: Update CoyoteAdapter.java

markt-asf commented on PR #594: URL: https://github.com/apache/tomcat/pull/594#issuecomment-1484093432 I've applied what I believe to be the 'right' fix for this. We now use the web application class loader when looking up the session and checking the validity. -- This is an automated me

[GitHub] [tomcat] markt-asf closed pull request #594: Update CoyoteAdapter.java

markt-asf closed pull request #594: Update CoyoteAdapter.java URL: https://github.com/apache/tomcat/pull/594 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[GitHub] [tomcat] PasunuriSrinidhi commented on pull request #600: echo the value of %JAVA_HOME% when it is invalid.

PasunuriSrinidhi commented on PR #600: URL: https://github.com/apache/tomcat/pull/600#issuecomment-1484093801 if not "%JAVA_HOME%" == "" ( set "JAVA="%JAVA_HOME%\bin\java.exe"" ) else ( echo The JAVA_HOME environment variable is not defined correctly. echo JAVA_HOME="%JAVA_H

[GitHub] [tomcat] markt-asf merged pull request #604: Fix Bug 66543 - Wrong log message used in StandardContext#fireRequestDestroyEvent

markt-asf merged PR #604: URL: https://github.com/apache/tomcat/pull/604 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

[GitHub] [tomcat] markt-asf opened a new pull request, #605: Further fix for BZ 66508

markt-asf opened a new pull request, #605: URL: https://github.com/apache/tomcat/pull/605 https://bz.apache.org/bugzilla/show_bug.cgi?id=66508 Avoid deadlock for close messages when WsRemoteEndpointImplServer.endMessage() for a previous message is processed on a container thread

[GitHub] [tomcat] markt-asf commented on pull request #605: Further fix for BZ 66508

markt-asf commented on PR #605: URL: https://github.com/apache/tomcat/pull/605#issuecomment-1486301345 Sorry. Branch in wrong repo. I'll resubmit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tomcat] markt-asf closed pull request #605: Further fix for BZ 66508

markt-asf closed pull request #605: Further fix for BZ 66508 URL: https://github.com/apache/tomcat/pull/605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[GitHub] [tomcat] markt-asf opened a new pull request, #606: Further fix for BZ 66508

markt-asf opened a new pull request, #606: URL: https://github.com/apache/tomcat/pull/606 https://bz.apache.org/bugzilla/show_bug.cgi?id=66508 Avoid deadlock for close messages when WsRemoteEndpointImplServer.endMessage() for a previous message is processed on a container thread

[GitHub] [tomcat] rmaucher commented on pull request #606: Further fix for BZ 66508

rmaucher commented on PR #606: URL: https://github.com/apache/tomcat/pull/606#issuecomment-1487004868 Adding workarounds for this should be good (I suppose you have the means to test it on hand ;) ). I like the original goal of websockets to be built on the Servlet API, but there are some k

[GitHub] [tomcat] isapir opened a new pull request, #607: Added RateLimitFilter

isapir opened a new pull request, #607: URL: https://github.com/apache/tomcat/pull/607 This patch adds a RateLimitFilter based on the discussion in the Dev mailing list at [1] with more features to be added later [1] https://lists.apache.org/thread/0gt1kyjs86g9oqxofdgm0zbrb14lzgj6 -

[GitHub] [tomcat] markt-asf commented on pull request #606: Further fix for BZ 66508

markt-asf commented on PR #606: URL: https://github.com/apache/tomcat/pull/606#issuecomment-1487952742 I have a test in that I can manually trigger the issue with a debugger at the moment and can step through the code with the fix to confirm it works. My desire is to create a unit test the

[GitHub] [tomcat] aooohan commented on a diff in pull request #607: Added RateLimitFilter

aooohan commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1151643999 ## java/org/apache/catalina/filters/RateLimitFilter.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor l

[GitHub] [tomcat] aooohan commented on a diff in pull request #607: Added RateLimitFilter

aooohan commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1151651401 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor li

[GitHub] [tomcat] funkman commented on a diff in pull request #607: Added RateLimitFilter

funkman commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1151844920 ## java/org/apache/catalina/filters/RateLimitFilter.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor l

[GitHub] [tomcat] rmaucher commented on a diff in pull request #607: Added RateLimitFilter

rmaucher commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1151854974 ## java/org/apache/catalina/filters/RateLimitFilter.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[GitHub] [tomcat] funkman commented on a diff in pull request #607: Added RateLimitFilter

funkman commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1151886616 ## java/org/apache/catalina/filters/RateLimitFilter.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor l

[GitHub] [tomcat] isapir commented on a diff in pull request #607: Added RateLimitFilter

isapir commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1152128204 ## java/org/apache/catalina/filters/RateLimitFilter.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor li

[GitHub] [tomcat] aooohan commented on a diff in pull request #607: Added RateLimitFilter

aooohan commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1152661197 ## java/org/apache/catalina/filters/RateLimitFilter.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor l

[GitHub] [tomcat] rmaucher commented on a diff in pull request #607: Added RateLimitFilter

rmaucher commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1152944003 ## java/org/apache/catalina/filters/RateLimitFilter.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[GitHub] [tomcat] ChristopherSchultz commented on a diff in pull request #607: Added RateLimitFilter

ChristopherSchultz commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1153742361 ## java/org/apache/catalina/filters/RateLimitFilter.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * co

[GitHub] [tomcat] ChristopherSchultz commented on a diff in pull request #607: Added RateLimitFilter

ChristopherSchultz commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1153744130 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * con

[GitHub] [tomcat] isapir commented on a diff in pull request #607: Added RateLimitFilter

isapir commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1153762530 ## java/org/apache/catalina/filters/RateLimitFilter.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor li

[GitHub] [tomcat] isapir commented on a diff in pull request #607: Added RateLimitFilter

isapir commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1153771643 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor lic

[GitHub] [tomcat] ChristopherSchultz commented on a diff in pull request #607: Added RateLimitFilter

ChristopherSchultz commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1154550009 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * con

[GitHub] [tomcat] ChristopherSchultz commented on a diff in pull request #607: Added RateLimitFilter

ChristopherSchultz commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1154552815 ## java/org/apache/catalina/filters/RateLimitFilter.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * co

[GitHub] [tomcat] isapir commented on a diff in pull request #607: Added RateLimitFilter

isapir commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1154701109 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor lic

[GitHub] [tomcat] isapir commented on a diff in pull request #607: Added RateLimitFilter

isapir commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1154702239 ## java/org/apache/catalina/filters/RateLimitFilter.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor li

[GitHub] [tomcat] rmannibucau commented on a diff in pull request #607: Added RateLimitFilter

rmannibucau commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1154707393 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributo

[GitHub] [tomcat] rmannibucau commented on a diff in pull request #607: Added RateLimitFilter

rmannibucau commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1154709784 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributo

[GitHub] [tomcat] rmannibucau commented on a diff in pull request #607: Added RateLimitFilter

rmannibucau commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1154710887 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributo

[GitHub] [tomcat] rmannibucau commented on a diff in pull request #607: Added RateLimitFilter

rmannibucau commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1154712109 ## java/org/apache/catalina/filters/RateLimitFilter.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contribut

[GitHub] [tomcat] isapir commented on a diff in pull request #607: Added RateLimitFilter

isapir commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1154782761 ## java/org/apache/catalina/filters/RateLimitFilter.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor li

[GitHub] [tomcat] isapir commented on a diff in pull request #607: Added RateLimitFilter

isapir commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1154784584 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor lic

[GitHub] [tomcat] isapir commented on a diff in pull request #607: Added RateLimitFilter

isapir commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1154785188 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor lic

[GitHub] [tomcat] isapir commented on a diff in pull request #607: Added RateLimitFilter

isapir commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1154792436 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor lic

[GitHub] [tomcat] rmannibucau commented on a diff in pull request #607: Added RateLimitFilter

rmannibucau commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1154828691 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributo

[GitHub] [tomcat] isapir commented on a diff in pull request #607: Added RateLimitFilter

isapir commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1154883838 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor lic

[GitHub] [tomcat] rmannibucau commented on a diff in pull request #607: Added RateLimitFilter

rmannibucau commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1155068209 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributo

[GitHub] [tomcat] markt-asf commented on pull request #606: Further fix for BZ 66508

markt-asf commented on PR #606: URL: https://github.com/apache/tomcat/pull/606#issuecomment-1498929684 Updated and applied directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [tomcat] markt-asf closed pull request #606: Further fix for BZ 66508

markt-asf closed pull request #606: Further fix for BZ 66508 URL: https://github.com/apache/tomcat/pull/606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[GitHub] [tomcat] rmaucher commented on a diff in pull request #607: Added RateLimitFilter

rmaucher commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1160568819 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor l

[GitHub] [tomcat] rmannibucau commented on a diff in pull request #607: Added RateLimitFilter

rmannibucau commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1160576139 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributo

[GitHub] [tomcat] rmaucher commented on a diff in pull request #607: Added RateLimitFilter

rmaucher commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1160592553 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor l

[GitHub] [tomcat] rmannibucau commented on a diff in pull request #607: Added RateLimitFilter

rmannibucau commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1160616435 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributo

[GitHub] [tomcat] rmaucher commented on a diff in pull request #607: Added RateLimitFilter

rmaucher commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1160653462 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor l

[GitHub] [tomcat] rmannibucau commented on a diff in pull request #607: Added RateLimitFilter

rmannibucau commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1160660871 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributo

[GitHub] [tomcat] isapir commented on a diff in pull request #607: Added RateLimitFilter

isapir commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1161309823 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor lic

[GitHub] [tomcat] rmannibucau commented on a diff in pull request #607: Added RateLimitFilter

rmannibucau commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1161322529 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributo

[GitHub] [tomcat] rmaucher commented on a diff in pull request #607: Added RateLimitFilter

rmaucher commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1162435391 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor l

[GitHub] [tomcat] rmannibucau commented on a diff in pull request #607: Added RateLimitFilter

rmannibucau commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1162439073 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributo

[GitHub] [tomcat] markt-asf commented on pull request #600: echo the value of %JAVA_HOME% when it is invalid.

markt-asf commented on PR #600: URL: https://github.com/apache/tomcat/pull/600#issuecomment-1503021102 If neither `JRE_HOME` nor `JAVA_HOME` is defined, a message is already shown. I have undertaken a wider review of setclasspath.bat and service.bat and added additional messages when

[GitHub] [tomcat] markt-asf closed pull request #600: echo the value of %JAVA_HOME% when it is invalid.

markt-asf closed pull request #600: echo the value of %JAVA_HOME% when it is invalid. URL: https://github.com/apache/tomcat/pull/600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [tomcat] eirbjo opened a new pull request, #608: Remove uses of classes in deprecated package javax.security.cert

eirbjo opened a new pull request, #608: URL: https://github.com/apache/tomcat/pull/608 Efforts are underway in the OpenJDK project to remove the long deprecated-for-removal classes in the package `javax.security.cert`. These classes were introduced for backwards compatibility concerns with

<    1   2   3   4   5   6   7   8   9   10   >