markt-asf commented on code in PR #581:
URL: https://github.com/apache/tomcat/pull/581#discussion_r1094835289
##
java/org/apache/tomcat/buildutil/translate/Utils.java:
##
@@ -123,7 +123,7 @@ static String formatValueCommon(String in) {
result = ESCAPE_LEADING_SPACE.ma
tbw777 commented on code in PR #581:
URL: https://github.com/apache/tomcat/pull/581#discussion_r1094863229
##
java/org/apache/tomcat/buildutil/translate/Utils.java:
##
@@ -123,7 +123,7 @@ static String formatValueCommon(String in) {
result = ESCAPE_LEADING_SPACE.match
markt-asf commented on code in PR #581:
URL: https://github.com/apache/tomcat/pull/581#discussion_r1094884701
##
java/org/apache/tomcat/buildutil/translate/Utils.java:
##
@@ -123,7 +123,7 @@ static String formatValueCommon(String in) {
result = ESCAPE_LEADING_SPACE.ma
markt-asf commented on code in PR #581:
URL: https://github.com/apache/tomcat/pull/581#discussion_r1094893763
##
java/org/apache/tomcat/buildutil/translate/Utils.java:
##
@@ -123,7 +123,7 @@ static String formatValueCommon(String in) {
result = ESCAPE_LEADING_SPACE.ma
tbw777 commented on PR #581:
URL: https://github.com/apache/tomcat/pull/581#issuecomment-1414189316
@markt-asf
Branch was updated and
https://gist.github.com/tbw777/8a6ef60af21487c5faec67037099fd0b also
Check please.
--
This is an automated message from the Apache Git Service.
To r
gksxodnd007 commented on PR #579:
URL: https://github.com/apache/tomcat/pull/579#issuecomment-1414693058
@markt-asf
I see the reactor netty code to check how they close the connection when the
current request was not fully read.
they also close the connection even though that is keep-
rmaucher commented on PR #579:
URL: https://github.com/apache/tomcat/pull/579#issuecomment-1415375850
Of course, some instances of these status codes would be "ok" to recover
from, but Mark is actually right: it is not going to be deterministic.
Also it is not possible to add "defensive"
markt-asf commented on code in PR #581:
URL: https://github.com/apache/tomcat/pull/581#discussion_r1095639347
##
java/org/apache/tomcat/buildutil/translate/Utils.java:
##
@@ -123,7 +123,7 @@ static String formatValueCommon(String in) {
result = ESCAPE_LEADING_SPACE.ma
markt-asf merged PR #581:
URL: https://github.com/apache/tomcat/pull/581
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
ChristopherSchultz commented on PR #581:
URL: https://github.com/apache/tomcat/pull/581#issuecomment-1416015385
There isn't much of a difference between `String.replace` and
`String.replaceAll`. They both use regular expressions under the hood. Java's
`Pattern` class has a special case for
ChristopherSchultz commented on PR #581:
URL: https://github.com/apache/tomcat/pull/581#issuecomment-1416017516
I think this "performance improvement" is not an improvement and doesn't
affect performance in any meaningful way.
--
This is an automated message from the Apache Git Service.
T
ChristopherSchultz commented on PR #581:
URL: https://github.com/apache/tomcat/pull/581#issuecomment-1416024123
Apologies: my comments are rubbish after Java 9. Please forgive the noise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
gksxodnd007 commented on PR #579:
URL: https://github.com/apache/tomcat/pull/579#issuecomment-1416087598
@rmaucher
thank you for your explanation :) I understand. is there any better way that
reuses the connection for utilizing computing resources?
--
This is an automated message fro
markt-asf commented on PR #579:
URL: https://github.com/apache/tomcat/pull/579#issuecomment-1416093124
My suggestion at this point would be to use custom 4xx and 5xx status codes
in the application rather than re-using known codes.
--
This is an automated message from the Apache Git Servi
gksxodnd007 commented on PR #579:
URL: https://github.com/apache/tomcat/pull/579#issuecomment-1416100562
@markt-asf
I'm sorry, but I'll follow your opinion. and I learn about the request
smuggling risks while communication with you. thank you very much :)
--
This is an automated messa
gksxodnd007 closed pull request #579: Add activateDropConnection config to
choose drop connection by http status code
URL: https://github.com/apache/tomcat/pull/579
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
tbw777 opened a new pull request, #583:
URL: https://github.com/apache/tomcat/pull/583
SimpleDateFormatter isnt thread safe and deprecated with new jvm8 time API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
markt-asf commented on PR #579:
URL: https://github.com/apache/tomcat/pull/579#issuecomment-1420408534
No need for an apology. This has been a useful discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
aooohan merged PR #584:
URL: https://github.com/apache/tomcat/pull/584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
aooohan commented on PR #584:
URL: https://github.com/apache/tomcat/pull/584#issuecomment-1423869152
Thanks, I've cherry-picked this commit to other branch and make some minor
modification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
rmaucher commented on PR #506:
URL: https://github.com/apache/tomcat/pull/506#issuecomment-1424311002
I had a look at it and ended up merging the feature as
https://github.com/apache/tomcat/commit/2c2a1bd248b1ee200a0898c30e355802f0a6f7a6
We'll see what the final feedback on it is ...
--
rmaucher closed pull request #506: Adding Redirect and Proxy Error Reporting
Valves
URL: https://github.com/apache/tomcat/pull/506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
Madfarm opened a new pull request, #585:
URL: https://github.com/apache/tomcat/pull/585
You can deny this; I had to create a pull request for a school project
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
aooohan closed pull request #585: Update README.md
URL: https://github.com/apache/tomcat/pull/585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-un
aooohan commented on PR #587:
URL: https://github.com/apache/tomcat/pull/587#issuecomment-1425410871
-1
I don't think this change makes sense to do that, the current code is a bit
more intuitive.
As a reminder, when you propose a PR, we hope you will add some description
to avoid wast
aooohan closed pull request #587: Removed unused assignments
URL: https://github.com/apache/tomcat/pull/587
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
aooohan merged PR #588:
URL: https://github.com/apache/tomcat/pull/588
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
aooohan commented on code in PR #590:
URL: https://github.com/apache/tomcat/pull/590#discussion_r1102455984
##
java/org/apache/tomcat/util/http/fileupload/util/Streams.java:
##
@@ -106,12 +106,12 @@ public static long copy(final InputStream inputStream,
}
aooohan merged PR #590:
URL: https://github.com/apache/tomcat/pull/590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
dsoumis opened a new pull request, #16:
URL: https://github.com/apache/tomcat-native/pull/16
Update build.xml with new year.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
markt-asf closed pull request #16: Update build.xml with new year
URL: https://github.com/apache/tomcat-native/pull/16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
markt-asf commented on PR #16:
URL: https://github.com/apache/tomcat-native/pull/16#issuecomment-1425572722
Thanks for spotting this.
Better to automate this as I'll just forget to update it again next year.
I'll copy the config to do this from the Tomcat 11.0.x build.
--
This is an au
tbw777 commented on PR #590:
URL: https://github.com/apache/tomcat/pull/590#issuecomment-1426250991
@aooohan
```
ExecutorService
...
Since:
19
...
default void close() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
aooohan commented on PR #589:
URL: https://github.com/apache/tomcat/pull/589#issuecomment-1427559632
We are not able to modify these files, maybe you should report this to
[Jakarta project](https://github.com/jakartaee).
--
This is an automated message from the Apache Git Service.
To res
aooohan closed pull request #589: XSD patterns normalization
URL: https://github.com/apache/tomcat/pull/589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
tbw777 commented on PR #589:
URL: https://github.com/apache/tomcat/pull/589#issuecomment-1427636757
@aooohan ty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
markt-asf commented on PR #586:
URL: https://github.com/apache/tomcat/pull/586#issuecomment-1429675397
Thanks for the report. Fixed slightly differently (effectively the same
code) to align with the existing NIO2 code.
--
This is an automated message from the Apache Git Service.
To respon
markt-asf closed pull request #586: Fixed closing serverSocket in
doCloseServerSocket()
URL: https://github.com/apache/tomcat/pull/586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
markt-asf commented on code in PR #583:
URL: https://github.com/apache/tomcat/pull/583#discussion_r110573
##
java/org/apache/catalina/filters/RequestDumperFilter.java:
##
@@ -56,12 +59,13 @@ public class RequestDumperFilter extends GenericFilter {
private static final S
markt-asf commented on PR #582:
URL: https://github.com/apache/tomcat/pull/582#issuecomment-1429706205
What problem is this PR trying to solve?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
tbw777 commented on PR #582:
URL: https://github.com/apache/tomcat/pull/582#issuecomment-1429719724
no problem, just selecting less jvm api to work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ChristopherSchultz commented on PR #582:
URL: https://github.com/apache/tomcat/pull/582#issuecomment-1429782733
If no code requests anything AWT-related, then the headless config of the
JVM makes no difference. I see no improvement here at all, just added lines to
an already complex build s
tbw777 commented on PR #582:
URL: https://github.com/apache/tomcat/pull/582#issuecomment-1429800793
Also this is guarantee that no awt components used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
markt-asf commented on PR #578:
URL: https://github.com/apache/tomcat/pull/578#issuecomment-1430113794
I've applied this change via a combination of IDE tools and manual review as
the CheckStyle test for redundant modifiers covers more than just interface
methods.
I was initially in
markt-asf closed pull request #578: Remove redundant modifiers for interface
members
URL: https://github.com/apache/tomcat/pull/578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
ChristopherSchultz commented on PR #582:
URL: https://github.com/apache/tomcat/pull/582#issuecomment-1430168053
It does not guarantee that no AWT components are used. It only guarantees
that anything which requires an actual screen will fail (such as trying to open
a Frame, etc.). AWT is st
markt-asf commented on PR #582:
URL: https://github.com/apache/tomcat/pull/582#issuecomment-1430228290
I don't see any benefit to adding these extra settings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
markt-asf closed pull request #582: Enabled headless build configuration
URL: https://github.com/apache/tomcat/pull/582
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
dsoumis opened a new pull request, #591:
URL: https://github.com/apache/tomcat/pull/591
Implemented more special maps from
https://httpd.apache.org/docs/2.4/rewrite/rewritemap.html as implied by the
FIXME tag.
Added relevant tests and added ServletMapping to test int: MapType.
--
tbw777 closed pull request #583: Replaced old time API
URL: https://github.com/apache/tomcat/pull/583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: de
tbw777 opened a new pull request, #592:
URL: https://github.com/apache/tomcat/pull/592
https://gist.github.com/tbw777/8ce56d2cc3a0216012362d18b7262eb2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
zengwei2000 opened a new pull request, #593:
URL: https://github.com/apache/tomcat/pull/593
fix typo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
markt-asf closed pull request #593: Update CONTRIBUTING.md
URL: https://github.com/apache/tomcat/pull/593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
markt-asf commented on PR #593:
URL: https://github.com/apache/tomcat/pull/593#issuecomment-1437964475
That spelling is correct for US English.
Given the range of contributors to Tomcat, there is a mix of UK and US
English used in the Tomcat docs.
--
This is an automated message from t
rmaucher commented on PR #591:
URL: https://github.com/apache/tomcat/pull/591#issuecomment-1440111376
I merged it with a lot of changes and cleanups. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
rmaucher closed pull request #591: Implement more special maps for rewrite valve
URL: https://github.com/apache/tomcat/pull/591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
markt-asf commented on code in PR #592:
URL: https://github.com/apache/tomcat/pull/592#discussion_r1116803461
##
java/jakarta/servlet/jsp/resources/jspxml.xsd:
##
@@ -25,7 +25,7 @@
-
+
Review Comment:
The Tomcat project is unable to change these schema. We have to use
ChristopherSchultz commented on PR #592:
URL: https://github.com/apache/tomcat/pull/592#issuecomment-1443631640
I'm curious about performance data when the `\w` has other things added to
it, which is the case for all examples in Tomcat. This microbenchmark only
compares `[A-Za-z0-9_]` as th
tbw777 commented on PR #592:
URL: https://github.com/apache/tomcat/pull/592#issuecomment-1444501056
https://gist.github.com/tbw777/cd394ec67a01f9e7e8fe4d0c66d74637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
ChristopherSchultz commented on PR #592:
URL: https://github.com/apache/tomcat/pull/592#issuecomment-1444608082
Thanks @tbw777 for the updated micro-benchmarks. I agree that the
performance improvement is significant enough to warrant a change to Tomcat.
--
This is an automated message fr
tbw777 commented on PR #592:
URL: https://github.com/apache/tomcat/pull/592#issuecomment-1445017914
Compile speed
https://gist.github.com/tbw777/6a6303f64894e65a160d3f6321685d27
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
sharmanalin59 opened a new issue, #43:
URL: https://github.com/apache/tomcat-jakartaee-migration/issues/43
Kindly help with the below issue-:
25-Feb-2023 00:18:50.221 SEVERE [main]
org.apache.catalina.util.LifecycleBase.handleSubClassException Failed to start
component [Connector[AJP
markt-asf commented on issue #43:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/43#issuecomment-1445967136
Wrong project, wrong forum.
You want the Tomcat users mailing list:
https://tomcat.apache.org/lists.html#tomcat-users
--
This is an automated message fro
markt-asf closed issue #43: The AJP Connector is configured with
secretRequired="true"
URL: https://github.com/apache/tomcat-jakartaee-migration/issues/43
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
sharmanalin59 commented on issue #43:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/43#issuecomment-1445973344
Which is the right forum for tomcat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
markt-asf commented on issue #43:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/43#issuecomment-1446007408
Please read my previous comment.
This is the issue tracker for the Tomcat migration tool for Jakarta EE, not
Tomcat. Tomcat questions should be directed to th
sharmanalin59 commented on issue #43:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/43#issuecomment-1446063343
what is mailing list?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
markt-asf commented on issue #43:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/43#issuecomment-1446069013
https://tomcat.apache.org/lists.html#tomcat-users
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
dependabot[bot] opened a new pull request, #13:
URL: https://github.com/apache/tomcat-training/pull/13
Bumps [minimist](https://github.com/minimistjs/minimist) from 0.0.8 to 1.2.8.
Changelog
Sourced from https://github.com/minimistjs/minimist/blob/main/CHANGELOG.md";>minimist's
cha
dependabot[bot] commented on PR #3:
URL: https://github.com/apache/tomcat-training/pull/3#issuecomment-1447486061
Superseded by #13.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
dependabot[bot] closed pull request #3: Bump minimist from 0.0.8 to 1.2.6
URL: https://github.com/apache/tomcat-training/pull/3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
pangxianhai opened a new pull request, #594:
URL: https://github.com/apache/tomcat/pull/594
we have a problem at function parseSessionCookiesId. If the request has two
JSESSIONID on the Cookie. The session will init twice. So
request.isRequestedSessionIdValid() will be invoked. But at
req
pangxianhai commented on PR #594:
URL: https://github.com/apache/tomcat/pull/594#issuecomment-1452803563
we have a problem at function parseSessionCookiesId. If the request has two
JSESSIONID on the Cookie. The session will init twice. So
request.isRequestedSessionIdValid() will be invoked.
markt-asf commented on PR #594:
URL: https://github.com/apache/tomcat/pull/594#issuecomment-1453068854
Thanks for the PR. I understand the problem but this isn't the right fix. It
will break apps when there are two session cookies and the second one is the
only valid one.
--
This is an a
rmaucher commented on PR #539:
URL: https://github.com/apache/tomcat/pull/539#issuecomment-1453257058
I merged this with significant modifications. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
rmaucher closed pull request #539: JsonAccessLogValve: Add valve for structured
logging
URL: https://github.com/apache/tomcat/pull/539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
happyhua commented on PR #581:
URL: https://github.com/apache/tomcat/pull/581#issuecomment-1454685803
A replaceAll -> replace change in for example
`java/org/apache/tomcat/buildutil/translate/Utils.java` can produce different
output.
```
String source = "1\t2\t3";
aooohan commented on PR #595:
URL: https://github.com/apache/tomcat/pull/595#issuecomment-1457597852
Thanks for reporting this. However, I found differences between this file
and spec, so I will update it to align with spec.
--
This is an automated message from the Apache Git Service.
To
aooohan closed pull request #595: Exception message error
URL: https://github.com/apache/tomcat/pull/595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jbisotti opened a new issue, #44:
URL: https://github.com/apache/tomcat-jakartaee-migration/issues/44
From the documentation, it is unclear to me if this tools updates source
code or if it manipulates bytecode. Which is it? Thanks.
--
This is an automated message from the Apache Git Servi
ebourg commented on issue #44:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/44#issuecomment-1459025587
It works at both source and binary level, recursively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
markt-asf closed issue #44: Does this work tool work at the source or binary
level?
URL: https://github.com/apache/tomcat-jakartaee-migration/issues/44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
ChristopherSchultz opened a new pull request, #596:
URL: https://github.com/apache/tomcat/pull/596
I have only compile-tested this; I wanted to get feedback on the approach,
how to handle errors, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message,
ChristopherSchultz opened a new pull request, #597:
URL: https://github.com/apache/tomcat/pull/597
Fixes https://bz.apache.org/bugzilla/show_bug.cgi?id=58489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
isapir commented on PR #596:
URL: https://github.com/apache/tomcat/pull/596#issuecomment-1460841013
@ChristopherSchultz Is there a list of supported database systems with which
the DataSourceStore is compatible? Are you sure that they all support "SELECT
FOR UPDATE"? I tried to look that
isapir commented on code in PR #596:
URL: https://github.com/apache/tomcat/pull/596#discussion_r1130013002
##
java/org/apache/catalina/session/DataSourceStore.java:
##
@@ -626,15 +626,77 @@ public void save(Session session) throws IOException {
byte[] obs =
aooohan commented on code in PR #596:
URL: https://github.com/apache/tomcat/pull/596#discussion_r1130309107
##
java/org/apache/catalina/session/DataSourceStore.java:
##
@@ -626,15 +626,77 @@ public void save(Session session) throws IOException {
byte[] obs =
ChristopherSchultz commented on PR #596:
URL: https://github.com/apache/tomcat/pull/596#issuecomment-1462052065
> @ChristopherSchultz Is there a list of supported database systems with
which the DataSourceStore is compatible? Are you sure that they all support
"SELECT FOR UPDATE"? I tried t
ChristopherSchultz commented on code in PR #596:
URL: https://github.com/apache/tomcat/pull/596#discussion_r1131019399
##
java/org/apache/catalina/session/DataSourceStore.java:
##
@@ -626,15 +626,77 @@ public void save(Session session) throws IOException {
b
ChristopherSchultz commented on code in PR #596:
URL: https://github.com/apache/tomcat/pull/596#discussion_r1131033698
##
java/org/apache/catalina/session/DataSourceStore.java:
##
@@ -626,15 +626,77 @@ public void save(Session session) throws IOException {
b
isapir commented on code in PR #596:
URL: https://github.com/apache/tomcat/pull/596#discussion_r1131364805
##
java/org/apache/catalina/session/DataSourceStore.java:
##
@@ -626,15 +626,77 @@ public void save(Session session) throws IOException {
byte[] obs =
isapir commented on PR #596:
URL: https://github.com/apache/tomcat/pull/596#issuecomment-1462467192
Yeah, I guess that site is not up to date. I also used SELECT FOR UPDATE in
MySQL 5.7.
There is also INSERT ON CONFLICT UPDATE support in MySQL and Postgres, but
it would be difficult
aooohan commented on PR #596:
URL: https://github.com/apache/tomcat/pull/596#issuecomment-1463201626
I have a question that why we don't add a real **primary
key**(auto-increment) to solve the problem that primary key constraint
violation when insert data to database simultaneously? And we
aooohan closed pull request #592: Improved regexp performance: "a-zA-Z0-9_" ->
"\w"
URL: https://github.com/apache/tomcat/pull/592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
aooohan commented on PR #592:
URL: https://github.com/apache/tomcat/pull/592#issuecomment-1463387623
Merge manually, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
ChristopherSchultz commented on PR #596:
URL: https://github.com/apache/tomcat/pull/596#issuecomment-1463902816
The problem is that there is a window of opportunity between the existing
`DELETE` and `INSERT` where the `session_id` column (which is `UNIQUE` or
equivalent) can be `INSERT`ed b
FSchumacher commented on code in PR #597:
URL: https://github.com/apache/tomcat/pull/597#discussion_r1133086091
##
modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java:
##
@@ -222,19 +222,55 @@ protected QueryStats getQueryStats(String sql
ChristopherSchultz commented on code in PR #597:
URL: https://github.com/apache/tomcat/pull/597#discussion_r1133119845
##
modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java:
##
@@ -222,19 +222,55 @@ protected QueryStats getQueryStats(Str
ChristopherSchultz commented on PR #596:
URL: https://github.com/apache/tomcat/pull/596#issuecomment-1464952161
I've been thinking about this more and I think it could cause problems for
people not using appId+sessionId (or just sessionId) as the primary key for the
DB table storing the ses
FSchumacher commented on code in PR #597:
URL: https://github.com/apache/tomcat/pull/597#discussion_r1133134054
##
modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java:
##
@@ -222,19 +222,55 @@ protected QueryStats getQueryStats(String sql
1 - 100 of 1988 matches
Mail list logo
