[Taglibs] Is anyone looking after taglibs?

2011-11-03 Thread sebb
The Jakarta TLP is about to retire to the attic; however the taglibs site still refers to non-existent jakarta pages for the downloads. A bug [1] was raised for this for this some while ago, but there appears to be no-one interested in fixing the issue. [1] https://issues.apache.org/bugzilla/show

Re: Proposal: use tomcat-version-number in server.xml element?

2011-12-02 Thread sebb
On 2 December 2011 17:35, Christopher Schultz wrote: > Filip, > > On 12/2/11 12:26 PM, Filip Hanik - Dev Lists wrote: >> Chris, this would be your [cue] to rethink the solution one step further >> down the line. >> Not too long ago, I add in a property validator. Tomcat used to silently >> ignored

Re: Move to Nexus with no community discussion. WTF?

2011-12-16 Thread sebb
On 16 December 2011 16:15, Mark Thomas wrote: > On 16/12/2011 16:06, Antonio Petrelli wrote: >> Please Mark calm down. > > No, I will not calm down. The release process has been changed without > prior discussion and on top of that it is now broken for Maven > artefacts. That is not acceptable. >

Re: Publishing process for JARs for Maven Central

2011-12-16 Thread sebb
On 16 December 2011 23:45, Yoav Shapira wrote: > On Fri, Dec 16, 2011 at 2:56 PM, Mark Thomas wrote: >> All, >> >> There are currently two options for publishing JARs to Maven Central: >> 1. scp+rsync via people.a.o >> 2. Nexus > > I don't have a strong preference between them.  Is there a differ

Re: Publishing process for JARs for Maven Central

2011-12-17 Thread sebb
On 17 December 2011 05:19, Phil Steitz wrote: > On 12/16/11 12:56 PM, Mark Thomas wrote: >> All, >> >> There are currently two options for publishing JARs to Maven Central: >> 1. scp+rsync via people.a.o >> 2. Nexus >> >> Personally, my only requirements are: >> a) that the JARs reach Maven Centra

Re: Publishing process for JARs for Maven Central

2011-12-19 Thread sebb
On 18 December 2011 18:03, Phil Steitz wrote: > On 12/17/11 11:42 AM, Antonio Petrelli wrote: >> 2011/12/17 Mark Thomas >> >>> On 17/12/2011 18:35, Antonio Petrelli wrote: 2011/12/17 Mark Thomas > On 17/12/2011 18:14, Antonio Petrelli wrote: >> Ok then interprete my words as: n

Re: Move to Maven? (WAS: Re: Publishing process for JARs for Maven Central)

2011-12-19 Thread sebb
On 19 December 2011 08:36, Antonio Petrelli wrote: > 2011/12/17 Mark Thomas > >> On 17/12/2011 20:24, Antonio Petrelli wrote: >> > Ok, let's do it again :-D >> > 1. Standardization. Maven strongly encourages to use a standardized >> > structure. The source should go into src/main/java, the resour

Re: Move to Maven? (WAS: Re: Publishing process for JARs for Maven Central)

2011-12-19 Thread sebb
On 19 December 2011 14:16, Antonio Petrelli wrote: > 2011/12/19 sebb > >> On 19 December 2011 08:36, Antonio Petrelli >> wrote: >> > 2011/12/17 Mark Thomas >> > >> >> On 17/12/2011 20:24, Antonio Petrelli wrote: >> >> > Ok, l

[RFI] How do you package and upload Tomcat jars to Maven?

2012-01-13 Thread sebb
Some users are asking for JMeter jars to be uploaded to Maven Central. At present, we use Ant to build JMeter, so it would be useful to be able to just package up the jars and deploy them without needing to maintain dummy Maven poms. I can see that Tomcat7 jars are in Maven, but as far as I can t

Re: [RFI] How do you package and upload Tomcat jars to Maven?

2012-01-13 Thread sebb
On 13 January 2012 14:26, Mark Thomas wrote: > On 13/01/2012 13:41, Olivier Lamy wrote: >> Hello, >> Have a look here: >> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/trunk/res/maven/ Thanks, that's what I needed. Perhaps consider adding a reference to this at the end of /BUILDING.txt? > +1 a

Re: Nexus release problem

2012-01-16 Thread sebb
On 16 January 2012 09:43, Mark Thomas wrote: > It appears there is a problem with the Nexus release process. Prior to > the switch to Nexus, the Maven metedata contained all previous releases > [1]. Post the switch to Nexus, none of the previous releases appear in > the metadata [2]. > > The switc

Re: Nexus release problems

2012-01-16 Thread sebb
On 16 January 2012 10:53, Konstantin Kolinko wrote: > 2012/1/16 Mark Thomas : >> On 16/01/2012 09:43, Mark Thomas wrote: >>> It appears there is a problem with the Nexus release process. Prior to >>> the switch to Nexus, the Maven metedata contained all previous releases >>> [1]. Post the switch t

Re: [VOTE] Release Apache Tomcat 7.0.24

2012-01-16 Thread sebb
On 16 January 2012 13:02, Mark Thomas wrote: > On 16/01/2012 12:23, Olivier Lamy wrote: >> I think it's here (thanks) >> But you need to close it (tru the ui) in order we can consume >> artifacts from this staged repository. > > OK. Closed. Normally Nexus sends messages to a mailing list when sta

Re: DO NOT REPLY [Bug 52489] Enhancement request for code signing of war files

2012-01-19 Thread sebb
On 19 January 2012 14:51, wrote: > https://issues.apache.org/bugzilla/show_bug.cgi?id=52489 > > Sebb changed: > >           What    |Removed                     |Added > >            Summary|En

Re: DO NOT REPLY [Bug 52543] Exception

2012-01-27 Thread sebb
On 27 January 2012 13:38, wrote: > https://issues.apache.org/bugzilla/show_bug.cgi?id=52543 > > Pid changed: > >           What    |Removed                     |Added > >             Status|NEW                         |

Re: WebSocket progress report

2012-01-29 Thread sebb
On 29 January 2012 10:19, Mark Thomas wrote: > On 29/01/2012 01:20, Costin Manolache wrote: >> On Fri, Jan 27, 2012 at 3:09 PM, Mark Thomas wrote: >> >> Not complaining - it's great to add this feature, please commit it - but >> I'm wondering >> if a lighter interface wouldn't be better. From loo

Re: [VOTE] Apache Tomcat Maven plugin 2.0-beta-1

2012-02-01 Thread sebb
On 26 January 2012 18:05, Olivier Lamy wrote: > Hi, > > I'd like to release the Apache Tomcat Maven plugin 2.0-beta-1. > > The staging repository is available here: > https://repository.apache.org/content/repositories/orgapachetomcat-142/ > The documentation site is available here: > http://tomcat

Re: [VOTE] Apache Tomcat Maven plugin 2.0-beta-1

2012-02-01 Thread sebb
On 1 February 2012 11:13, Olivier Lamy wrote: > Hello, > Thanks for those suggestions ! > 2012/2/1 sebb : >> On 26 January 2012 18:05, Olivier Lamy wrote: >>> Hi, >>> >>> I'd like to release the Apache Tomcat Maven plugin 2.0-beta-1. >>>

Re: [VOTE] Apache Tomcat Maven plugin 2.0-beta-1

2012-02-01 Thread sebb
On 1 February 2012 10:14, Olivier Lamy wrote: > Hello, > As the others currently provided tomcat maven artifacts, adding those > in the download section doesn't have (IMHO) sense. > Because to be able to consume it within a maven build, users will have > to install it locally respecting the maven

Re: [VOTE] Apache Tomcat Maven plugin 2.0-beta-1

2012-02-01 Thread sebb
On 1 February 2012 11:56, Olivier Lamy wrote: > 2012/2/1 sebb : >> On 1 February 2012 10:14, Olivier Lamy wrote: >>> Hello, >>> As the others currently provided tomcat maven artifacts, adding those >>> in the download section doesn't have (IMHO) sense. &g

Re: [VOTE] Apache Tomcat Maven plugin 2.0-beta-1

2012-02-01 Thread sebb
On 1 February 2012 13:33, Olivier Lamy wrote: > 2012/2/1 Mark Thomas : >> On 01/02/2012 13:01, sebb wrote: >>> On 1 February 2012 11:56, Olivier Lamy wrote: >>>> 2012/2/1 sebb : >>>>> On 1 February 2012 10:14, Olivier Lamy wrote: >>>>

Re: svn commit: r1241356 - in /tomcat/trunk/java/org/apache/tomcat/jni: Poll.java SSL.java SSLExt.java

2012-02-07 Thread sebb
On 7 February 2012 06:13, wrote: > Author: costin > Date: Tue Feb  7 06:13:36 2012 > New Revision: 1241356 > > URL: http://svn.apache.org/viewvc?rev=1241356&view=rev > Log: > Add the new ssl methods from tomcat-native ( and few poll methods that seemed > to be missing ). > > APR connector will n

Re: svn commit: r1243508 - in /tomcat/site/trunk: docs/tools.html xdocs/tools.xml

2012-02-14 Thread sebb
On 13 February 2012 13:50, wrote: > Author: kkolinko > Date: Mon Feb 13 13:50:43 2012 > New Revision: 1243508 > > URL: http://svn.apache.org/viewvc?rev=1243508&view=rev > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52652 > Correct typos in tools.html > > s/licence/license/ seems

Re: Tomcat web site UI update

2012-02-23 Thread sebb
On 15 February 2012 20:04, Jeremy Brown wrote: >>That is a comment that the layout needs to be >>cleaner (a comment I agree with). > > I agree too. I tried to create a cleaner layout and I posted a mockup for > all to see and voice their opinions. > > https://s3.amazonaws.com/jjbosstracker/TomcatM

Re: svn commit: r1292891 - /tomcat/trunk/bin/daemon.sh

2012-02-23 Thread sebb
On 23 February 2012 19:00, Konstantin Kolinko wrote: > 2012/2/23  : >> Author: markt >> Date: Thu Feb 23 18:44:02 2012 >> New Revision: 1292891 >> >> URL: http://svn.apache.org/viewvc?rev=1292891&view=rev >> Log: >> Fix BZ52750. Correctly parse command options >> Port of r1292878 from 7.0.x >> >>

Re: [VOTE] Release Apache Taglibs Parent POM 1

2012-02-26 Thread sebb
On 26 February 2012 23:33, Jeremy Boynes wrote: > OK. Artefacts re-staged at > https://repository.apache.org/content/repositories/orgapachetomcat-084/ Looks a bit odd to have orgapachetomcat above yet the Maven package is org.apache.taglibs ? But perhaps that's just a feature of Nexus. Using

Re: [VOTE] Release Apache Taglibs Parent POM 1

2012-02-28 Thread sebb
On 28 February 2012 16:43, Mladen Turk wrote: > On 02/27/2012 12:33 AM, Jeremy Boynes wrote: >> >> OK. Artefacts re-staged at >> https://repository.apache.org/content/repositories/orgapachetomcat-084/ >> > > +1 > Signatures and content OK. > > Although not sure why you have LICENSE and LICENSE.txt

Re: [VOTE] Release Apache Taglibs Parent POM 1

2012-02-29 Thread sebb
s parent pom. > > Best regards, > Konstantin Kolinko > > >> On Feb 28, 2012, at 12:12 PM, Mladen Turk wrote: >> >>> On 02/28/2012 08:57 PM, sebb wrote: >>>> On 28 February 2012 16:43, Mladen Turk  wrote: >>>>> >>>>> Although

Re: svn commit: r1294943 - in /tomcat/taglibs/taglibs-parent/trunk: LICENSE.txt NOTICE.txt

2012-02-29 Thread sebb
On 29 February 2012 02:19, wrote: > Author: jboynes > Date: Wed Feb 29 02:19:53 2012 > New Revision: 1294943 > > URL: http://svn.apache.org/viewvc?rev=1294943&view=rev > Log: > remove LICENCE.txt and NOTICE.txt as they are automatically added by Maven > release process -1 I think that's the wr

Re: [VOTE] Release Apache Taglibs Parent POM 1

2012-02-29 Thread sebb
t; On Feb 29, 2012, at 9:14 AM, sebb wrote: > >> On 29 February 2012 05:11, Konstantin Kolinko wrote: >>> 2012/2/29 Jeremy Boynes : >>>> Removed from svn. A dry run of the next release shows they are >>>> automatically added to the source bundle. >&g

Re: [VOTE] Release Apache Taglibs Parent POM 1

2012-02-29 Thread sebb
OV) AFAICT that just moves the work from maintaining the N&L to creating and maintaining the metadata. It also means that the N&L files are not present in SVN (unless they are checked in after generation). > BTW Did you create any issues for that ? > > 2012/2/29 sebb : >> O

Re: svn commit: r1295724 - in /tomcat/trunk/webapps/examples/WEB-INF: classes/websocket/EchoMessage.java web.xml

2012-03-02 Thread sebb
On 1 March 2012 18:27, wrote: > Author: fhanik > Date: Thu Mar  1 18:27:56 2012 > New Revision: 1295724 > > URL: http://svn.apache.org/viewvc?rev=1295724&view=rev > Log: > Allow the examples to configure the buffer on the fly > > Modified: >    tomcat/trunk/webapps/examples/WEB-INF/classes/websoc

Re: License/Notice Files

2012-03-04 Thread sebb
On 4 March 2012 03:44, Jeremy Boynes wrote: > On Feb 29, 2012, at 11:37 AM, sebb wrote: > >> On 29 February 2012 19:15, Olivier Lamy wrote: >>> Perso, I prefer using something which read pom and generate >>> automatically N&L from metadatas rather than maintai

Re: License/Notice Files

2012-03-20 Thread sebb
n. If in the future we add > dependencies with notice requirements we can add that to the particular > module at that time. OK, great. > On Mar 4, 2012, at 5:40 PM, sebb wrote: > >> On 4 March 2012 03:44, Jeremy Boynes wrote: >>> On Feb 29, 2012, at 11:37 AM, sebb wr

Re: [VOTE] Release Apache Taglibs Parent POM 2

2012-03-24 Thread sebb
On 24 March 2012 14:45, Jeremy Boynes wrote: > The proposed 2 release of Apache Taglibs Parent POM is now available for > voting. > > This release addresses issues found during the 1 release process including > duplicate LICENSE files and poor site configuration. > > The Maven staging repo is: >

Re: Taglibs build #2 failed due to Hudson error

2012-03-31 Thread sebb
On 31 March 2012 03:23, Jeremy Boynes wrote: > From the log: > https://builds.apache.org/job/taglib-standard/2/consoleText > > Parsing POMs > ERROR: Failed to parse POMs > hudson.util.IOException2: remote file operation failed: > /home/jenkins/jenkins-slave/workspace/taglib-standard at > hudson.

Re: svn commit: r1336516 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/net/AbstractEndpoint.java webapps/docs/changelog.xml

2012-05-10 Thread sebb
On 10 May 2012 08:50, wrote: > Author: rjung > Date: Thu May 10 07:50:29 2012 > New Revision: 1336516 > > URL: http://svn.apache.org/viewvc?rev=1336516&view=rev > Log: > Add public method to retrieve the current connectionCount > from an endpoint. > > It will also show up in the ThreadPool MBean.

Re: [VOTE] Release Apache Tomcat Connectors 1.2.36

2012-05-11 Thread sebb
On 9 May 2012 15:25, Mladen Turk wrote: > Hi, > > Apache Tomcat Connectors 1.2.36 release candidate is ready > for vote at [1]. This version solves shared memorz regression(s) > found in released version 1.2.35 and allows )again= compiling > against old httpd 1.3.x. > > > The VOTE will remain open

Re: native connector tool chain

2012-05-24 Thread sebb
On 21 May 2012 21:01, Mark Thomas wrote: > On 21/05/2012 17:52, Mladen Turk wrote: >> On 05/21/2012 02:05 PM, Mark Thomas wrote: >>> I am trying to build the 1.1.x native connector from trunk so I can test >>> the changes I plan to make to support per socket time outs. I can build >>> using dynami

Re: [ANN] Apache Tomcat Native 1.1.24 released

2012-06-14 Thread sebb
On 14 June 2012 15:58, Mladen Turk wrote: > The Apache Tomcat team announces the immediate availability of Apache > Tomcat Native 1.1.24 stable. Please include a brief synopsis (1 or 2 sentences) of the purpose of the TLP/Product in all announcements sent outside the TLP mailing lists. The devel

Re: [VOTE] Release Apache Tomcat 7.0.28

2012-06-15 Thread sebb
On 15 June 2012 10:14, Mark Thomas wrote: > The proposed Apache Tomcat 7.0.28 release is now available for voting. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.28/ The NOTICE file for the source archive includes references to Nullsoft and Eclipse whic

Re: svn commit: r1360729 - in /tomcat/trunk: ./ modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/driver/ res/dbcp/

2012-07-14 Thread sebb
Do these patches need to be fed back to Commons DBCP? Or do they only apply to the version embedded by Tomcat? On 14 July 2012 21:47, Rainer Jung wrote: > On 14.07.2012 22:25, Filip Hanik Mailing Lists wrote: >> >> I know, it's the same patch for DBCP as for DBCP2. > > > Roger that. > > >> we ca

Re: svn commit: r1360729 - in /tomcat/trunk: ./ modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/driver/ res/dbcp/

2012-07-16 Thread sebb
mmons dev list. If no-one brings it > up sooner, I'll bring it up once Pool2 is sorted as work will naturally > move to dbcp2 at that point. > > Mark > >> >> - Original Message - >>> From: "sebb" >>> To: "Tomcat Developers

Re: svn commit: r1358055 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/

2012-07-16 Thread sebb
On 6 July 2012 07:53, wrote: > Author: fhanik > Date: Fri Jul 6 06:53:52 2012 > New Revision: 1358055 > > URL: http://svn.apache.org/viewvc?rev=1358055&view=rev > Log: > implement rev 1 of async/non blocking writes > > @@ -146,8 +226,12 @@ public class InternalNioOutputBuffer ext > * @thro

Re: svn commit: r1364419 - /tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java

2012-07-22 Thread sebb
On 22 July 2012 20:55, wrote: > Author: markt > Date: Sun Jul 22 19:55:50 2012 > New Revision: 1364419 > > URL: http://svn.apache.org/viewvc?rev=1364419&view=rev > Log: > Fingbugs: Fix possible NPE > > Modified: > > tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpPingInter

Re: [tomcat-maven-plugin] Is it only for Maven 3 and later? (was: svn commit r1367640)

2012-08-02 Thread sebb
On 1 August 2012 19:39, Konstantin Kolinko wrote: > 2012/7/31 : >> Author: olamy >> Date: Tue Jul 31 16:01:20 2012 >> New Revision: 1367640 >> >> URL: http://svn.apache.org/viewvc?rev=1367640&view=rev >> Log: >> [MTOMCAT-157] use new Maven Plugins annotations. done for tomcat6 mojos. >> >> Modifi

Re: svn commit: r1358055 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/

2012-08-03 Thread sebb
On 6 July 2012 07:53, wrote: > Author: fhanik > Date: Fri Jul 6 06:53:52 2012 > New Revision: 1358055 > > URL: http://svn.apache.org/viewvc?rev=1358055&view=rev > Log: > implement rev 1 of async/non blocking writes > > > Modified: > tomcat/trunk/java/org/apache/coyote/http11/InternalNioOutputB

Re: Re-factoring TLD parsing

2012-08-16 Thread sebb
On 16 August 2012 23:44, Christopher Schultz wrote: > All, > > The first item in the TOMCAT-NEXT.txt is this: > > 1. Refactor the TLD parsing. TLDs are currently parsed twice. Once by > Catalina looking for listeners and once by Jasper. > > I had a conversation in Vancouver with David Blevins

Re: Re-factoring TLD parsing

2012-08-17 Thread sebb
On 17 August 2012 05:00, Christopher Schultz wrote: > Sebb, > > On 8/16/12 7:11 PM, sebb wrote: >> On 16 August 2012 23:44, Christopher Schultz >> wrote: >>> >>> I had a conversation in Vancouver with David Blevins about the scourge >>> o

Re: svn commit: r1397522 - in /tomcat/trunk/java/javax/net: ./ websocket/ websocket/annotations/ websocket/extensions/

2012-10-16 Thread sebb
On 12 October 2012 13:39, Mark Thomas wrote: > On 12/10/2012 13:24, Martin Grigorov wrote: > > Please use quoting, particularly when you have a few short comments on a > very large e-mail. Without quoting, your comments were more effort to find. > >>> Added: tomcat/trunk/java/javax/net/websocket/H

Re: svn commit: r784083 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/core/ java/org/apache/naming/resources/ webapps/docs/config/

2009-06-12 Thread sebb
On 12/06/2009, ma...@apache.org wrote: > Author: markt > Date: Fri Jun 12 11:38:29 2009 > New Revision: 784083 > > URL: http://svn.apache.org/viewvc?rev=784083&view=rev > Log: > Implement alias resources. Key features: > - configured at the context level in the same way as the other resource

Re: [VOTE] Release JDBC Pool module v1.0.3

2009-06-15 Thread sebb
On 15/06/2009, Filip Hanik - Dev Lists wrote: > Sebb, thanks for the feedback. > > sebb wrote: > > > Apart from the problems with N&L files etc that have already been > > mentioned, I found the following: > > > > == > > > > The chang

Re: [VOTE] Release JDBC Pool module v1.0.4

2009-06-15 Thread sebb
On 15/06/2009, Filip Hanik - Dev Lists wrote: > Cleaned up and fixed. > > The release is located here: > http://people.apache.org/~fhanik/jdbc-pool/v1.0.4/ NOTICE file is incorrect, it should read: >>> Apache Tomcat JDBC Pool Copyright 2008-2009 The Apache Software Foundation This product inc

Re: [VOTE] Release build 4.1.40

2009-06-16 Thread sebb
The copyright year in the NOTICE files in the binary archive is still 2008; surely it should be 2009? The connectors/NOTICE file in the source archive is wrong. There are no NOTICE files for the jasper and servletapi directory sub-trees. It would be better to have a single N&L file at the top of

Re: svn commit: r785164 - /tomcat/container/branches/tc4.1.x/build.xml

2009-06-16 Thread sebb
On 16/06/2009, ma...@apache.org wrote: > Author: markt > Date: Tue Jun 16 11:17:26 2009 > New Revision: 785164 > > URL: http://svn.apache.org/viewvc?rev=785164&view=rev > Log: > Update exclusion list for EOL filtering > > Modified: > tomcat/container/branches/tc4.1.x/build.xml > > Modif

Re: svn commit: r785164 - /tomcat/container/branches/tc4.1.x/build.xml

2009-06-16 Thread sebb
On 16/06/2009, Mark Thomas wrote: > sebb wrote: > > On 16/06/2009, ma...@apache.org wrote: > >> Author: markt > >> Date: Tue Jun 16 11:17:26 2009 > >> New Revision: 785164 > >> > >> URL: http://svn.apache.org/viewvc?rev=785164&

Re: [VOTE] [CANCELLED] Release build 4.1.40

2009-06-16 Thread sebb
; > [ ] Broken > > [ ] Alpha > > [ ] Beta > > [ ] Stable > > > There were enough issues to re-roll the release. For the record, I tried > and failed on several machines to recreate the problem sebb saw so I can > only assume it was a local JVM issue. I'v

Re: [VOTE] [CANCELLED] Release build 4.1.40

2009-06-16 Thread sebb
On 16/06/2009, Mark Thomas wrote: > sebb wrote: > > On 16/06/2009, Mark Thomas wrote: > >> Mark Thomas wrote: > >> > The candidates source tarball and derived binaries are available here: > >> > http://tomcat.apache.org/dev/dist/apache-tomcat-

Re: [VOTE] Release JDBC Pool module v1.0.4

2009-06-16 Thread sebb
On 16/06/2009, Filip Hanik - Dev Lists wrote: > Sebb, I can't find anything that is broken. All your concerns seem invalid > to me. Please revisit, especially the NOTICE files. > Filip > > sebb wrote: > > > On 15/06/2009, Filip Hanik - Dev Lists wrote: >

Re: [VOTE] Release JDBC Pool module v1.0.4

2009-06-17 Thread sebb
On 17/06/2009, Filip Hanik - Dev Lists wrote: > sebb wrote: > > > On 16/06/2009, Filip Hanik - Dev Lists wrote: > > > > > > > Sebb, I can't find anything that is broken. All your concerns seem > invalid > > > to me. > > > > > >

Re: svn commit: r785952 - in /tomcat/trunk/test/org/apache/catalina/valves: ./ Benchmarks.java

2009-06-18 Thread sebb
On 18/06/2009, Mark Thomas wrote: > Tim Funk wrote: > > I think this needs to be volatile ? > > In (GetDateBenchmarkTest) > >> +private long currentMillis = 0; > > > > Same for (in TimeDateElementBenchmarkTest) > >> +private Date currentDate = null; > > > > Of course - sinc

Re: svn commit: r785952 - in /tomcat/trunk/test/org/apache/catalina/valves: ./ Benchmarks.java

2009-06-18 Thread sebb
On 18/06/2009, sebb wrote: > On 18/06/2009, Mark Thomas wrote: > > Tim Funk wrote: > > > I think this needs to be volatile ? > > > In (GetDateBenchmarkTest) > > >> +private long currentMillis = 0; > > > > > > Same for (i

Re: [VOTE] Release JDBC Pool module v1.0.4

2009-06-18 Thread sebb
On 19/06/2009, Filip Hanik - Dev Lists wrote: > So now that we've clarified that NOTICE and LICENSE covers the entire > release as an entity, No idea what you mean by that, but anyway: As I have written several times before, the NOTICE file is incorrect. This applies to the version in the SVN ta

Duplicate code in AccessLogValve

2009-06-19 Thread sebb
Just spotted this duplicate code in AccessLogValve: 661:if (!dateStamp.equals(tsDate)) { 662:if (!dateStamp.equals(tsDate)) { Not sure this double-checked looking offers any benefit ;-) --

Re: Duplicate code in AccessLogValve

2009-06-19 Thread sebb
On 19/06/2009, sebb wrote: > Just spotted this duplicate code in AccessLogValve: > > 661:if (!dateStamp.equals(tsDate)) { > 662:if (!dateStamp.equals(tsDate)) { > > Not sure this double-checked looking offers any benefit

Re: Duplicate code in AccessLogValve

2009-06-19 Thread sebb
etimes create a new Date unecessarily. > > > 2009/6/19 sebb > > > > On 19/06/2009, sebb wrote: > > > Just spotted this duplicate code in AccessLogValve: > > > > > > 661:if (!dateStamp.equals(tsDate)) { &

Re: svn commit: r786532 - /tomcat/trunk/modules/jdbc-pool/NOTICE

2009-06-19 Thread sebb
On 19/06/2009, fha...@apache.org wrote: > Author: fhanik > Date: Fri Jun 19 15:05:04 2009 > New Revision: 786532 > > URL: http://svn.apache.org/viewvc?rev=786532&view=rev > Log: > Correct per sebb/markt Sorry, but this is still incorrect. The NOTICE is now:

Re: svn commit: r786569 - /tomcat/trunk/modules/jdbc-pool/NOTICE

2009-06-19 Thread sebb
On 19/06/2009, fha...@apache.org wrote: > Author: fhanik > Date: Fri Jun 19 16:16:16 2009 > New Revision: 786569 > > URL: http://svn.apache.org/viewvc?rev=786569&view=rev > Log: > correction > > Modified: > tomcat/trunk/modules/jdbc-pool/NOTICE > > Modified: tomcat/trunk/modules/jdbc-po

Re: [VOTE] Release build 4.1.40 - Take 2

2009-06-19 Thread sebb
On 16/06/2009, Mark Thomas wrote: > The (updated) candidates source tarball and derived binaries are > available here: > http://tomcat.apache.org/dev/dist/apache-tomcat-4.1.40/ > > According to the release process, the release based on the 4.0.40 tag is: Did you mean 4.1.40? Also, where can I

Re: [VOTE] Release build 4.1.40 - Take 2

2009-06-19 Thread sebb
On 19/06/2009, Mark Thomas wrote: > sebb wrote: > > On 16/06/2009, Mark Thomas wrote: > >> The (updated) candidates source tarball and derived binaries are > >> available here: > >> http://tomcat.apache.org/dev/dist/apache-tomcat-4.1.40/ > >>

Re: svn commit: r786631 - /tomcat/trunk/test/org/apache/catalina/valves/Benchmarks.java

2009-06-19 Thread sebb
On 19/06/2009, kkoli...@apache.org wrote: > Author: kkolinko > Date: Fri Jun 19 18:57:59 2009 > New Revision: 786631 > > URL: http://svn.apache.org/viewvc?rev=786631&view=rev > Log: > Add two more implementations for the second test. > a) using a single ThreadLocal instead of multiple ones >

Re: [VOTE] Release build 4.1.40 - Take 2

2009-06-19 Thread sebb
On 19/06/2009, Mark Thomas wrote: > sebb wrote: > > The source archives mostly agree with the tags, however there are code > > changes in the following files: > > > > connectors/http11/src/java/org/apache/coyote/http11/Http11Processor.java > > connectors/uti

Re: svn commit: r786653 - /tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java

2009-06-19 Thread sebb
On 19/06/2009, ma...@apache.org wrote: > Author: markt > Date: Fri Jun 19 20:21:53 2009 > New Revision: 786653 > > URL: http://svn.apache.org/viewvc?rev=786653&view=rev > Log: > Switch to ThreadLocal where possible. This removes all the syncs apart from > those related to accessing the log f

Re: svn commit: r787211 - /tomcat/trunk/test/org/apache/catalina/startup/TestTomcat.java

2009-06-22 Thread sebb
On 22/06/2009, ma...@apache.org wrote: > Author: markt > Date: Mon Jun 22 11:58:07 2009 > New Revision: 787211 > > URL: http://svn.apache.org/viewvc?rev=787211&view=rev > Log: > Fix a couple of Eclipse warnings > > Modified: > tomcat/trunk/test/org/apache/catalina/startup/TestTomcat.java

Re: Please review JDBC Pool before vote

2009-06-22 Thread sebb
On 22/06/2009, Filip Hanik - Dev Lists wrote: > in the spirit of trying to get my poop right, > > http://people.apache.org/~fhanik/jdbc-pool/v1.0.5/ Looks a lot better. > the binary releases contain everything in individual jar files (including > source references for IDEs) However, there are

Re: [VOTE] Release JDBC Pool module v1.0.5

2009-06-25 Thread sebb
On 24/06/2009, Filip Hanik - Dev Lists wrote: > Cleaned up and fixed. > > The release is located here: > http://people.apache.org/~fhanik/jdbc-pool/v1.0.5/ Exactly the same path names were used previously; I assume you are referring to the following versions of the files: apache-tomcat-jdbc-1.

Re: [VOTE] Release JDBC Pool module v1.0.5

2009-06-26 Thread sebb
On 26/06/2009, Filip Hanik - Dev Lists wrote: > sebb wrote: > > > On 24/06/2009, Filip Hanik - Dev Lists wrote: > > > > > > > Cleaned up and fixed. > > > > > > The release is located here: > > > http://people.apache.org/~fhanik/jdbc-

Re: [VOTE] Release JDBC Pool module v1.0.5

2009-06-26 Thread sebb
On 26/06/2009, Filip Hanik - Dev Lists wrote: > sebb wrote: > > > On 26/06/2009, Filip Hanik - Dev Lists wrote: > > > > > > > sebb wrote: > > > > > > > > > > > > > On 24/06/2009, Filip Hanik - Dev List

Re: [VOTE] Release JDBC Pool module v1.0.5

2009-06-26 Thread sebb
When testing with Derby on Java 1.6.0 I get the following error: [junit] Running org.apache.tomcat.jdbc.test.StarvationTest [junit] Testsuite: org.apache.tomcat.jdbc.test.StarvationTest [junit] AbandonedObjectPool is used (org.apache.tomcat.dbcp.dbcp.abandonedobjectp...@1d6096) [ju

Re: svn commit: r788214 - /tomcat/current/tc5.5.x/STATUS.txt

2009-06-27 Thread sebb
On 27/06/2009, Xie Xiaodong wrote: > But how could ThreadLocal be shared among all AccessLogValve instances on > the same server? After all, each thread access ThreadLocal has its own. > > Another point, based on the java doc of ThreadLocal, maybe "private > ThreadLocal currentDateStruct" shoul

Re: [VOTE] Release JDBC Pool module v1.0.5

2009-06-28 Thread sebb
I've just realised that there is no Javadoc in any of the archives. The only documentation is in the form of a web-page, which is fine as far as it goes, but is really not enough for a general-purpose library. I would expect to see the Javadoc included in binary releases. On 24/06/2009, Filip Ha

Re: svn commit: r789392 - in /tomcat/trunk/modules/jdbc-pool: ./ test/org/apache/tomcat/jdbc/test/

2009-06-29 Thread sebb
On 29/06/2009, fha...@apache.org wrote: > Author: fhanik > Date: Mon Jun 29 17:38:21 2009 > New Revision: 789392 > > URL: http://svn.apache.org/viewvc?rev=789392&view=rev > Log: > Remove all usage of GPL or LGPL downloads. +1, thanks. > Use H2 for test database (EPL1.0) as it can be downlo

Re: svn commit: r789392 - in /tomcat/trunk/modules/jdbc-pool: ./ test/org/apache/tomcat/jdbc/test/

2009-06-30 Thread sebb
On 29/06/2009, sebb wrote: > On 29/06/2009, fha...@apache.org wrote: > > Author: fhanik > > Date: Mon Jun 29 17:38:21 2009 > > New Revision: 789392 > > > > URL: http://svn.apache.org/viewvc?rev=789392&view=rev > > Log: > > Remove all

Re: svn commit: r789714 - in /tomcat: container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/FastAsyncSocketSender.java container/tc5.5.x/webapps/docs/changelog.xml current/tc5.5

2009-06-30 Thread sebb
On 30/06/2009, rj...@apache.org wrote: > Author: rjung > Date: Tue Jun 30 13:26:10 2009 > New Revision: 789714 > > URL: http://svn.apache.org/viewvc?rev=789714&view=rev > Log: > Separate statistics counter lock in FastAsyncSocketSender > from inherited DataSender lock to reduce blocking duri

Re: svn commit: r789883 - in /tomcat/trunk/modules/jdbc-pool: build.properties.default build.xml

2009-06-30 Thread sebb
On 30/06/2009, fha...@apache.org wrote: > Author: fhanik > Date: Tue Jun 30 19:15:28 2009 > New Revision: 789883 > > URL: http://svn.apache.org/viewvc?rev=789883&view=rev > Log: > Apply patch by sebb from > https://issues.apache.org/bugzilla/show_bug.cgi?id=474

Re: svn commit: r790155 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/session/ catalina/src/share/org/apache/catalina/valves/ webapps/docs/ webapps/docs/config/

2009-07-01 Thread sebb
On 01/07/2009, ma...@apache.org wrote: > Author: markt > Date: Wed Jul 1 13:19:15 2009 > New Revision: 790155 > > URL: http://svn.apache.org/viewvc?rev=790155&view=rev > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=43343 > Port of r656751, r778523, r778524, r784453 and r784

Re: svn commit: r790693 - /tomcat/trunk/modules/jdbc-pool/build.xml

2009-07-02 Thread sebb
On 02/07/2009, fha...@apache.org wrote: > Author: fhanik > Date: Thu Jul 2 17:35:26 2009 > New Revision: 790693 > > URL: http://svn.apache.org/viewvc?rev=790693&view=rev > Log: > break out javadoc into its own target > > Modified: > tomcat/trunk/modules/jdbc-pool/build.xml > > Modified

Re: svn commit: r790684 - /tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java

2009-07-02 Thread sebb
On 02/07/2009, fha...@apache.org wrote: > Author: fhanik > Date: Thu Jul 2 17:08:50 2009 > New Revision: 790684 > > URL: http://svn.apache.org/viewvc?rev=790684&view=rev > Log: > Add some doco, make shared variables volatile > > Modified: > > tomcat/trunk/modules/jdbc-pool/java/org/apa

Re: JDBC-POOL release candidate

2009-07-21 Thread sebb
On 14/07/2009, Filip Hanik - Dev Lists wrote: > think it should be all in order now > > http://people.apache.org/~fhanik/jdbc-pool/v1.0.6/ Eclipse and Findbugs show the following warnings for the non-test code: Description ResourcePathTypeLocation Class is a raw type. Refere

Re: [PROPOSAL] Remove SVN keywords from JavaDoc

2009-07-22 Thread sebb
On 07/07/2009, Mark Thomas wrote: > Konstantin Kolinko wrote: > > As was written early in this my thread: > > > http://www.nabble.com/Coding-Guidelines%2C-encodings%2C-keywords-td23662661.html > > (http://markmail.org/thread/d6dsgrsfvnuzclt7) > > > > there are problems with Subversion $Date$

Re: svn commit: r794798 - in /tomcat/trunk/java/org/apache/catalina/filters: Constants.java FilterBase.java LocalStrings.properties LocalStrings_es.properties LocalStrings_fr.properties RemoteAddrFi

2009-07-22 Thread sebb
On 16/07/2009, ma...@apache.org wrote: > Author: markt > Date: Thu Jul 16 19:34:49 2009 > New Revision: 794798 > > URL: http://svn.apache.org/viewvc?rev=794798&view=rev > Log: > More GSOC work from Xie Xiadong > Initial implementation of RemoteHost and RemoteAddr filters. > > Added: > t

Re: JDBC-POOL release candidate

2009-07-22 Thread sebb
On 14/07/2009, Filip Hanik - Dev Lists wrote: > think it should be all in order now > > http://people.apache.org/~fhanik/jdbc-pool/v1.0.6/ There are some differences between the source archives and the SVN tag: In SVN, but not in source archive: .classpath .project sign

Re: svn commit: r796739 - /tomcat/trunk/java/org/apache/catalina/connector/AsyncContextImpl.java

2009-07-22 Thread sebb
On 22/07/2009, ma...@apache.org wrote: > Author: markt > Date: Wed Jul 22 14:29:09 2009 > New Revision: 796739 > > URL: http://svn.apache.org/viewvc?rev=796739&view=rev > Log: > Restore the @Overrides. Eclipse on my Mac wasn't configured right. Sorry for > the noise. The build.properties.de

Re: svn commit: r796739 - /tomcat/trunk/java/org/apache/catalina/connector/AsyncContextImpl.java

2009-07-23 Thread sebb
On 23/07/2009, Mark Thomas wrote: > Filip Hanik - Dev Lists wrote: > > Correct, servlet 3.0 requires minimum 1.6 > > so we don't have to build down to 1.5 anymore > > > > Filip > > > I think sebb needs to do an svn up. build.properties.default has sp

Re: svn commit: r797151 - /tomcat/trunk/build.xml

2009-07-23 Thread sebb
On 23/07/2009, ma...@apache.org wrote: > Author: markt > Date: Thu Jul 23 17:15:55 2009 > New Revision: 797151 > > URL: http://svn.apache.org/viewvc?rev=797151&view=rev > Log: > Correct the file name > > Modified: > tomcat/trunk/build.xml > > Modified: tomcat/trunk/build.xml > URL: >

Re: svn commit: r797151 - /tomcat/trunk/build.xml

2009-07-24 Thread sebb
On 24/07/2009, Rainer Jung wrote: > On 23.07.2009 20:43, sebb wrote: > > On 23/07/2009, ma...@apache.org wrote: > >> Author: markt > >> Date: Thu Jul 23 17:15:55 2009 > >> New Revision: 797151 > >> > >> URL: http://svn.apache.org/vie

Re: svn commit: r797529 - in /tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test: AbandonPercentageTest.java BorrowWaitTest.java DefaultTestCase.java TestConcurrency.java

2009-07-24 Thread sebb
On 24/07/2009, fha...@apache.org wrote: > Author: fhanik > Date: Fri Jul 24 15:25:17 2009 > New Revision: 797529 > > URL: http://svn.apache.org/viewvc?rev=797529&view=rev > Log: > update test cases > > Modified: > > tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/Abandon

Re: svn commit: r797528 - in /tomcat/trunk/modules/jdbc-pool: doc/ java/org/apache/tomcat/jdbc/pool/

2009-07-24 Thread sebb
On 24/07/2009, fha...@apache.org wrote: > Author: fhanik > Date: Fri Jul 24 15:24:52 2009 > New Revision: 797528 > > URL: http://svn.apache.org/viewvc?rev=797528&view=rev > Log: > Add in Linux special case for performance optimization around locking. > Set default queue to be the fair one >

Re: 5.5.28 release candidate

2009-07-24 Thread sebb
On 24/07/2009, Filip Hanik - Dev Lists wrote: > http://people.apache.org/~fhanik/tomcat/tomcat-5.5/v5.5.28/ There is no .zip version of apache-tomcat-5.5.28-fulldocs.tar.gz The source archives contain the file container/webapps/admin/images/Thumbs.db which does not belong in the archive. Also

Re: 5.5.28 release candidate

2009-07-25 Thread sebb
On 25/07/2009, Rainer Jung wrote: > On 25.07.2009 01:44, sebb wrote: > > On 24/07/2009, Filip Hanik - Dev Lists wrote: > > > Likewise, the file tomcat-users.xml looks wrong - it says that there > > is no user with the manager role, yet it contains the following entr

  1   2   3   4   5   >