On 22/06/2009, Filip Hanik - Dev Lists <devli...@hanik.com> wrote: > in the spirit of trying to get my poop right, > > http://people.apache.org/~fhanik/jdbc-pool/v1.0.5/
Looks a lot better. > the binary releases contain everything in individual jar files (including > source references for IDEs) However, there are no N & L files in the jars. As these are likely to be independently deployed, the L&N really ought to be present in the jars. > the source release is "as is" from our repo, with the ability to build by > using > ant download build That's much better, and the Ant build file generally works well. However, it's not easy finding out how to build and test the source release, as the information is buried in an XML file. I think there should be a README or BUILDING text file in the top-level directory which includes simple instructions to build and test. This should include details of Java version etc, and any other software that is required, e.g. database. Most of the required info is in the XML file; it could be moved into the text file. Some of the tests fail; I assume that is because I am not running MySQL, but this requirement does not appear to be described anywhere, and there are no details of what (if anything) needs to be set up in the MySQL database (logins, tables, etc.). The Ant "dist" target adds the build.properties file (if present) to the source archive; I don't think it should do this as it may contain host-specific information. > Filip > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
