Re: SVN

2005-10-19 Thread Tim Funk
Here is a quicky way to get the latest 5.5.x branch: http://marc.theaimsgroup.com/?l=tomcat-dev&m=11286855136&w=2 -Tim Allistair Crossley wrote: Hi, Can I just ask if the Tomcat subversion migration is now complete? If i were to want to obtain the latest 5.5.x branch, would I just do so

svn commit failed

2005-11-07 Thread Tim Funk
I was trying to update the faq and on commit I get: svn: Commit failed (details follow): svn: MKACTIVITY of '/repos/asf/!svn/act/cbfb08b7-fd04-0410-812a-daddc51de6cc': 403 Forbidden (http://svn.apache.org) I (think I) have the correct ID and password. Am I missing karma? -Tim --

Re: DO NOT REPLY [Bug 37150] - denial of service on many and long requests on v5.5.x

2005-11-08 Thread Tim Funk
Turning off directory listings by default is a good security practice. I only wait for the all the tomcat user questions of how to turn it on instead of off ;) -Tim Mark Thomas wrote: --- Additional Comments From [EMAIL PROTECTED] 2005-11-08 23:45 --- (In reply to comment #5) The ab

Re: directory listings

2005-11-30 Thread Tim Funk
It looks like this issue only occurs when the XSLT transformation is done on the directory listing. Which is not an out of box configuration so there is no worry for DOS (in case anyone is wondering). Otherwise - looks interesting. cacheTTL and cacheMax should be configurable at servlet init

Re: Proxied client IP logging

2005-12-14 Thread Tim Funk
I'm not really interested in this patch for a few reasons: 1) The functionality is available via a custom pattern 2) X-Forwarded-For (IIRC) can be multi-valued (comma seperated via multiple proxies) 3) X-Forwarded - This can break existing implementations for clients which are sending X-Forwarde

Re: Tomcat 6 plans (JSP 2.1)

2005-12-20 Thread Tim Funk
+0 (+1 - if I can realign my day job duties to free up time to help more :( ) -Tim Remy Maucherat wrote: Hi, Besides adding support for Servlet 2.5 which does not seem too overwhelming, most of the specification work is on support of JSP 2.1. I am happy to report that Jacob Hookom is willin

Re: svn commit: r372314 - /tomcat/container/tc5.5.x/catalina/src/conf/web.xml

2006-01-26 Thread Tim Funk
It seems an extra 'a' snuck into this commit. -Tim [EMAIL PROTECTED] wrote: Author: pero Date: Wed Jan 25 13:05:47 2006 Modified: tomcat/container/tc5.5.x/catalina/src/conf/web.xml URL: http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/catalina/src/conf/web.xml?rev=372314&r1=372313&r2=372

Re: svn commit: r375582 - in /tomcat/connectors/trunk: http11/src/java/org/apache/coyote/http11/InternalAprOutputBuffer.java jk/java/org/apache/coyote/ajp/AjpAprProcessor.java

2006-02-07 Thread Tim Funk
Is it possible for Socket.sendbb to return 0? If so, on what conditions? (Trying to prevent an infinite loop) [This happened to me with a jk bug in the past (tomcat 4.0 and an older version of jk) during a read where tomcat was assuming one thing and apache was assuming something else. (Can't

Re: [PATCH] catalina.sh 'CATALINA_NATIVE'

2006-02-09 Thread Tim Funk
I see the point of the native dir. Once my sysadmin sees this (whose not much of a java guy) - he'd be confused in seeing a bin dir with jar, bat, sh, and so files in it. Maybe itstime to reorg the the bin package dir. Possibly something along the lines of: bin/ <-- All the sh and bat files li

Re: svn commit: r378241 - /tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java

2006-02-16 Thread Tim Funk
On an unrelated note ... what is threadSync for? It looks like a leftover when the class was created from a copy of another Endpoint. -Tim [EMAIL PROTECTED] wrote: Author: remm Date: Thu Feb 16 05:22:51 2006 New Revision: 378241 URL: http://svn.apache.org/viewcvs?rev=378241&view=rev Log: - Fi

Re: Challenges for Java hosting

2006-04-07 Thread Tim Funk
I was thinking that too. A big problem with JVM's is memory leaks. The easy solution is to restart tomcat. But that causes a period of downtime due to waiting for a restart. Why not make mod_ajp "smarter" or create a tomcat launcher where some parent process (apache, or the launcher) listens f

Re: svn commit: r399545 - /tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/Generator.java

2006-05-04 Thread Tim Funk
Sun requires it. -Tim Filip Hanik - Dev Lists wrote: did we say that TC6 will only support jdk1.5 and higher? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r536456 - /tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml

2007-05-10 Thread Tim Funk
Alternatives - 1: wrap in single quotes '%h %l %u %t "%r" %s %b' 2: Use " (didn't try this) "%h %l %u %t "%r" %s %b" -Tim Jean-Frederic wrote: On Wed, 2007-05-09 at 19:58 +0900, Takayuki Kaneko wrote: Hi, IMO, you should arrenge the document like this. -default) corresponds to %h %l %u

Re: [VOTE] Release build 6.0.13

2007-05-11 Thread Tim Funk
The only 2 things I noticed (which aren't a big deal) The index pages had a bad links to the docs. (Now fixed) The status screen has a rendering bug when a webapp is stopped. I didn't have a chance to dig into it - but its not a big deal either. Otherwise - it looked good. -Tim Remy Maucher

Re: Versioning in sources

2007-05-24 Thread Tim Funk
Why not change dist.xml to rewrite ServerInfo.properties (and other appropriate files) when creating the distribution src pacakges? Then the extra commits are avoided. -Tim Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: aah, that makes sense. Remember that the release manager is carry

Re: Gotta submit a Board report this month...

2007-06-01 Thread Tim Funk
What about the new security site? -Tim Yoav Shapira wrote: ... by June 18th at the latest, because the Board meeting is on June 20th. But since I'll be leaving the country on vacation the preceding weekend, our deadline is a bit earlier, let's say June 15th. This is just an early heads-up. A

Re: Draft Board report for June 2007

2007-06-08 Thread Tim Funk
I can take a year of service unless someone else is itching to do it instead. -Tim Yoav Shapira wrote: Also, this reminds me: is anyone interested in taking over the Apache Tomcat PMC Chair role for next year? - To unsubsc

Re: [Configuration] Specifying Location of server.xml on startup

2007-07-03 Thread Tim Funk
(Just a guess ... but) There isn't interest. If you wish server.xml in a different location - switching to the embedded version of tomcat would be a better choice. See the mail archives/Google on embedding tomcat. -Tim Ole Ersoy wrote: Hi, Just wondering whether there are any plans around be

Re: Tomcat supporting PHP

2007-07-19 Thread Tim Funk
IIRC .. Glassfish took over the role of being RI. -Tim Henri Gomez wrote: Tomcat is the RI for servlet/JSP engine, nothing less nothing more. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAI

Re: [VOTE] Release build 6.0.14

2007-07-31 Thread Tim Funk
As long as http://issues.apache.org/bugzilla/show_bug.cgi?id=43002 is not serious then stable -Tim Remy Maucherat wrote: The candidates binaries are available here: http://people.apache.org/~remm/tomcat-6/v6.0.14/ According to the release process, the 6.0.14 tag is: [ ] Broken [ ] Alpha [ ] B

Re: 6.x feature wishlist

2007-08-07 Thread Tim Funk
Filip Hanik - Dev Lists wrote: I wanted to start a wish list of what we can move forward with, here is a short list of items that I had in mind as a starter 1. Session replication - stateless backup location Store the backup location of a session as part of the sessionId, similar to the jvmR

Re: svn commit: r565464 - in /tomcat/tc6.0.x/trunk/java/org/apache: catalina/connector/ catalina/startup/ coyote/ajp/ coyote/http11/ tomcat/util/ tomcat/util/digester/

2007-08-15 Thread Tim Funk
I thought changes were going into trunk and then when applicable, backported to 6.0.x. Since this change is only writing warning messages. It seems appropriate that it can remain in 6.0.x. -Tim Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: this should have been done in trunk, way too

Re: How to restrict access to particular files in Tomcat 4.1?

2007-08-17 Thread Tim Funk
Please use the user list for this topic. (With more details describing your situation) In the meantime look at - Servlet Filters - Security Declarations in web.xml () -Tim BNArun wrote: Could any one tell me the way of restricting access to particular files in Tomcat 4.1? -

Re: [VOTE] Move trunk to sandbox

2007-09-04 Thread Tim Funk
Remy Maucherat wrote: [X] +1 [ ] 0 [ ] -1 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] Make released versions RTC

2007-09-04 Thread Tim Funk
What is a change? Any commit? Is a change only for new features and bug fixes are out of scope? -Tim jean-frederic clere wrote: Hi, I would also propose that we take an handling of release branches similar to httpd. The votes will get in a file named STATUS file and once accepted in a file n

Re: [VOTE] Make released versions RTC

2007-09-04 Thread Tim Funk
In that case > [ ] +1 > [ ] 0 > [X] -1 > For ensuring new features start in "trunk" and work their way back, I'd +1. But since bugs (in BZ not marked as enhancement) would also need RTC - that is my reason for -1. -Tim jean-frederic clere wrote: Tim Funk wr

Re: svn commit: r575332 - in /tomcat/tc6.0.x/trunk: java/org/apache/naming/resources/FileDirContext.java webapps/docs/changelog.xml

2007-09-13 Thread Tim Funk
D'oh. I was tempted to post a patch first and discuss, but since it was only a setZZZ addition and the functionality is exactly the same when the parameter is NOT set - I thought this could go CTR. In light of the recent CTR/RTC discussions - we are still CTR until the vote passes. Likewise -

Re: svn commit: r575332 - in /tomcat/tc6.0.x/trunk: java/org/apache/naming/resources/FileDirContext.java webapps/docs/changelog.xml

2007-09-14 Thread Tim Funk
The basic concept behind the logic is: - Look for prefix - Replace with new base path The new path replacement is done before the symlink and case check is done so those checks are still preserved. (Just with the new path alias). If there is a security manager in play - it should already be bl

Re: svn commit: r575332 - in /tomcat/tc6.0.x/trunk: java/org/apache/naming/resources/FileDirContext.java webapps/docs/changelog.xml

2007-09-14 Thread Tim Funk
Hopefully I can get all the concerns in one email ... [Pardon me if this is not the most coherent - I been on vacation this week and I was staining and putting sealer or some wood furniture and got too many fumes to the head ... but don't let that reflect badly on the patch ... that was done we

Re: svn commit: r575332 - in /tomcat/tc6.0.x/trunk: java/org/apache/naming/resources/FileDirContext.java webapps/docs/changelog.xml

2007-09-15 Thread Tim Funk
Remy Maucherat wrote: I tested with the security manager, and it doesn't behave correctly. If the context.xml inside a webapp is: The docBase hack attempt doesn't do anything (it's overwritten, I think), but the security manager does not prevent browsing the HD as the policy grants all p

Re: svn commit: r575332 - in /tomcat/tc6.0.x/trunk: java/org/apache/naming/resources/FileDirContext.java webapps/docs/changelog.

2007-09-15 Thread Tim Funk
As everyone will see ... I reverted. Its not the end of the world if this gets in since I can easily maintain a private version with alias support for myself. I thought it was a helpful bloatage for others. It might be worthwhile keeping the discussion active for the moment if anyone else has o

Re: Review model take 2

2007-09-18 Thread Tim Funk
+1 -Tim - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] Back to ASF Basics (Was: Re: Review model take 2)

2007-09-22 Thread Tim Funk
Can we have a new VOTE with the six bullets (if it is that many - I'm losing track with all the responses). I'm not quite sure what I'm voting for. -Tim I'd like to call a vote on acceptance of the above methodology, as crafted and fine-tuned by Costin and myself. It is worthwhile to note tha

Re: [VOTE] Back to ASF Basics (Was: Re: Review model take 2)

2007-09-22 Thread Tim Funk
Jim Jagielski wrote: [X] +1. Yes, the above works and addresses my concerns as well as the problems which started this whole thing. [ ] 0. Whatever. [ ] -1. The above does not work for the following reasons: --

Re: svn commit: r582597 - /tomcat/tc6.0.x/trunk/STATUS

2007-10-08 Thread Tim Funk
I would think a link is a must. So step 2 can be any of 2a) Upload a patch to /home/`whoami`/public_html/patches 2b) Add a patch to BZ 2c) Link to SVN patch 2d) If the patch is an attachment in an email to tomcat-dev - there is some public record of the email - link to that -Tim Filip Hanik -

Re: svn commit: r585313 - /tomcat/tc6.0.x/trunk/STATUS

2007-10-17 Thread Tim Funk
There was a request in bugzilla to pass in a new env variable called JAVA_EXE (or similar). Could that be an acceptable alternative? Then it would make the bug submitter happy since he can symlink my_program_that_i_can_see_in_ps to java. -Tim Rémy Maucherat wrote: On Wed, 2007-10-17 at 05:

Re: [LOBBYING] Add nio connector to configuration validation

2007-10-19 Thread Tim Funk
For java/org/apache/coyote/http11/Http11NioProtocol.java Is it me or does this look odd after the patch (as well as before) ... public void setProperty(String name, String value) { setAttribute(name, value); if (/*omitted for word wrap since it doesn't matter */) { return ep.setPr

Re: [PROPOSAL] Move Tomcat 5.0.x to the archive

2007-10-19 Thread Tim Funk
+1 -Tim - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: Just an opinion

2007-10-30 Thread Tim Funk
After the 6.0.15 tag - I was hoping on looking at all the bugs with patches marked and (if valid) add them to the status (after first testing them). (Not sure how fast I can do that - I'll be picking the "easy" bugs first) I'm sure there is great interest in speeding up the jsp compiling when

Re: A high school student is taking on the task of moving our FAQ to the wiki

2007-11-28 Thread Tim Funk
It'd be better to police ourselves to not update it during the transition. Then when the FAQ is moved - we can have the FAQ archived (or chucked ... preferably archived) Since the FAQ is rarely changed - its highly unlikely any changes were going to be made in the near future. -Tim Yoav Sha

Re: GHOP #23

2007-11-29 Thread Tim Funk
(I swamped with other projects this week) Hopefully here is enough detail: For the site 1) In site/trunk/xdocs/stylesheets/tomcat-site.xsl - this is the file to change. Below add rel="stylesheet" media='printer'/> 2) In tomcat-printer.css - add a style .noPrint {display:none} 3) Back in si

Re: GHOP#23 Review

2007-12-04 Thread Tim Funk
This can be marked complete. I tried to update the html files but on commit I get a collision with whoarewe.html so I gave up for the moment to at least get the good stuff applied. I applied the opther printer stuff to trunk with some tweaks. I also discovered we don't use webapps/docs/build.x

FAQ chucking alternatives

2007-12-04 Thread Tim Funk
To chuck the FAQ from the site we can do this in one of a few ways 1) Delete the files and watch lots of 404's appear (yuck) 2) Change each faq with a META refresh (ok short term, crappy longer term) 3) Other?? Personally I'd like to archive them and 301 redirect the appropriate pages to the wik

Re: FAQ chucking alternatives

2007-12-05 Thread Tim Funk
Cool. Then if no one objects, I'll add this /faq/.htaccess (Should be coming as txt attachement) I noticed http://tomcat.apache.org/faq/development.html didn't get ported over. Thats in the attachment - but not done yet. -Tim RedirectPermanent /faq/bugs.html http://wiki.apache.org/tomcat/F

FAQ Chucking last step

2007-12-07 Thread Tim Funk
The last step is to archive or delete the existing faq pages .. site/trunk/xdocs-faq site/trunk/docs/faq (except for .htaccess) I'm unsure which svn commands to run svn delete - or - svn move TO_WHERE? -Tim - To unsubscribe, e

Re: FAQ Chucking last step

2007-12-07 Thread Tim Funk
I'm all done with the FAQ chucking now. I think I got everything. Just yell if I missed anything big. -Tim Mark Thomas wrote: Yoav Shapira wrote: On Dec 7, 2007 9:36 AM, Tim Funk <[EMAIL PROTECTED]> wrote: The last step is to archive or delete the existing faq pages .. site/trun

Re: svn commit: r603074 - /tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java

2007-12-11 Thread Tim Funk
But is name a string constant or is it built by using concatenation (via reading XML via digester or other)? If its the latter, then name is not a string constant. -Tim Filip Hanik - Dev Lists wrote: if String objects are kept in a constants pool, then one would synchroniz

Re: svn commit: r467989 - in /tomcat/tc6.0.x/trunk/java: javax/servlet/ServletException.java org/apache/catalina/core/StandardWrapper.java org/apache/catalina/valves/ErrorReportValve.java

2006-10-26 Thread Tim Funk
Adding this to both loops may be helpful too: if (rootCause == rootCause.getCause()) { break; } -Tim [EMAIL PROTECTED] wrote: Author: remm Date: Thu Oct 26 06:08:58 2006 New Revision: 467989 URL: http://svn.apache.org/viewvc?view=rev&rev=467989 Log: - Refactor exception reporting using Th

Re: svn commit: r467989 - in /tomcat/tc6.0.x/trunk/java: javax/servlet/ServletException.java org/apache/catalina/core/StandardWrapper.java org/apache/catalina/valves/ErrorReportValve.java

2006-10-26 Thread Tim Funk
turns itself as the root cause. -Tim Remy Maucherat wrote: Tim Funk wrote: Adding this to both loops may be helpful too: if (rootCause == rootCause.getCause()) { break; } Throwable.getCause does return null in that case, so the loop should get out: public Throwable getCause() {

Re: [VOTE] Tomcat 6.0.2

2006-11-21 Thread Tim Funk
Its time for beta. More folks will kick the tires. -Tim Remy Maucherat wrote: Hi, 6.0.2 is: [ ] Alpha [X] Beta - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: [TC6] Minimum coding style

2006-11-28 Thread Tim Funk
+1 trailing spaces always annoy me and text editors can easily be configured to strip them out. An alternative is to change the email diffs to diff ignoring whitespace changes. Then lines can have all the trailing spaces they want and we won't see those diffs. -Tim Mladen Turk wrote: Hi,

Re: svn commit: r491995 - in /tomcat/tc6.0.x/trunk/java/org/apache: catalina/loader/VirtualWebappLoader.java naming/resources/VirtualDirContext.java

2007-01-03 Thread Tim Funk
True - but helping developers develop code faster is typically a good thing. I'd be OK if we created a bloat [I mean optional] package for things like this. -Tim Remy Maucherat wrote: [EMAIL PROTECTED] wrote: Author: funkman Date: Tue Jan 2 16:51:31 2007 New Revision: 491995 URL: http://s

Re: Escaping EL doesn't work in Tomcat 6?

2007-01-03 Thread Tim Funk
Is this issue http://issues.apache.org/bugzilla/show_bug.cgi?id=41257 and http://issues.apache.org/bugzilla/show_bug.cgi?id=41258 I think these are the trouble: Lines 2776-2777 in org.apache.jasper.compiler.Generator TagAttributeInfo tai = attr.getTagAttributeInfo(); String type = tai.getTypeNa

Re: svn commit: r496022 - in /tomcat: container/tc5.5.x/webapps/docs/changelog.xml jasper/tc5.5.x/src/share/org/apache/jasper/servlet/JspServlet.java

2007-01-14 Thread Tim Funk
Is this screaming XSS attack? Since javadocs in getRequestURI() say ... "The web container does not decode this String" -Tim [EMAIL PROTECTED] wrote: Author: markt Date: Sat Jan 13 18:45:48 2007 New Revision: 496022 URL: http://svn.apache.org/viewvc?view=rev&rev=496022 Modified: tomcat/j

Re: svn commit: r496022 - in /tomcat: container/tc5.5.x/webapps/docs/changelog.xml jasper/tc5.5.x/src/share/org/apache/jasper/servlet/JspServlet.java

2007-01-14 Thread Tim Funk
Sweet - I thought that was the case. [But wanted to make sure.] -Tim Mark Thomas wrote: Tim Funk wrote: Is this screaming XSS attack? Since javadocs in getRequestURI() say ... "The web container does not decode this String" It would be if it wasn't

Re: Build with Maven?

2007-01-18 Thread Tim Funk
There has been no desire to use maven to build tomcat. Actually - there was interest but the answer turned to a quick no. See the mail list archives for details. (Many months ago) -Tim Ole Ersoy wrote: Hi, Does anyone know if there is a Maven build available for Tomcat and whether there is

Re: svn commit: r498053 - in /tomcat/container/tc5.5.x/catalina: build.xml src/share/org/apache/catalina/core/StandardWrapper.java

2007-01-22 Thread Tim Funk
Does this introduces a new dependency on the jsp-api - which could be a regression for people who embed tomcat without using jsp's. Also the checking is not that aggressive any more in the case of nested exceptions. This may leave the root cause still unexposed. This patch seems better: http:

Re: svn commit: r498053 - in /tomcat/container/tc5.5.x/catalina: build.xml src/share/org/apache/catalina/core/StandardWrapper.java

2007-01-22 Thread Tim Funk
eException; } -Tim Mark Thomas wrote: Tim Funk wrote: Does this introduces a new dependency on the jsp-api - which could be a regression for people who embed tomcat without using jsp's. Yes, it does add an additional dependency. I didn't consider the embedded use case. Also the ch

Re: [VOTE] 6.0.x release process update

2007-02-05 Thread Tim Funk
+1 -Tim Remy Maucherat wrote: Hi, I propose the following release process for Tomcat 6.0.x: 1. create tarball and unofficial binaries, put them on people.apache.org/~remm/tomcat-6 2. announce candidate binaries are available for testing 3. wait 2-3 days for testing 4. call for alpha/beta/st

Re: Weekly builds

2007-02-12 Thread Tim Funk
Does this mean bringing back the automated builds? +1 to automated weekly builds -0 to manual weekly builds -Tim Remy Maucherat wrote: Hi, Since Tomcat 6 is still not stable, I propose producing a weekly Monday build, starting with one today. -

Re: [VOTE] Release build 6.0.10

2007-02-22 Thread Tim Funk
I'll give it a whirl. I'm in the process of getting some new servers which can actually run java5. (Thus modernizing me to 2003) -Tim Remy Maucherat wrote: Remy Maucherat wrote: Candidate binaries are available here: http://people.apache.org/~remm/tomcat-6/v6.0.10/ According to the (slightl

Re: [VOTE] Release build 6.0.10

2007-02-22 Thread Tim Funk
Minor (non show stopper) issues: - /manager/html-manager-howto.html is missing - /manager/manager-howto.html is missing - The default welcome page has a bad link to /tomcat-docs instead of docs I'm OK with stable since it looks suitable for production use in many scenarios. -Tim Remy Mauchera

Re: Accepted meaning of 'should' in spec documents

2007-02-28 Thread Tim Funk
Typically its: http://www.faqs.org/rfcs/rfc2119.html -Tim C. Halstead wrote: Hi, Just a quick clarification question, and sorry if it's a basic one. When interpreting various spec documents is the qualifier 'should' always taken to indicate that something is optional? Two cases in point:

Re: [VOTE] New committer: Fabian Carrion

2007-03-01 Thread Tim Funk
+1 -Tim Remy Maucherat wrote: Hi, I'd like to nominate Fabian Carrion as a committer on the Apache Tomcat project. Fabian contributed many useful patches, including helping add support for Servlet 2.5 in Apache Tomcat 6.0. --

Re: svn commit: r513601 - in /tomcat/tc6.0.x/trunk: java/org/apache/catalina/core/StandardContext.java webapps/docs/changelog.xml

2007-03-02 Thread Tim Funk
Re-reading the 2.4 spec - most references to load-on-startup state any non-negative number gets loaded in order lowest to highest. (Starting at 0) BUT in the 2.2 DTD - there is this gem: "The load-on-startup element indicates that this servlet should be loaded on the startup of the web applicati

Re: svn commit: r529442 - /tomcat/tc6.0.x/trunk/webapps/manager/sessionDetail.jsp

2007-04-17 Thread Tim Funk
Looks good - the only thing I'd recommend to add is exception handling when displaying session values. For example - if someone places the following into their session: (A rather simplistic example) new Object() { public String toString() { String s = null; return s.toString();

Re: Binary build procedures

2006-05-23 Thread Tim Funk
The release manager (RM) - creates a binary from his copy of source. - Generates a checksum key to allow validation of no tampering of the RM's build. The RM could insert malicious code into the build. If that were to happen - the RM would probably be kicked out of the project in a hurry. It

Miletones missing from tomcat 6

2006-07-11 Thread Tim Funk
Has anyone been able to update tomcat 6 bugs? It appears the milestone field is blank and because of that - tomcat 6 bugs can't be updated. Or I can't close the one I just opened because I'm just acting like an idiot today. -Tim

Re: Out of Threads error

2006-08-04 Thread Tim Funk
For tomcat 5: find . -type f |xargs grep "Increase maxThreads" jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads/res/LocalStrings.properties -Tim James Courtney wrote: I'm getting this message from my Tomcat 5.0.28 on Linux. 2006-08-02 21:01:19: ERROR All threads (400) are cu

Re: JIRA ?

2006-08-18 Thread Tim Funk
I'm indifferent. It looks like all projects are moving in the direction of using JIRA and most likely Bugzilla will stop being supported by infrastructure [like CVS was]. So its probably a good time to move. Is there talk of infrastructure stopping support of bugzilla anytime? -Tim Remy Mau

Re: Relation of jasper and servlet API to Tomcat

2006-08-19 Thread Tim Funk
In different versions of Tomcat, Jasper could change "a lot" since its not a "public api". The servlet api could also change in different Tomcat revisions too. But these changes are usually VERY minor and due to corrections/errata found in the spec. Typically - when Tomcat changes - there w

Re: Bug in JNDIRealm with bindAsUser?

2006-08-30 Thread Tim Funk
IIRC, JNDIRealm can perform its queries in different styles depending on configuration (thus allowing for a lot of common, but somewhat convoluted code) You can connect to JNDIRealm with an "admin like" role where you are always bound as the admin and you are looking up attributes about the s

Re: svn commit: r447793 - /tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/Compiler.java

2006-09-19 Thread Tim Funk
Is there a reason deferred is spelled 2 different ways? (One with an extra f) setDeferredSyntaxAllowedAsLiteral vs isDefferedSyntaxAllowedAsLitteral -Tim [EMAIL PROTECTED] wrote: Author: remm Date: Tue Sep 19 02:47:32 2006 New Revision: 447793 URL: http://svn.apache.org/viewvc?view=rev&rev=

Re: [VOTE] Split soTimeout to soTimeout and keepAliveTimeout

2006-10-03 Thread Tim Funk
Mladen Turk wrote: [ ] I'm for that proposal [ ] I'm against that proposal [X ] I don't care -Tim - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: Builds from the 6.0 branch

2006-10-10 Thread Tim Funk
+1 -Tim Remy Maucherat wrote: Hi, I think the branch is in a state where builds can start being released. Some people asked for them earlier, so I don't think anyone will complain if this actually happens. Given what changes were made, I expect stability to be reasonable. Would it be ok t

Re: [VOTE] Tomcat 6 release plan

2006-10-18 Thread Tim Funk
Remy Maucherat wrote: Hi, The release plan is located here: http://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk/RELEASE-PLAN-6.0.txt [X] +1 [ ] +0 [ ] -1 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional command

Re: question on IP for VirtualContext

2011-11-17 Thread Tim Funk
IIRC: this came into existence via https://issues.apache.org/bugzilla/show_bug.cgi?id=41260 - it was donated by the original contributor and the patch provided had the ASL license. Borrowing features is OK, code is not unless the code is granted. It may be as simple as contacting the original aut

Re: Proposal: use tomcat-version-number in server.xml element?

2011-12-02 Thread Tim Funk
Sounds like a job for a LifeCycleListener. (and therefore easy to backport) -Tim

Re: Using comments.apache.org for our live docs

2012-11-08 Thread Tim Funk
Nice. +1 -Tim On Wed, Nov 7, 2012 at 5:31 PM, Rainer Jung wrote: > I prepared a simple demo at: > > http://people.apache.org/~**rjung/tomcat-docs-comments/**tomcat-8.0-docs/ > > It would be nice if you would have a look a

Re: [PROPOSAL] Remove case insensitivity option for Tomcat 7

2009-06-12 Thread Tim Funk
+1 -Tim Mark Thomas wrote: After a long discussion on the users the list [1], the question was asked: "Is this feature required?" - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail

Re: svn commit: r784083 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/core/ java/org/apache/naming/resources/ webapps/docs/config/

2009-06-12 Thread Tim Funk
Typo: Modified: tomcat/trunk/webapps/docs/config/context.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/context.xml?rev=784083&r1=784082&r2=784083&view=diff == --- tomcat/trunk/webapps/docs/confi

Re: Bug 37794 - Parameters, chunked requests and maxPostSize

2009-06-15 Thread Tim Funk
Yes chunked requests on POST are OK. I like option a too. -Tim Mark Thomas wrote: For chunked request bodies, the content length is unknown. We can track how many bytes we have read. If we read more the maxPostSize, what do we do? a) Throw an exception that leads to a 500 response? b) Drop what

Re: Bug 37794 - Parameters, chunked requests and maxPostSize

2009-06-16 Thread Tim Funk
"infinite" size for POST is bad as a default. It would make it trivial to DOS the site. -Tim Josh Gooding wrote: Gentlemen, Let me ask this. What is the maxPostSize in Tomcat?I'm ok with "a" but I'm trying to think ahead in how to make an extremely large POST acceptable maybe for 7. I h

Re: svn commit: r785381 - in /tomcat/trunk/java/org/apache/catalina/connector: LocalStrings.properties Request.java

2009-06-17 Thread Tim Funk
In tomcat/trunk/java/org/apache/catalina/connector/Request.java http://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.6 Needs to be case insensitive else if ("chunked".equalsIgnoreCase( -Tim - To unsubscribe, e-mail: de

Re: svn commit: r785952 - in /tomcat/trunk/test/org/apache/catalina/valves: ./ Benchmarks.java

2009-06-18 Thread Tim Funk
I think this needs to be volatile ? In (GetDateBenchmarkTest) > +private long currentMillis = 0; Same for (in TimeDateElementBenchmarkTest) > +private Date currentDate = null; Of course - since the test is single threaded - it doesn't really matter. -Tim ma...@apache.org wrote:

Re: svn commit: r786471 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/core/ java/org/apache/catalina/loader/ java/org/apache/catalina/manager/ java/org/apache/catalina/servlet

2009-06-19 Thread Tim Funk
Where these meant to be included? http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java?rev=786471&r1=786470&r2=786471&view=diff http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/JspRuntimeContext.java?rev=786471&r1=786470&r2=786471&v

Re: Taglibs SVN migration to Tomcat

2009-08-14 Thread Tim Funk
+1 -Tim Henri Yandell wrote: Post discussion between Tomcat PMC and Jakarta PMC (with myself as the go between), the Jakarta Taglibs subproject is going to move over to Tomcat land. Chiefly this means: - To unsubscribe, e-ma

Re: Testing new website sync process

2009-09-03 Thread Tim Funk
Does that mean the entire site would be in svn? If so - would that also mean that all documentation (like javadocs etc) would move into svn? -Tim Mark Thomas wrote: Folks, As part of the response to the recent compromise of ASF servers [1] the infrastructure team are introducing a new way to

Re: Bug workflow

2009-09-17 Thread Tim Funk
Anyone can change a bug to any status. (Much like in wikipedia - anyone can edit any page) Then the community would police people who dont behave. Which doesn't happen often. -Tim Uwe Günther wrote: How does this work, if someone identifies a bug as NO BUG, does somebody set the status to "Re

Re: Bug workflow

2009-09-17 Thread Tim Funk
It differs by the person. So here is a wild guess .. But I would guess bugs are usually fixed 1st by interest. For example: Crap that bug affects my stuff too, I should look at that. Other bugs are fixed by how interesting they. For example: hmmm .. that seems odd - I think I'll look at that.

Re: DBCP 1.3/1.4

2009-12-08 Thread Tim Funk
[I know I'm missing something .. but] Would it be worth dropping dbcp from 7 and just use jdbc-pool? -Tim Mark Thomas wrote: Commons is close to the next DBCP release. I have been looking at this and there will, unfortunately, still be some Java 5 with JDBC 3 / Java 6 with JDBC 4 issues. It

Re: DBCP 1.3/1.4

2009-12-09 Thread Tim Funk
If you can swing moving jdbc-pool as the next gen commons-dbcp - that would be sweet. In which case, jdbc-pool would no longer exist and we'd only be left with dbcp. Which leaves us with the tomcat 6 vs no access to JDBC4 - but some faqs can point the user on how to download the needed extra

Re: svn commit: r889585 - /tomcat/trunk/modules/bayeux/java/org/apache/tomcat/bayeux/request/PublishRequest.java

2009-12-11 Thread Tim Funk
Did you mena PublishRequest.class? +private static final Log log = LogFactory.getLog(RequestBase.class); -Tim ma...@apache.org wrote: Author: markt Date: Fri Dec 11 12:14:05 2009 New Revision: 889585 URL: http://svn.apache.org/viewvc?rev=889585&view=rev Log: Fix https://issues.apache.org

Re: svn commit: r890856 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-12-15 Thread Tim Funk
Typically the proposer will commit with +3 - but its not mandatory. As long as there are +3 - then it really doesn't matter who does the commit since there was a +3 consensus on the change. -Tim On 12/15/2009 11:39 AM, Mladen Turk wrote: On 12/15/2009 05:13 PM, j...@apache.org wrote: Some

Re: BIO performance issues

2011-05-04 Thread Tim Funk
Solution B and disabling keepalive when a threshold is reached looks to be the way to go. If people have issue with that, that's why the other connectors exist. -Tim On Tue, May 3, 2011 at 4:02 PM, Mark Thomas wrote: > > Solution B > -- > Return to the Tomcat 6 implementation where ma

Re: [PROPOSAL] Move to svnpubsub for /dist/tomcat

2011-05-18 Thread Tim Funk
+1 On Wed, May 18, 2011 at 9:38 AM, Mark Thomas wrote: > > We have the option to move to svnpubsub for managing our releases. > Rather than copying artefacts to people.a.o and then waiting for rsync > (every around 2 hours) we would commit the artefacts to svn and a commit > hook would update th

Re: Fixing bug 33453

2011-05-23 Thread Tim Funk
How about calling it getDependantsMap() instead of getDependants() ? Then catch the NoSuchMethodException (I in the case where the compiled jsp doesn't have getDependants() and that would force a recompile (and then the new version would be OK) -Tim On 5/20/2011 12:31 PM, Mark Thomas wrote: Al

Re: Outdated Servlet 3.0 Javadocs available on tomcat.apache.org

2011-06-01 Thread Tim Funk
Is the PDF of the spec which is downloadable up to date with respect to comments? I don't think the pdf version of the spec is CDDL ... but it may have other conditions on it. If the PDF version of the spec is up to date, someone might be able to copy from the PDF and paste into the javadocs and ad

Re: Outdated Servlet 3.0 Javadocs available on tomcat.apache.org

2011-06-01 Thread Tim Funk
Doh - Older specs had the javadocs. I never scrolled to the end to notice it missing from the current spec. -Tim On Wed, Jun 1, 2011 at 11:29 AM, Christopher Schultz < ch...@christopherschultz.net> wrote: > Tim, > > On 6/1/2011 8:35 AM, Tim Funk wrote: > > Is the PDF

Re: svn commit: r1131263 - in /tomcat/trunk: java/org/apache/catalina/session/JDBCStore.java java/org/apache/catalina/session/LocalStrings.properties webapps/docs/changelog.xml webapps/docs/config/man

2011-06-03 Thread Tim Funk
If NamingExceptionOccurs - should this instead rethrow a SqlException instead of letting the logic keep going? Otherwise wouldn't a SqlException be thrown later in the method? -Tim On Fri, Jun 3, 2011 at 6:13 PM, wrote: > Author: markt > Date: Fri Jun 3 22:13:09 2011 > New Revision: 1131263 >

  1   2   3   >