For java/org/apache/coyote/http11/Http11NioProtocol.java
Is it me or does this look odd after the patch (as well as before) ...
public void setProperty(String name, String value) {
setAttribute(name, value);
if (/*omitted for word wrap since it doesn't matter */) {
return ep.setProperty(name, value);
} else {
return ep.setProperty(name, value); /*commit omitted for ww*/
}
}
Should this be simplified too:
public void setProperty(String name, String value) {
setAttribute(name, value);
return ep.setProperty(name, value);
}
-Tim
Filip Hanik - Dev Lists wrote:
Ok, sending a little email to lobby for a useful change. To the contrary
of comments and vetoes to this change, it doesn't change existing
behavior, it simplifies it, and also adds the NIO connector to the
validation of server.xml attributes.
It'd be nice to get one more vote, so that we can get it in before the tag.
From STATUS
* Make server.xml parsing warnings more generic, add support for the NIO
connector
* Connector is no longer an exception case. Any new component can still
use setProperty and return a boolean
* to accept or reject the property
http://people.apache.org/~fhanik/patches/digester-attribute-warnings.patch
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
