Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Nick Williams
On Aug 20, 2013, at 10:12 AM, Christopher Schultz wrote: > Mark, > > On 8/20/13 9:25 AM, Mark Thomas wrote: >> On 20/08/2013 14:13, Nick Williams wrote: >>> I'm working on implementing bugzilla 55317. It's a pretty important >>> change (weaving) to a

Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Nick Williams
On Aug 20, 2013, at 12:41 PM, Christopher Schultz wrote: > Nick, > > On 8/20/13 1:25 PM, Christopher Schultz wrote: >> tcnative can be built on Max OS X like this: >> >> $ cd $CATALINA_HOME/bin >> $ tar xzf tomcat-native.tar.gz >> $ cd tomcat-native-*-src/jni/native >> $ ./configure --with-apr=

Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Nick Williams
On Aug 20, 2013, at 1:10 PM, Mark Thomas wrote: > On 20/08/2013 18:47, Nick Williams wrote: >> My remaining original concern was the best approach for weaving byte >> code in Tomcat's unit tests, which I detailed in an earlier message. > > Use the Weaver to completel

Re: Need guidance for writing unit tests for 55317

2013-08-21 Thread Nick Williams
On Aug 21, 2013, at 2:58 AM, Mark Thomas wrote: > On 21/08/2013 01:24, Nick Williams wrote: > >> My backup idea is slightly less clean but, IMO, still more clean than adding >> ASM as a test-time dependency and trying to figure all of that out. I >> locally compiled f

Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2013-08-21 Thread Nick Williams
On Aug 21, 2013, at 6:14 AM, Mark Thomas wrote: > I'm not exactly sure what the problem is. It looks like the WebSocket > SCI is being registered twice or is running twice but I can't reproduce > the problem. Anyone got any ideas? > > Currently, my plan is to add some logging to the SCI registra

Re: Need guidance for writing unit tests for 55317

2013-08-21 Thread Nick Williams
On Aug 21, 2013, at 12:46 PM, sebb wrote: > On 21 August 2013 14:48, Christopher Schultz > wrote: >> Nick, >> >> On 8/20/13 8:24 PM, Nick Williams wrote: >>> I ran in to a roadblock with this idea. Part of the byte code of a >>> class includes the

Can't build from trunk anymore -- problems with DBCP2

2013-08-21 Thread Nick Williams
I have latest-ish from trunk (< 2 days old) and compiled without issue. When I tried to run it, however, console output indicates a serious issue creating DataSource resources: 21-Aug-2013 17:18:30.800 WARNING [localhost-startStop-1] org.apache.catalina.core.NamingContextListener.addResource Fa

Re: Can't build from trunk anymore -- problems with DBCP2

2013-08-21 Thread Nick Williams
On Aug 21, 2013, at 5:32 PM, Nick Williams wrote: > I have latest-ish from trunk (< 2 days old) and compiled without issue. When > I tried to run it, however, console output indicates a serious issue creating > DataSource resources: > > 21-Aug-2013 17:18:30.800 WARNING [loc

Re: [Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-08-28 Thread Nick Williams
On Aug 21, 2013, at 6:21 PM, bugzi...@apache.org wrote: > https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 > > Nick Williams changed: > > What|Removed |Added >

Re: [Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-08-28 Thread Nick Williams
On Aug 28, 2013, at 9:07 AM, Mark Thomas wrote: > On 28/08/2013 13:36, Nick Williams wrote: >> >> On Aug 21, 2013, at 6:21 PM, bugzi...@apache.org wrote: >> >>> https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 >>> >>> Nick Willi

Re: svn commit: r1521023 - in /tomcat/trunk/java: javax/annotation/Generated.java javax/annotation/Resource.java org/apache/catalina/startup/WebAnnotationSet.java

2013-09-09 Thread Nick Williams
On Sep 9, 2013, at 5:24 AM, Mark Thomas wrote: > On 09/09/2013 11:20, Mark Thomas wrote: >> On 09/09/2013 11:09, ma...@apache.org wrote: >>> Author: markt >>> Date: Mon Sep 9 10:09:36 2013 >>> New Revision: 1521023 >>> >>> URL: http://svn.apache.org/r1521023 >>> Log: >>> Fix wrongly named annot

Re: svn commit: r1521594 [1/16] - in /tomcat/site/trunk: docs/ docs/images/ docs/stylesheets/ xdocs/images/ xdocs/stylesheets/

2013-09-10 Thread Nick Williams
On Sep 10, 2013, at 4:34 PM, Christopher Schultz wrote: > Mark, > > On 9/10/13 3:21 PM, ma...@apache.org wrote: >> Author: markt >> Date: Tue Sep 10 19:21:22 2013 >> New Revision: 1521594 > > It's amazing how a relatively small number of changes can take a page > from 1996 to ... well, at least

Re: svn commit: r1521817 - /tomcat/tc6.0.x/trunk/STATUS.txt

2013-09-11 Thread Nick Williams
On Sep 11, 2013, at 9:22 AM, Konstantin Kolinko wrote: > 2013/9/11 Mark Thomas : >> On 11/09/2013 14:44, Konstantin Kolinko wrote: >>> 2013/9/11 : Author: markt Date: Wed Sep 11 11:59:37 2013 New Revision: 1521817 URL: http://svn.apache.org/r1521817 Log: Comme

Where to put a helper class for test?

2013-09-12 Thread Nick Williams
Mark, I'm working on revisions to my patch for BZ 55317 based on your feedback. In this feedback you said: > 5. I'm not a fan of the org.apache.tomcat.unittest package unless the classes > concerned are going to be used by multiple tests across multiple packages. I put org.apache.tomcat.unitte

Re: Where to put a helper class for test?

2013-09-12 Thread Nick Williams
On Sep 12, 2013, at 1:03 PM, Mark Thomas wrote: > On 12/09/2013 18:31, Nick Williams wrote: >> Mark, >> >> I'm working on revisions to my patch for BZ 55317 based on your >> feedback. In this feedback you said: >> >>> 5. I'm not a fan of t

Re: [Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-09-12 Thread Nick Williams
On Aug 29, 2013, at 4:28 AM, bugzi...@apache.org wrote: > https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 > > --- Comment #16 from Mark Thomas --- > (In reply to Nick Williams from comment #15) >> Created attachment 30749 [details] >> Proposed implementatio

Re: SCI discovery ordering

2013-09-19 Thread Nick Williams
On Sep 19, 2013, at 11:32 AM, Jeremy Boynes wrote: > On Sep 19, 2013, at 8:36 AM, Mark Thomas wrote: > >> On 19/09/2013 16:31, Jeremy Boynes wrote: >>> On Sep 19, 2013, at 6:07 AM, ma...@apache.org wrote: >>> Author: markt Date: Thu Sep 19 13:07:02 2013 New Revision: 1524727 >>

Re: SCI discovery ordering

2013-09-20 Thread Nick Williams
On Sep 20, 2013, at 4:33 PM, Jeremy Boynes wrote: > On Fri, Sep 20, 2013 at 8:50 AM, Mark Thomas wrote: > >> On 20/09/2013 16:02, Jeremy Boynes wrote: >>> The only ordering concern for SCIs in the spec is that they are >>> "discovered" following the classloader delegation model. This will >>> t

Re: [VOTE] Release Apache Tomcat 7.0.43

2013-09-21 Thread Nick Williams
On Sep 21, 2013, at 6:07 AM, Konstantin Kolinko wrote: > 2013/9/21 Mark Thomas : >> On 20/09/2013 08:38, Violeta Georgieva wrote: >>> The proposed Apache Tomcat 7.0.43 release is now available for voting. >>> This release candidate contains JSR-356 Java WebSocket 1.0 implementation. >>> Note that

OT: Adding Filters and odd WebLogic Behavior

2013-09-23 Thread Nick Williams
This is very off topic, and for that I apologize. I'm working on fixing a bug in Log4j 2, and we've discovered something that just doesn't make any sense to me. I /believe/ it's a problem with WebLogic's implementation of the Servlet 3.0 specification, but I could be wrong, and based on my previ

Re: [VOTE] Release Apache Tomcat 7.0.44

2013-09-24 Thread Nick Williams
On Sep 24, 2013, at 11:00 AM, Rossen Stoyanchev wrote: > On Tue, Sep 24, 2013 at 11:40 AM, Mark Thomas wrote: > >> The necessary update to the script that uploads those JARs to the Maven >> repo was missed. I think I have fixed it locally but need to test it >> from somewhere with connectivity.

<    1   2