On Sep 12, 2013, at 1:03 PM, Mark Thomas wrote: > On 12/09/2013 18:31, Nick Williams wrote: >> Mark, >> >> I'm working on revisions to my patch for BZ 55317 based on your >> feedback. In this feedback you said: >> >>> 5. I'm not a fan of the org.apache.tomcat.unittest package unless >>> the classes concerned are going to be used by multiple tests across >>> multiple packages. >> >> I put org.apache.tomcat.unittest.weaving.NeverUsedClass and >> org.apache.tomcat.unittest.weaving.UnweavedClass in this package >> because it seemed like a location that "helper" classes were being >> placed for other tests. However, I see your point about them only >> being used for one class. Should I just put these classes in >> org.apache.catalina.loader, the same package that >> TestWebappClassLoaderWeaving is in? > > That is the normal convention. Convention is also that they start > Tester... so they are excluded from the unit test scan. > > Mark
Okay. So I should rename the classes: org.apache.catalina.loader.TesterNeverUsedClass org.apache.catalina.loader.TesterUnweavedClass Did I understand that correctly? Nick
smime.p7s
Description: S/MIME cryptographic signature
