Re: Proposal: Some todo's at AsyncContext detected...

2010-06-30 Thread Marc Guillemot
Hi, What you write means that the freshly release Tomcat 7 doesn't fully implement Servlet API 3.0, isn't it? Interesting to see that nobody reacts :-( Cheers, Marc. Peter Roßbach wrote: Hi! I detected some Todo's at AsyncContext - AsyncContext.createListener We don't make a resourc

Re: Proposal: Some todo's at AsyncContext detected...

2010-07-01 Thread Marc Guillemot
Hi Mark, nice to see some activity on this thread. If you were following the dev list you would have seen that Jean-Frederic has already vetoed the change Peter made on the basis that it breaks the TCK. That suggests that Peter's analysis of the current situation is not 100% correct. I do f

Re: Proposal: Some todo's at AsyncContext detected...

2010-07-01 Thread Marc Guillemot
jean-frederic clere wrote: ... I run a daily test and just looked to what breaks it and complain. Now I am looking to Peter's application to find what is broken. so you're the continuous integration server ;-) Can you publish break information or is it forbidden by the TCK license/agreement?

Re: Proposal: Some todo's at AsyncContext detected...

2010-07-02 Thread Marc Guillemot
Rainer Jung wrote: ... Exact details are forbidden, but I'm sure there'll be some information as soon as someone had time to dig into it. this was exactly what I feared. This is an additional argument for an open source test suite. Cheers, Marc. -- Blog: http://mguillem.wordpress.com

Re: svn commit: r960104 - /tomcat/trunk/test/org/apache/catalina/mbeans/TestRegistration.java

2010-07-05 Thread Marc Guillemot
ma...@apache.org wrote: Author: markt Date: Fri Jul 2 21:13:25 2010 New Revision: 960104 URL: http://svn.apache.org/viewvc?rev=960104&view=rev Log: A few more FindBugs issues > ... why don't you integrate checkstyle (and FindBugs) in the build? It's the only safe way to ensure quality and to

Re: svn commit: r960104 - /tomcat/trunk/test/org/apache/catalina/mbeans/TestRegistration.java

2010-07-07 Thread Marc Guillemot
Hi Mark, Mark Thomas wrote: ... There is nothing stopping you running FindBugs, Checkstyle or any other tool locally. I use FindBugs on the Tomact 7 code-base all the time. what about sharing the config and including it into the build? What does the other developers think? +0 providing w

Re: svn commit: r960104 - /tomcat/trunk/test/org/apache/catalina/mbeans/TestRegistration.java

2010-07-08 Thread Marc Guillemot
Mark Thomas wrote: ... JavadocType (versionFormat) -> currently 539 failures Not sure what exactly you are proposing here. Could you clarify? I mean the format of the @Version JavaDoc tag what Konstantin Kolinko has started to fix: http://tomcat.markmail.org/thread/bfry4x5gwbhezo6x ...

Re: [ANN] Apache Tomcat 6.0.28 released

2010-07-09 Thread Marc Guillemot
Hi Jean-Frédéric, why does http://www.apache.org/dist/tomcat/tomcat-6/ always say: "Current stable version is 6.0.26" Cheers, Marc. -- Blog: http://mguillem.wordpress.com jean-frederic clere wrote: The Apache Tomcat team announces the immediate availability of Apache Tomcat 6.0.28 stable. Th

Re: [VOTE] Add Checkstyle ruleset and make code cleanups!

2010-07-12 Thread Marc Guillemot
Hi Konstantin, 1. What is TabSpacePolicy? It is not listed at: http://checkstyle.sourceforge.net/availablechecks.html There is FileTabCharacter though. http://checkstyle.sourceforge.net/config_whitespace.html#FileTabCharacter of course this is the FileTabCharacter check. Interesting to see wh

Re: [VOTE] Add Checkstyle ruleset and make code cleanups!

2010-07-12 Thread Marc Guillemot
Mark Thomas wrote: On 12/07/2010 09:39, Marc Guillemot wrote: I find interesting how some (Mark, you) seem to fight against introducing checkstyle and precisely defining what should be the rules although you make exactly this kind of changes. Then you completely mis-understand my position

Re: [VOTE] Add Checkstyle ruleset and make code cleanups!

2010-07-12 Thread Marc Guillemot
Mark Thomas wrote: ... Before I read you latest e-mail, I was intending to tidy up the patch attached to bug 49268 and look at applying it to trunk. Right now that looks like rewarding behaviour I have no wish to encourage so I'll be spending my time on other things instead. I'll circle back to t