Re: svn commit: r1163802 - in /tomcat: tc7.0.x/trunk/java/org/apache/catalina/loader/WebappClassLoader.java trunk/java/org/apache/catalina/loader/WebappClassLoader.java

2011-08-31 Thread Konstantin Kolinko
k and 7.0.x at the same time. Thus there is no need to merge. > Modified: > tomcat/tc7.0.x/trunk/java/org/apache/catalina/loader/WebappClassLoader.java > tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java Best regards, Konstantin Kolinko > Mark > > -

Re: svn commit: r1163802 - in /tomcat: tc7.0.x/trunk/java/org/apache/catalina/loader/WebappClassLoader.java trunk/java/org/apache/catalina/loader/WebappClassLoader.java

2011-08-31 Thread Konstantin Kolinko
2011/9/1 Mark Thomas : > On 31/08/2011 22:57, Konstantin Kolinko wrote: >> 2011/9/1 Mark Thomas : >>> On 31/08/2011 21:35, slaur...@apache.org wrote: >>>> Author: slaurent >>>> Date: Wed Aug 31 20:35:22 2011 >>>> New Revision: 1163802 >&g

Re: svn commit: r1163807 - in /tomcat: tc7.0.x/trunk/ trunk/

2011-09-01 Thread Konstantin Kolinko
onally, use it for? What are your practical benefits? Seeing tag names in history? If you really use it and will add all TOMCAT_7_0_x tags to /tomcat/tc7.0.x/trunk, and will maintain it onwards, I personally do not mind. Best regards, Konstantin Kolinko ---

Re: svn commit: r1157810 - in /tomcat/trunk: java/org/apache/catalina/core/StandardContextValve.java java/org/apache/catalina/core/StandardHostValve.java test/org/apache/catalina/core/TestStandardCont

2011-09-01 Thread Konstantin Kolinko
hinking is that firing > request listeners should move to the Host with the error handling but I > need to see what that looks like. > I think you have seen this as well: https://issues.apache.org/bugzilla/show_bug.cgi?id=51550#c9 though I do not know whether custom error handling can work

Re: [ANN] Apache Tomcat 7.0.21 released

2011-09-03 Thread Konstantin Kolinko
the complete list of changes: > http://tomcat.apache.org/tomcat-7.0-doc/changelog.html > >(...) I uploaded 7.0.21 docs and added version number in Bugzilla. The docs should be online in an hour, as usual. Have a nice day! Best regards, Konstantin Kolinko ---

Re: svn commit: r1165240 - in /tomcat/tc7.0.x/trunk: ./ webapps/docs/changelog.xml webapps/docs/config/http.xml

2011-09-05 Thread Konstantin Kolinko
Why are you changing docs without changing the code? As far as I see org.apache.coyote.http11.Constants.DEFAULT_CONNECTION_TIMEOUT is 6 in 7.0.x. Best regards, Konstantin Kolinko 2011/9/5 : > Author: markt > Date: Mon Sep  5 11:06:06 2011 > New Revision: 1165240 >

Re: svn commit: r1165240 - in /tomcat/tc7.0.x/trunk: ./ webapps/docs/changelog.xml webapps/docs/config/http.xml

2011-09-05 Thread Konstantin Kolinko
2011/9/5 Mark Thomas : > On 05/09/2011 15:27, Konstantin Kolinko wrote: >> Why are you changing docs without changing the code? >> >> As far as I see >> org.apache.coyote.http11.Constants.DEFAULT_CONNECTION_TIMEOUT >> is 6 in 7.0.x. > > Sorry, sent tha

Re: svn commit: r1166290 - /tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java

2011-09-07 Thread Konstantin Kolinko
in development mode or have enabled unloading unused JSPs in JspServlet configuration. If I understand correctly it accumulates references to Class objects but never releases them. Best regards, Konstantin Kolinko - To unsub

Re: Mitigating AJP CPing/Forward-Request packet forgery before next releases

2011-09-08 Thread Konstantin Kolinko
vn: /httpd/httpd/branches/2.2.x/modules/proxy/ The only code that mentions "secret" is in ajp_header.c there (besides a constant declared in ajp_header.h) and it is commented out /* XXXX need to figure out how to do this if (s->secret) { There is no parameter or local variable

In 7.0: sendfileInProgress flag in breakKeepAliveLoop() - difference in Nio vs. Apr

2011-09-09 Thread Konstantin Kolinko
pAliveLoop() implementations intended? JavaDoc says that the sendfileInProgress flag is used to indicate "that the * socket should not be returned to the poller (where a poller is used)." and I understand that both of them use pollers. Best regards

Re: [GUMP@vmgump]: Project tomcat-tc7.0.x-test (in module tomcat-7.0.x) failed

2011-09-12 Thread Konstantin Kolinko
ugh until we have a successful run of the tests). Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1169674 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/DefaultInstanceManager.java

2011-09-12 Thread Konstantin Kolinko
ion. Thus far the practice was that you specifically specify what single revisions you are merging, and thus those single revisions are added to the svn:mergeinfo on project root. I do not mind using ranges instead of single revisions. Best regards, Konstanti

Re: svn commit: r1166290 - /tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java

2011-09-12 Thread Konstantin Kolinko
2011/9/7 Mark Thomas : > On 07/09/2011 19:49, Konstantin Kolinko wrote: >> 2011/9/7  : >>> Author: markt >>> Date: Wed Sep  7 18:11:20 2011 >>> New Revision: 1166290 >>> >>> URL: http://svn.apache.org/viewvc?rev=1166290&view=rev >>>

Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2011-09-12 Thread Konstantin Kolinko
-- --- Testcase: testSimpleCometClient took 14,705 sec Testcase: testCometConnectorStop took 6,371 sec FAILED junit.framework.AssertionFailedError: at org.apache.catalina.comet.TestCometProcessor.testCometConnectorStop(TestCometProcessor.java:164) Best regar

Re: svn commit: r1165601 - /tomcat/trunk/res/ide-support/eclipse/java-compiler-errors-warnings.txt

2011-09-15 Thread Konstantin Kolinko
ght preference to keep it as "[ ]". BTW, this change has not been applied to 7.0.x copy of java-compiler-errors-warnings.txt yet. >  Annotations >  - All                                  - W >    (all additional check boxes) Best regards, Konstantin Kolinko --

Re: T&R Tomcat 5.5.34

2011-09-16 Thread Konstantin Kolinko
2011/9/16 Jim Jagielski : > The last remaining promoted STATUS issues have been > committed… I will T&R Tomcat 5.5.34 later on today. Good. I'd like to see the "2011-08-25-ajp-incomplete-msg-tc5.patch" patch included in the release. Are there concerns with it? Best re

Re: svn commit: r1171684 - in /tomcat/tc5.5.x/trunk: STATUS.txt connectors/http11/src/java/org/apache/coyote/http11/InternalAprInputBuffer.java container/webapps/docs/changelog.xml

2011-09-17 Thread Konstantin Kolinko
n order to not introduce another bug"? We > only updated "recommended" to 1.1.22, not "required", which would be OK > only in the first case. It is the first. The added code is executed only when running with native 1.1.22 and late

Re: T&R Tomcat 5.5.34

2011-09-18 Thread Konstantin Kolinko
Rainer has voted for it recently. I'll commit it in a few minutes. 2011/9/18 Jim Jagielski : > Last I checked it did not have the required 3 +1s and I > hadn't had the chance to test it out. Will try to do so > today and then tag/roll. > > On Sep 16, 2011, at 3:05 PM,

Re: svn commit: r1172318 - /tomcat/tc5.5.x/trunk/build/build.properties.default

2011-09-18 Thread Konstantin Kolinko
2011/9/18 : > Author: jim > Date: Sun Sep 18 18:35:13 2011 > New Revision: 1172318 > > URL: http://svn.apache.org/viewvc?rev=1172318&view=rev > Log: > get ready to tag 5.5.34 > > Modified: >    tomcat/tc5.5.x/trunk/build/build.properties.default > > Modified: tomcat/tc5.5.x/trunk/build/build.prope

Re: svn commit: r1173082 - in /tomcat/trunk: java/org/apache/coyote/http11/Http11NioProtocol.java test/org/apache/catalina/comet/TestCometProcessor.java

2011-09-20 Thread Konstantin Kolinko
2011/9/20 : > Author: markt > Date: Tue Sep 20 11:02:41 2011 > New Revision: 1173082 > > URL: http://svn.apache.org/viewvc?rev=1173082&view=rev > Log: > Remove empty comment You did more than removed a comment (you've committed two files instead of one)... > > Modified: >    tomcat/trunk/java/or

Re: svn commit: r1172689 - /tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java

2011-09-20 Thread Konstantin Kolinko
le(true); >        postConstruct.invoke(instance); >        postConstruct.setAccessible(accessibility); >    } > } > > Similarly for the other synch. blocks below. > My understanding is that "isAccessible()" is false by default for a new instance of Method object (r

Re: [VOTE] Release Tomcat 5.5.34 Build

2011-09-20 Thread Konstantin Kolinko
2011/9/18 Jim Jagielski : > The builds for Tomcat 5.5.34 are ready for testing and approval. > The candidates binaries are available here: > > [x] Stable Best regards, Konstantin Kolinko - To unsubscribe, e-mail:

Re: svn commit: r1173082 - in /tomcat/trunk: java/org/apache/coyote/http11/Http11NioProtocol.java test/org/apache/catalina/comet/TestCometProcessor.java

2011-09-20 Thread Konstantin Kolinko
2011/9/20 Mark Thomas : > On 20/09/2011 12:09, Konstantin Kolinko wrote: >> 2011/9/20  : >>> Author: markt >>> Date: Tue Sep 20 11:02:41 2011 >>> New Revision: 1173082 >>> >>> URL: http://svn.apache.org/viewvc?rev=1173082&view=rev >>&

Re: svn commit: r1173082 - in /tomcat/trunk: java/org/apache/coyote/http11/Http11NioProtocol.java test/org/apache/catalina/comet/TestCometProcessor.java

2011-09-20 Thread Konstantin Kolinko
2011/9/20 Mark Thomas : > On 20/09/2011 13:41, Konstantin Kolinko wrote: >> >> BTW: I am unable to reproduce Gump failure for TestCometProcessor with NIO >> (running with JDK 6u26/WinXP), >> but this test fails for me when running it with APR connector. > > I *thi

Session.getLastAccessTime() ticking

2011-09-21 Thread Konstantin Kolinko
expected. I think that is because examples webapp has protected pages and thus uses Authenticator. So if some webapp is used to test the difference in lastAccessedTime, it wouldn't see any problems if it uses Authenticator. Regarding the bug 51812, I think that it ma

Re: svn commit: r1174289 - in /tomcat/jk/trunk: native/apache-1.3/ native/apache-2.0/ native/common/ native/iis/ xdocs/miscellaneous/ xdocs/reference/

2011-09-22 Thread Konstantin Kolinko
 int r = atoi(sticky_ignore); > +            if (r) { > +                s->extension.reply_timeout = JK_TRUE; > +            } > +            else { > +                s->extension.reply_timeout = JK_FALSE; > +            } > +        } > +    } > + >     if (conf->options & JK_OPT_DISABLEREUSE) >         s->disable_reuse = 1; > > Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: How to became the tomcat developer?

2011-09-22 Thread Konstantin Kolinko
2011/9/23 Алексей Кадурин : > Hi! I want to contribute as a developer to Tomcat. (...) http://tomcat.apache.org/getinvolved.html Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

Re: [RESULT] Re: [VOTE] Release Tomcat 5.5.34 Build

2011-09-22 Thread Konstantin Kolinko
http://tomcat.apache.org/tomcat-55-eol.html BTW: I was unable to delete old 6.0.32 docs, owned by jfclere. The permissions on them are odd. Best regards, Konstantin Kolinko 2011/9/22 Jim Jagielski : > Files placed in dist and changes made to xml/html. Once mirrors > sync up, will svn up the site a

Re: svn commit: r1174468 - /tomcat/jk/trunk/native/common/jk_lb_worker.c

2011-09-23 Thread Konstantin Kolinko
t; -                curmin = w->s->lb_value; > -            } The initial value of curmin is assigned above the loop: curmin = (&p->lb_workers[0])->s->lb_value; I think you can remove that assignment. It happens without checking with "JK_WORKER_USABLE()" and th

Re: svn commit: r1174931 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/net/jsse/JSSESupport.java java/org/apache/tomcat/util/net/jsse/res/LocalStrings.properties webapps/docs/changelog.xm

2011-09-23 Thread Konstantin Kolinko
tor to be used with SSL when running under > Java > +        7. (markt) > +       Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1165601 - /tomcat/trunk/res/ide-support/eclipse/java-compiler-errors-warnings.txt

2011-09-23 Thread Konstantin Kolinko
2011/9/16 : > ma...@apache.org wrote: > >>Konstantin Kolinko wrote: >> >>>2011/9/6  : >>>> Author: markt >>>> Date: Tue Sep  6 11:12:17 2011 >>>> New Revision: 1165601 >>>> >>>> URL: http://svn.apache.

Re: svn commit: r1174181 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/ha/session/BackupManager.java java/org/apache/catalina/ha/session/ClusterManagerBase.java java/org/apache/catalina/ha/s

2011-09-23 Thread Konstantin Kolinko
xActiveSessions = getMaxActiveSessions(); > +        copy.notifyListenersOnReplication = isNotifyListenersOnReplication(); > +        copy.setSessionAttributeFilter(getSessionAttributeFilter()); > +    } In Eclipse the warning was: The sta

Re: svn commit: r1174181 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/ha/session/BackupManager.java java/org/apache/catalina/ha/session/ClusterManagerBase.java java/org/apache/catalina/ha/s

2011-09-24 Thread Konstantin Kolinko
d There are enough votes to apply that patch to TC6. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Re: problem when testing tomcat

2011-09-25 Thread Konstantin Kolinko
oes not support this feature. See SSL renegotiation support, aka CVE-2009-3555. Anyway the failing testCustomTrustManager2 test tests some API that you wouldn't use during normal operation. Only those who implement their own trust manager will be interested. Best regards

Re: svn commit: r1175421 - in /tomcat/site/trunk: docs/security-5.html docs/security-6.html docs/security-7.html xdocs/security-5.xml xdocs/security-6.xml xdocs/security-7.xml

2011-09-25 Thread Konstantin Kolinko
etFactory used by not-native connectors, nor AprLifecycleListener prints status of this feature support at Tomcat startup. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Mailing list for the Tomcat Maven Plugin

2011-09-25 Thread Konstantin Kolinko
Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1170485 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java

2011-09-25 Thread Konstantin Kolinko
return; > } I think that the above code had to be if (isDiscarded() || connection == null) { return; } >         setDiscarded(true); > Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1170485 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java

2011-09-25 Thread Konstantin Kolinko
2011/9/26 Konstantin Kolinko : > 2011/9/14  : >> Author: kfujino >> Date: Wed Sep 14 09:05:40 2011 >> New Revision: 1170485 >> >> URL: http://svn.apache.org/viewvc?rev=1170485&view=rev >> Log: >> Additional fix for r1170479. >> Make sure call

Re: svn commit: r1173251 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/http11/Http11AprProtocol.java

2011-09-26 Thread Konstantin Kolinko
().add( >                         socket.getSocket().longValue(), false); >             } If the socket is not added to the poller, shouldn't it be closed instead? Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2011-09-26 Thread Konstantin Kolinko
a:53:34: > Got an exception - expecting '5', found 'a' Checkstyle chocked on lines such as TestRequestUtil.java:80:27: assertEquals("\u00ea", result); They added processing for Unicode escapes recently, so I think that one is

Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2011-09-27 Thread Konstantin Kolinko
ache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO.txt Testcase: testMemberArrival took 4.262 sec == I think it is some timing issue, because NIO test succeeded and IIRC this test does not depend on connector implementation. (Still 9 vs 19 sounds like a big difference). Be

Re: svn commit: r1176544 - in /tomcat/maven-plugin/trunk: ./ tomcat-maven-plugin-it/ tomcat-maven-plugin-it/src/main/java/org/codehaus/mojo/tomcat/it/ tomcat-maven-plugin-it/src/main/resources/ tomcat

2011-09-27 Thread Konstantin Kolinko
mcat6UsageContextpathIT.java > (...) I think you forgot to set svn:eol-style=native on the added files. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [GUMP@vmgump]: Project tomcat-tc7.0.x-test (in module tomcat-7.0.x) failed

2011-09-28 Thread Konstantin Kolinko
Checking member arrival length expected:<9> but was:<11> In failed trunk test it was > Checking member arrival length expected:<9> but was:<19> So, it received more data than were expected? Best regards, Konstantin Kolinko ---

Re: [VOTE] Release Apache Tomcat 7.0.22

2011-09-28 Thread Konstantin Kolinko
issues.apache.org/bugzilla/show_bug.cgi?id=51910 https://issues.apache.org/bugzilla/show_bug.cgi?id=51912 Except the issue described by BZ 51912, all the rest of testsuite did run for me successfully with all three of BIO, NIO, APR connectors on WinXP, JDK

Re: [GUMP@vmgump]: Project tomcat-tc7.0.x-test (in module tomcat-7.0.x) failed

2011-09-28 Thread Konstantin Kolinko
2011/9/28 Konstantin Kolinko : > 2011/9/28 Bill Barker : >> To whom it may engage... >> >> This is an automated request, but not an unsolicited one. For >> more information please visit http://gump.apache.org/nagged.html, >> and/or contact the folk at gene...@gump

Re: [GUMP@vmgump]: Project tomcat-tc7.0.x-test (in module tomcat-7.0.x) failed

2011-09-28 Thread Konstantin Kolinko
n while reading data from NioChannel - If I remember it correctly. I cannot reproduce now and I do not have a stacktrace. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Comet API

2011-09-30 Thread Konstantin Kolinko
r call response.sendError() while it is in BEGIN event? e) If a Connector is stopped, will it be SERVER_SHUTDOWN subtype of END event. Though I think that during shutdown maybe WEBAPP_RELOAD will come first? Will the event come if connector is stopped through JMX? When a web application is stopped

Re: Comet API

2011-10-01 Thread Konstantin Kolinko
2011/10/1 Konstantin Kolinko : > Hi! > > I was reading the Comet API documentation, that is "aio.html" in the > docs and Javadoc of catalina.comet.* classes. > > Here are several notes. > Answering several of my notes below. > > CometEvent.java: > ===

Re: svn commit: r1177245 - /tomcat/trunk/java/org/apache/tomcat/util/http/MimeHeaders.java

2011-10-01 Thread Konstantin Kolinko
property as the delimiter in println(). The backport proposed to 6.0 though is about another issue: it replaces single getHeader(name) with iteration over multiple values using values(name). Best regards, Konstantin Kolinko > > On Thu, Sep 29, 2011 at 5:52 AM, wrote: > >> Author

Re: svn commit: r1174884 - /tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESupport.java

2011-10-02 Thread Konstantin Kolinko
ring("jsseSupport.unexpectedData")); > +                } This solution looks tricky. Maybe "in.available()" can work here? >             } catch(SSLException sslex) { >                 log.info(sm.getString("jsseSupport.clientCertError"), sslex); >                 throw

Re: svn commit: r1179274 - /tomcat/trunk/java/org/apache/tomcat/util/IntrospectionUtils.java

2011-10-05 Thread Konstantin Kolinko
pensive than returning false. http://svn.apache.org/viewvc?diff_format=l&view=revision&revision=565464 Best regards, Konstantin Kolinko > On Wed, Oct 5, 2011 at 11:44 AM, wrote: > >> Author: kkolinko >> Date: Wed Oct  5 15:44:58 2011 >> New Revision: 1179274 >&

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2011-10-09 Thread Konstantin Kolinko
run failed. Best regards, Konstantin Kolinko 2011/10/10 : > The Buildbot has detected a new failure on builder tomcat-trunk while > building ASF Buildbot. > Full details are available at: >  http://ci.apache.org/builders/tomcat-trunk/builds/2352 > > Buildbot URL: http://ci.apache.

Re: Embeded Tomcat using a Connector with a random port (port 0)

2011-10-09 Thread Konstantin Kolinko
27;s "locked" by a test in Connector#startInternal. >> Is it intentional ? > > svn blame would have answered that for you. > To be specific, that was http://svn.apache.org/viewvc?view=revision&revision=1147949 Best regards, Konstantin Kolinko -

Re: [RFC] Netmask-based filter and valve

2011-10-11 Thread Konstantin Kolinko
. (See RequestFilterValve#setAllow(String)). It would not be safe to operate a Valve that is misconfigured. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands,

Plans for 6.0.next?

2011-10-11 Thread Konstantin Kolinko
, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Write access to LocalBadContent (and other?) page(s) on wiki

2011-10-12 Thread Konstantin Kolinko
d it (Revert notifications are not always/never sent to the dev@ list). - Copy link on the "view" action of the revision that I am going to revert the page to, paste it in location bar and replace command name s/recall/revert/ in it. - Confirm revert operation and type in a comment Welcome

Re: Is caching tags in SimpleTags a good idea?

2011-10-12 Thread Konstantin Kolinko
spServlet that affects what Java code is generated. http://tomcat.apache.org/tomcat-7.0-doc/jasper-howto.html Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Mail address in security-NN.html pages

2011-10-12 Thread Konstantin Kolinko
ned on the generic security page (security.html), but on security-6.html page there is no direct link back to security.html unless you pay attention to the site menu on the left side. Best regards, Konstantin Kolinko - To unsubscri

Fwd: [jira] [Created] (INFRA-4027) Reconfigure tomcat70.git for another svn branch

2011-10-13 Thread Konstantin Kolinko
Hi! The tomcat70.git Git mirror still reflects our trunk and not tc7.0.x. I filed an INFRA issue, but as I do not have much experience with Git, maybe somebody else can look at this as well. https://issues.apache.org/jira/browse/INFRA-4027 Best regards, Konstantin Kolinko -- Forwarded

Re: svn commit: r615478 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/manager/LocalStrings.properties java/org/apache/catalina/manager/ManagerServlet.java webapps/docs/changelog.xml

2008-01-27 Thread Konstantin Kolinko
changelog message is misspelled. Method name is "ManagerServlet.expireSessions", not "exipreSession". 2008/1/26, [EMAIL PROTECTED] <[EMAIL PROTECTED]>: Author: pero Date: Sat Jan 26 11:52:28 2008 New Revision: 615478 URL: http://svn.apache.org/viewvc?rev=615478&view=rev [...skipped] ==

Re: svn commit: r615750 - /tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

2008-01-28 Thread Konstantin Kolinko
One typo is fixed, but another is still there. It should be "expire", not "exipre". 2008/1/28, [EMAIL PROTECTED] <[EMAIL PROTECTED]>: > Author: pero > Date: Mon Jan 28 00:01:40 2008 > New Revision: 615750 > > URL: http://svn.apache.org/viewvc?rev=615750&view=rev > Log: > Fix typo! > > Modified: >

Re: [VOTE] Release build 5.5.26

2008-01-31 Thread Konstantin Kolinko
The md5 files have an extra CR-LF in them. E.g. c8248787ee28cd0a80196f7cc6f57db8 *apache-tomcat-5.5.26.zip For 6.0.16 they are OK. 2008/1/31, Filip Hanik - Dev Lists <[EMAIL PROTECTED]>: > The candidates binaries are available here: > http://people.apache.org/~fhanik/tomcat/tomcat-5.5/v5.5.26/

Re: svn commit: r618059 - in /tomcat/trunk: java/org/apache/tomcat/util/net/NioEndpoint.java webapps/docs/changelog.xml

2008-02-03 Thread Konstantin Kolinko
Just a note. The change log message does not seem to be correct. It says opposite of what is implemented by the patch. In the patch the poller thread is started first. Also, the changelog.xml of trunk is substantially outdated. 6.0.16 is nearly coming out and adding new items to 6.0.15 looks stra

Re: svn commit: r646076 - /tomcat/trunk/java/org/apache/el/lang/ELArithmetic.java

2008-04-08 Thread Konstantin Kolinko
Well, obviously the new code is not equivalent to the old one, because Long.TYPE and other TYPE constants are the classes for the primitive types (long, int etc.), and those are not an instance of java.lang.Number. >From the sources: o.a.el.lang.ELArithmetic.isNumberType() is used in o.a.el.la

Re: svn commit: r646076 - /tomcat/trunk/java/org/apache/el/lang/ELArithmetic.java

2008-04-08 Thread Konstantin Kolinko
46 of 2006-03-27 when /tomcat/tc6.0.x/trunk was created? 2008/4/9 Mark Thomas <[EMAIL PROTECTED]>: > Konstantin Kolinko wrote: > > > Well, obviously the new code is not equivalent to the old one, because > > Long.TYPE and other TYPE constants are the classes for the primiti

Re: svn commit: r648605 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-04-16 Thread Konstantin Kolinko
2008/4/16 <[EMAIL PROTECTED]>: > * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44766 >Handle custom subtypes of java.lang.Number >http://svn.apache.org/viewvc?view=rev&revision=646106 > - +1: markt, remm > + +1: markt, remm, rjung >-1: > + rjung: Simply use: "return

Re: Vicious Bug in the JSP code?

2008-07-10 Thread Konstantin Kolinko
It looks like you are keeping a reference to some object (like the Request or Response, or OutputStream) and reusing it, while you should not access it outside the scope of request processing. I cannot go into details now, but all these messages and stack traces look familiar. Such questions are a

Re: svn commit: r684235 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-08-09 Thread Konstantin Kolinko
This proposal does not have URL of the patch. Only bugzilla URL is mentioned. I suppose that one meant to mention the following URL here: http://svn.apache.org/viewvc?rev=684234&view=rev 2008/8/9 <[EMAIL PROTECTED]>: > Author: markt > Date: Sat Aug 9 05:11:09 2008 > New Revision: 684235 > > UR

Re: svn commit: r684559 - /tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java

2008-08-14 Thread Konstantin Kolinko
f any help here? Best regards, Konstantin Kolinko 2008/8/14 Mark Thomas <[EMAIL PROTECTED]>: > Mark Thomas wrote: >> There must be a way to test cert/cipher compatibility without opening a >> socket but I couldn't find it when I looked. I'll take another look at the &

Re: svn commit: r685823 - in /tomcat: container/tc5.5.x/webapps/docs/config/systemprops.xml current/tc5.5.x/STATUS.txt jasper/tc5.5.x/src/share/org/apache/jasper/compiler/Parser.java jasper/tc5.5.x/sr

2008-08-14 Thread Konstantin Kolinko
s/escpaing/escaping/ in systemprops.xml 2008/8/14 <[EMAIL PROTECTED]>: > Author: markt > Date: Thu Aug 14 02:04:26 2008 > New Revision: 685823 > > URL: http://svn.apache.org/viewvc?rev=685823&view=rev > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45015 > You can't use an unesca

Re: svn commit: r687503 - in /tomcat/trunk/java/org/apache/tomcat/util/net/jsse: JSSESocketFactory.java res/LocalStrings.properties

2008-08-20 Thread Konstantin Kolinko
g in this specific JDK implementation than a design decision. Also, in this operation the server port is checked through the security manager for an "accept" permission. Some configurations might need adjusting. Best regards, Konstantin Kolinko 2008/8/21 <[EMAIL PROTECTED]>: > Author: mar

An extra LF in md5 files for 5.5.27 candidate (Ant 1.7 vs. 1.6.5)

2008-08-29 Thread Konstantin Kolinko
hecksum value into a property, and print it in the task. b) If going forward with 1.7+, the checksum task since 1.7.0 does support pattern and format attributes. E.g., format="MD5SUM" will do the job. Is Ant 1.6.5 compatibility required for Tomcat project? Best rega

Re: EL and TCK

2008-09-19 Thread Konstantin Kolinko
alue for an attribute of custom tag. The example from the spec "/> becomes and should have produced the following EL expression: "Joe said 'hello'" (without any backslash characters in EL text) I hope that this explanation matches your case. Best regards, Konst

Re: EL and TCK

2008-09-19 Thread Konstantin Kolinko
2008/9/19 Mark Thomas <[EMAIL PROTECTED]>: > Mark Thomas wrote: >> Konstantin Kolinko wrote: >>> In JSP 2.1 spec there is chapter >>> JSP.1.6 Quoting and Escape Conventions >>> - see "Quoting in Attributes" part there. >>> >>>

Re: svn commit: r699697 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-09-29 Thread Konstantin Kolinko
ardContext.java?r1=301463&r2=301486&pathrev=699633&diff_format=h The code is now in TC 5.0, 5.5, 6.0. Also, serializeability was introduced into other classes as well, http://mail-archives.apache.org/mod_mbox/tomcat-de

.exe installer installs some /src files in 5.5.27, 4.1.38 (candidate)

2008-10-30 Thread Konstantin Kolinko
/container/ The TC 6.0.18 installer is not affected, it does not install such files. Also, *.zip distributions do not include them. Is that by design? It looks like a bug to me. Best regards, Konstantin Kolinko - To unsubscribe, e

Re: svn commit: r717903 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/catalina/ha/deploy/FileMessageFactory.java webapps/docs/changelog.xml

2008-11-15 Thread Konstantin Kolinko
This removed Bill Barker's proposal ("Don't swallow input ...") from STATUS.txt It looks like it was not intentional. Best regards, Konstantin Kolinko 2008/11/15 <[EMAIL PROTECTED]>: > Author: markt > Date: Sat Nov 15 10:13:08 2008 > New Revision: 717903 &g

Re: svn commit: r718474 - in /tomcat/trunk/java/org/apache/tomcat/util/net: NioEndpoint.java SecureNioChannel.java

2008-11-18 Thread Konstantin Kolinko
It would a bit better to use java.lang.StringBuilder instead of StringBuffer here for code that runs on 1.5+ JVMs. also, in theory, this toString() code may throw an NPE, though it looks like it would not occur in practice. Just in case if it matters. Best regards, Konstantin Kolinko 2008/11

Re: svn commit: r723738 - in /tomcat/trunk/bin: setclasspath.bat setclasspath.sh

2008-12-30 Thread Konstantin Kolinko
The part of this patch that changes setclasspath.bat is broken. The if condition line should be: +if not "%JAVA_ENDORSED_DIRS%" == "" goto gotEndorseddir I.e., there should be a second '%' after the env variable name. Note: an error in the .sh part of the patch has already been fixed as http:/

Re: Question about Bugzilla etiquette

2009-01-28 Thread Konstantin Kolinko
, your comment #2 at https://issues.apache.org/bugzilla/show_bug.cgi?id=39013 was not sent to the list: http://marc.info/?t=12287871656&r=1&w=2 Thus it would be better to do not do that. Best regards, Konstantin Kolinko

Re: svn commit: r772875 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-05-09 Thread Konstantin Kolinko
bal try/finally to be added around the whole method, closing the stream in case of error or preliminary exit (e.g. caused by if (!openJARs())). Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomca

Re: svn commit: r772142 - /tomcat/trunk/java/org/apache/catalina/manager/ManagerServlet.java

2009-05-09 Thread Konstantin Kolinko
. > See how setWrapper() is already implemented in ManagerServlet. You can remember Engine reference that it calculates there, like host reference that is already remembered. Best regards, Konstantin Kolinko - To unsubscribe, e-

Re: How I can move a Web App from Netscape Web Server to Tomcat?

2009-05-12 Thread Konstantin Kolinko
ed. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r772142 - /tomcat/trunk/java/org/apache/catalina/manager/ManagerServlet.java

2009-05-12 Thread Konstantin Kolinko
that. It is reasonable. Best regards Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Terms of use for our Wiki

2009-05-13 Thread Konstantin Kolinko
Hi, all! Should there be some explicit TermsOfUse page or copyright/license clause in our wiki? Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev

Re: [VOTE] Release build 6.0.20

2009-05-13 Thread Konstantin Kolinko
tains two exact copies of /tomcat-6.0-doc/RUNNING.txt 2. the exe installer and zip distributive have the following difference in server.xml : * C:\PROGRAM FILES\APACHE SOFTWARE FOUNDATION\TOMCAT 6.0\CONF\server.xml * C:\(...)\_ZIP\CONF\SERVER.XML ***** I have not ru

svn commit: r775377, r775379, r775380 - /tomcat/site/

2009-05-17 Thread Konstantin Kolinko
y problem is already solved, but I know how to reproduce it. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r777247 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/SimpleCoordinator.java

2009-05-21 Thread Konstantin Kolinko
ug-propertypage-tsvn-props I have not heard of anything similar for other clients, or if any other clients were respecting this setting. In general, there is http://subversion.tigris.org/issues/show_bug.cgi?id=1974 which is unlikely to be implemen

Coding Guidelines, encodings, keywords

2009-05-21 Thread Konstantin Kolinko
(e.g. $Date:: 2009-05-21 08:33:21 #$) or to use $Id$ instead. Do we officially acknowledge that the sources are UTF-8? What explicit encoding should be specified in javac and javadoc tasks in our build files? ISO-8859-1 or UTF-8 ? Best regards, Konstantin Kolinko

Re: [VOTE] Release build 6.0.20

2009-05-24 Thread Konstantin Kolinko
such an archive and placed it in http://people.apache.org/~kkolinko/tomcat-6/v6.0.20/src/ md5 sum is 6a747d5bfa6b0b57605e8697ca8a4cae *apache-tomcat-6.0.20-src.tar.gz Best regards, Konstantin Kolinko - To unsubs

Re: [VOTE] Release build 6.0.20

2009-05-25 Thread Konstantin Kolinko
2009/5/24 sebb : > On 24/05/2009, Konstantin Kolinko wrote: >> 2009/5/14 Remy Maucherat : >> >> > The candidates binaries are available here: >>  > http://people.apache.org/~remm/tomcat-6/v6.0.20/ >>  > >>  > According to the release process,

Re: [VOTE] Release build 6.0.20

2009-05-26 Thread Konstantin Kolinko
2009/5/24 Konstantin Kolinko : > 2009/5/14 Remy Maucherat : >> The candidates binaries are available here: >> http://people.apache.org/~remm/tomcat-6/v6.0.20/ >> >> According to the release process, the 6.0.20 tag is: >> [ ] Broken >> [ ] Alpha >> [

Re: [PROPOSAL] Adding support for aliases to DirContext

2009-05-26 Thread Konstantin Kolinko
t=11896969103&r=2&w=2 http://marc.info/?t=118969691000003&r=1&w=2 http://svn.apache.org/viewvc?rev=575945&view=rev Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Updated procrun binaries

2009-05-29 Thread Konstantin Kolinko
5.5 (see STATUS). Your removal of 64-bit GUI files broke the build scripts there. Thought it will be easy to fix. > If not we should really make some more user friendly link > on the download section so those files can be picked up for > 6

Re: svn commit: r781780 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-06-04 Thread Konstantin Kolinko
tand, what is the point of this proposal? I see that it just removes generics. Tomcat 6.0 runs on JRE 1.5 or later and is built with compile.source=1.5 compile.target=1.5 There is no need to avoid generics there. Best regards, Konstantin Kolinko -

5.5.x branch cannot run

2009-06-09 Thread Konstantin Kolinko
n. I suppose that 4.1 will have the same problem. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: 5.5.x branch cannot run

2009-06-10 Thread Konstantin Kolinko
2009/6/9 Mark Thomas : > Konstantin Kolinko wrote: >> I built TC 5.5 distributive from current tc5.5.x, and it is broken: > > My bad. My port of the CVE-2008-5515 patch was too hasty. I'll fix it > (and 4.1.x which will likely have the same problem0 this evening. >

Re: svn commit: r783318 - /tomcat/current/tc5.5.x/STATUS.txt

2009-06-10 Thread Konstantin Kolinko
6 ? http://svn.apache.org/viewvc?rev=783316&view=rev Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Tagging 5.5.28

2009-06-10 Thread Konstantin Kolinko
he end of the week should be enough to review them, isn't it? 2. I hope that the release is build on Windows, and there is no urgent need to backport all those Linux-build patches from 6.0 now? Otherwise it will take some time. Am I wrong? Best regards, Konstan

Re: svn commit: r783779 - /tomcat/trunk/java/org/apache/tomcat/util/buf/HexUtils.java

2009-06-11 Thread Konstantin Kolinko
ts to find unused code. (Thanks to EclEmma plugin for Eclipse). Those results, though require much more work, are more reliable. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

<    3   4   5   6   7   8   9   10   11   12   >