a new session just for get operations is a wast of
> memory.
> do I miss something ? I am ready to do the development, maybe someone is
> working on this already ?
Best regards,
Konstantin Kolinko
-
To
nt. The default value is 1, too large for me. I need to
> set it to 1000.
> How to configure it?
>
That is a question for the users@ list.
1. read "Configuration reference" part of Documentation
2. edit Connector attributes in server.xml
3. restart Tomcat
string returned by class.getName() as well as field
and method names should be already interned by JVM.
So instead of String.intern() it should be possible to call class.getName(). :/
I am OK with your proposal, but I do not expect much savings from
getting rid of those du
timestampProps.put(
> Tomcat7Runner.ARCHIVE_GENERATION_TIMESTAMP_KEY, runtimeProperties.getProperty(
> + Tomcat7Runner.ARCHIVE_GENERATION_TIMESTAMP_KEY ) );
> + timestampProps.store( new FileWriter( timestampFile ),
> "Timestamp file for executable war/jar" );
It needs FileOutputStream above.
> + }
> + }
> + else
> + {
> + String wars = runtimeProperties.getProperty( WARS_KEY );
> + populateWebAppWarPerContext( wars );
> + }
> }
>
> // create tomcat various paths
>
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
2012/5/12 Costin Manolache :
> On Sat, May 12, 2012 at 8:08 AM, Konstantin Kolinko
> wrote:
>
>> Hi!
>>
>> The SpdyProxyProtocol class (exists in trunk only) uses ajp.Constants
>> class:
>>
>> setSoLinger(Constants.DEFAU
t;> @@ -173,6 +173,14 @@ public abstract class AbstractEndpoint {
>> }
>>
>> public int getMaxConnections() { return this.maxConnections; }
>> +
>
> Javadoc?
> In particular, it would help if the condition under which -1 is
> returned were
and let the ErrorReportValve to
handle the rest?
Well, just blatantly casting to RequestFacade will do effectively the same.
> + }
> }
>
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
ipherSuite value. Thus I went with filtering,
to get correct HTML in the output, like in r1337745.
snoop.jsp already filters all values, so it is for consistency as well.
Best regards,
Konstantin Kolinko
>>
>> Modified:
>> tomcat/trunk/webapps/examples/WEB-INF/
lidation when reconnect() is called.
>
Should we include this change into 7.0.x? It looks OK, but I have not tested.
The svn:externals value in 7.0.x has not been updated yet.
Best regards,
Konstantin Kolinko
>
> Modified:
>
> tomcat/trunk/modules/jdbc-pool/src/main/j
self.
The name and version are calculated from path.
The same with docBase.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
- TCN_CHECK_ALLOCATED(tps->socket_ttl);
> + tps->socket_last_active = apr_palloc(p, size *
> sizeof(apr_interval_time_t));
Looking at the declaration of "socket_last_active" field, the above
should have used sizeof(apr_time_t).
> + TCN_CHECK_ALLOCATED(tps->socket_las
2012/5/24 Konstantin Kolinko :
> 2012/5/24 :
>> Author: markt
>> Date: Wed May 23 20:07:46 2012
>> New Revision: 1342010
>>
>> URL: http://svn.apache.org/viewvc?rev=1342010&view=rev
>> Log:
>> Renames to make code clearer
>> socket_ttl ->
#150 was OK. This seems to be the only change
between the 150 and 151.
Best regards,
Konstantin Kolinko
> Modified:
> tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractExecWarMojo.java
> URL:
> http://svn.apache.org/viewvc/to
, String type
The above comment does not match the code anymore. The "scope" is no
more used, being replaced by "classifier". I think the comment can be
simply removed, as what happens is visible from the code.
Best regards,
Konstantin Kolinko
>
diately get 127.0.0.1 from his machine's lookup-service.
>
(OT) That is just how "nslookup" works. It queries DNS server and does
not care about "hosts" file. Simple "ping localhost" would be more
informative.
Best regards,
Konstantin Kolinko
---
n e) {
> log.error(sm.getString("contextConfig.baseError"), e);
> return null;
> }
>
> - return getWebXmlSource(resourceName, basePath);
> + return getWebXmlSou
;> just a leftover from debugging the issue.
>>
>> The same for the TC 7 backport.
>>
>
> hi Rainer, no, not intentional, it is left over from debugging. I will remove
> the Date object
>
Fixed by
http://svn.apache.org/viewvc?view=revision&revision=13424
);
> + portProperties.put( "tomcat.maven.https.port",
> Integer.toString( connector.getLocalPort() ) );
The above line apparently should have called
httpsConnector.getLocalPort()
> System.setProperty( "tomcat.maven.https.port",
> Integer.toString( httpsConnector.getLocalPort() ) );
> }
>
> (...)
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
same reason. They are not run because of JUnit being broken.
It is a bit odd that Gump included XML file
"commons-beanutils-gump-25052012.xml" into the classpath instead of
commons-beanutils-25052012.jar, but it does not change much because
that jar does not exist.
Best regards,
Konstantin
eally understand it. Just thinking of symmetry and
comparing it with the two lines just above the if(),
[[[
++aw->s->h.sequence;
aw->sequence = aw->s->h.sequence;
]]]
)
Best regards,
Konstantin Kolinko
> }
> if (locked == JK_FALSE)
> jk_shm_unl
ould it be better to make it a File instead of a String, like
other fields there ?
2. It might be useful to allow absolute paths here.
E.g. if one wants to move it to the system temporary directory, or to
a RAM drive.
Best regards,
Konstantin Kolinko
--
ated version of processSendfile() method in
NioEndpoint that will ignore one of its parameters and call the
correct one. It feels waste, but it is not much to code.
Thank you for review.
Best regards,
Konstantin Kolinko
>> -Original Message-
>> From: kkoli...@apache.org [mailto:kko
nnectors/jk/README.html
>> release/tomcat/tomcat-connectors/jk/binaries/windows/README.html
>>
>
> ???
> What happened to uploads?
> I don't see .svn for jk (and native) subdirs
>
You forgot to execute "svn add" before committing?
Best regards,
Konstan
ot see any files there. Did you forget to commit something?
There are no test failures though (apart the usual TestCometProcessor).
>
>
>
>
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
n JIRA.
For example:
https://issues.apache.org/jira/browse/MTOMCAT-100
https://issues.apache.org/jira/browse/DAEMON-245
Is this issue (configure MTOMCAT to allow attachments) something
that we can fix by ourselves, before escalating to infra?
Best regards
ng a patch from people.apache.org would have the
same effect.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
String fieldName = Introspection.getName(method);
If the "getName()" method was moved into utility class,
maybe rename it to something more specific?
"getFieldName()" ? "getSetterFieldName()" ?
This method creates field name from the name of a setter method.
esult = targetType;
> + } else {
> + // Incompatible types
> + return null;
> + }
> + }
> + return result;
> + }
Does something guarantee that there is always common type among
injection targets?
Can there be two
throws ServletException, IOException {
>+resp.setStatus(HttpServletResponse.SC_OK);
>+resp.setContentType("text/event-stream");
>+resp.addHeader("Connection", "close");
It could be resp.setHeader(..) in this test servlet here.
>+resp.flushBuffer();
>+resp.getWriter().write("OK");
>+resp.flushBuffer();
>+}
>+}
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
overflow if the buffer is used again. BZ53119.
> + outputBuffer.clear();
> throw new
> IOException(sm.getString("ajpprocessor.failedsend"));
> }
> outputBuffer.clear();
>
Looks good. Backport to 6.0?
AjpNioProcessor#output(byte[], i
pRequired = true;
I think it also needs "version = null"; here.
The version variable is modified in the mapping loop.
> + }
> }
>
> // Possible redirect
>
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
2012/6/4 Mark Thomas :
> On 04/06/2012 07:55, Konstantin Kolinko wrote:
>> 2012/5/8 :
>>> Author: markt
>>> Date: Tue May 8 19:07:09 2012
>>> New Revision: 1335700
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1335700&view=rev
>>
(saying that current support
is broken, or is limited to some specific connector)?It will
prevent ones from testing and evaluating the feature, and we might
well lose a year- without proper testing of the feature.
Best regards,
Konstantin Kolinko
--
2012/6/5 Konstantin Kolinko :
>>
>> For that reason, I'd like us to be more conscious about our commits on v7
>> and start looking at v7 as bug fixes and stabilization as the primary
>> drivers for commits.
>
> Stabilization usually means that we stop fixing
2012/6/4 Mark Thomas :
> On 03/06/2012 23:58, Mark Thomas wrote:
>
>> Konstantin Kolinko wrote:
>
>>> Does something guarantee that there is always common type among
>>> injection targets?
>>>
>>> Can there be two disjoint interfaces A and
mplementation idea, feel free to re-fix.
>
Re: r1343153, r1343155
Looks good. Thank you.
Best regards,
Konstantin Kolinko
> 2012/5/25 Konstantin Kolinko :
>> 2012/5/22 :
>>> Author: kfujino
>>> Date: Tue May 22 09:27:00 2012
>>> New Revision: 1341370
2012/6/4 Mark Thomas :
> On 04/06/2012 07:41, Konstantin Kolinko wrote:
>> 2012/5/30 :
>>> Author: markt
>>> Date: Wed May 30 13:35:55 2012
>>> New Revision: 1344253
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1344253&view=rev
>>&
o the context root
>
> Added:
>
> tomcat/trunk/test/org/apache/tomcat/util/http/mapper/TestMapperContextRoot.java
svn:eol-style is missing
> Modified:
> tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
> tomcat/trunk/java/org/apache/tomcat/util/http/mappe
ioning the chapter number (12.2) in the comment in Mapper.java
I suspect that this feature is not covered by official tests, because
otherwise we would have had to deal with it earlier.
So maybe we should respect ch.3.5 here, instead of 12.2?
> + resp.setContentType
that I removed in r1346519 were all in the code
added in r1298986. So maybe that is why they are not visible in this
proposal.
If you are saying about backporting r1346519 to 7.0, I'll do it.
Best regards,
Konstantin Kolinko
---
nt.apache.org/manual/Types/antlib.html
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
2012/6/6 Mark Thomas :
> On 05/06/2012 23:42, Konstantin Kolinko wrote:
>> 2012/6/6 :
>>> Author: markt
>>> Date: Tue Jun 5 22:38:53 2012
>>> New Revision: 1346638
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1346638&view=rev
>>&g
something was amiss.
>
> Any ideas what might be going on?
>
The cert was changed some time ago. (in January 2012)
https://twitter.com/infrabot/statuses/155072112128831488
So the last time you used svn client on p.a.o should have been before that date.
BTW, you can se
st).
2. I usually review the diff before committing.
TortoiseSVN has "Show changes as unified diff" command.
Command-line has "svn diff" command.
Eclipse probably has something like that.
I hope this will be useful.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
ly
designed to clean up temporary directories and files.
3. if(!mkdir() ) tests in the test method - I think if you rerun after
failed test those will return false, because directory already exists.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
e a look?
>
Apparently it was built from native/trunk, instead of native/branches/1.1.x
I'll take care of it.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
2012/6/8 Konstantin Kolinko :
> 2012/6/8 Christopher Schultz :
>> All,
>>
>> http://tomcat.apache.org/native-doc/
>>
>> It says that tcnative 2.0.0 has been released, has no date, and links to
>> non-existent files.
>>
>> Same thing with http://to
nglish speaker there?) it
would be nice. I would wait a while (~ 10-12 hours) before porting the
changes into Tomcat 7 and 6.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
ter(throwable.getMessage());
}
if (message == null) {
message = "";
}
Alternatively, maybe String.valueOf(throwable.getMessage()) to convert
null to "null". I cannot say what is better without a bit of
experimenting, but using &q
this bug was:
String message = RequestUtil.filter(response.getMessage());
if (message == null) {
message = "";
}
So resulting message was never null.
In your code it will be null when message and throwable are both null.
Best regards,
Konstant
2012/6/11 Christopher Schultz :
> Konstantin,
>
> On 6/7/12 5:49 PM, Konstantin Kolinko wrote:
>> 2012/6/8 Konstantin Kolinko :
>>> 2012/6/8 Christopher Schultz :
>>>> All,
>>>>
>>>> http://tomcat.apache.org/native-doc/
>>>&
ove one comes from
tools/dist/README.html
of jk project
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
thod addStringArray(..) is an odd
one. It is not needed there. When processing
filterConfig.getInitParameter("compressionMimeTypes"); just put values
in a list (ignoring empty ones?) and call toArray().
Best regards,
Konstantin Kolinko
--
and
maxConnections) is not fixed yet for APR connector.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
> I have debugged it in Tomcat 6.0.35. But I couldn't find the answer.
>
> Could anybody give me some reference. Thank you very much.
>
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
orrect connection count" warning
with BIO connector, but only once (in
"tcn-tc-ant_test-bio.out-1.1.24.sles10.x86_64:1"). The cause is still
unknown.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-ma
bution, I wonder whether it
will be possible to recreate a release from it.
The build.xml file of 5.5 contains copy operation that explicitly
references the KEYS file.
I think this operation will fail because of missing file.
Best regards,
Konstantin Kolinko
--
ge. Old announcements are there. Some of them
contain important notices (many 7.0.x announcements do).
Maybe I should axe download links when copying announcements there,
like I did with earlier releases.
Best regards,
Konstantin Kolinko
-
he group.
For reference,
$ svn --version
svn, version 1.7.3 (r1242825)
compiled Feb 26 2012, 21:09:32
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
2012/6/14 Mark Thomas :
> On 14/06/2012 15:10, Konstantin Kolinko wrote:
>> Hi!
>>
>> I just had a problem with running "svn up" on tomcat.a.o.
>> I found a solution, but I wonder whether others will experience the same
>> issue.
>
> They will
://tomcat.apache.org/tomcat-7.0-doc/aio.html#Comet_timeouts
http://tomcat.apache.org/tomcat-7.0-doc/api/org/apache/catalina/comet/CometEvent.html
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr
Though if it is work in progress maybe some comments/summaries will be
needed to understand how it is going to be integrated with existing
code.
> Since this is fairly major work, any objections before I start?
>
> Cheers,
>
> Mark
>
> [1] https://issues.apache.org/bugzilla/show_bu
e question of
whether it exposes too much details), but you cannot do so with
directories, as entries in a directory can be assembled from several
sources.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
ount" warning (discussed 5 days ago) did
not happen, so that issue appears to be fixed.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
e to add some emphasis to the Tomcat-Native version bump
in the release announcement for 7.0.28.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
ers' experience in using the feature,
search/ask on the users mailing list.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
SPACE *otherchar newline *continuation)
(continuation: SPACE *otherchar newline)
[1] http://docs.oracle.com/javase/7/docs/technotes/guides/jar/jar.html
I am OK to disable the validation for this file, but I I think it
would be
eHandler
connector.
6. The patch includes a fix for JkMain.setProperty(). This is so that
replacement of "maxHeaderCount" -> "request.maxHeaderCount" happened
not only at startup but also when changing this attribute on Connector
MBean.
Best regards,
Konstantin Kolinko
gt; * @since 1.0
> */
> - private boolean delegate = true;
> + private final boolean delegate = true;
The above change is odd.
It is annotated as "@parameter" but you are marking it as final...
Best regards,
Konstantin Kolinko
-
Dependencies &&
> getAdditionalWebapps().isEmpty() )
> {
> getLog().info( "skip execution" );
> return;
The above "if(skip)" clause in tomcat6/AbstractRunMojo.java
Do you ignore "skip execution" flag unless two other conditions a
to WebSocket support including the use of
> + infinite timeouts by default for WebSocket connections.
> +Various fixes and improvements to annotation scanning.
> +
> +Full details of these changes, and all the other changes,
Hi!
Previous version of Tomcat 6 was released in December 2011.
There are a number of changes already committed and a number of
nominations in the STATUS file.
I think it is about time to start preparing for the next Tomcat 6.0 release.
Best regards,
Konstantin Kolinko
tories/orgapachetomcat-260/org/apache/tomcat/extras/
There should be juli, juli-adapters.
tomcat-catalina-ws, tomcat-catalina-jmx-remote
should not be in "extras" but in "tomcat".
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
2012/6/21 Mark Thomas :
> On 21/06/2012 11:30, Mark Thomas wrote:
>> On 21/06/2012 11:25, Konstantin Kolinko wrote:
>>> 2012/6/21 Mark Thomas :
>>>> On 21/06/2012 10:57, Mark Thomas wrote:
>>>>> On 21/06/2012 10:31, Mark Thomas wrote:
>>>&
where certain
fields are missing.
NoSuchFieldException is a checked exception, so where its handling was
removed it is because it is not thrown there.
Handling of other exceptions has not changed.
Best regards,
Konstantin Kolinko
-
To
2012/6/6 Mark Thomas :
> On 06/06/2012 00:22, Konstantin Kolinko wrote:
>> 2012/6/6 Mark Thomas :
>>> On 05/06/2012 23:42, Konstantin Kolinko wrote:
>>>> 2012/6/6 :
>>>>> Author: markt
>>>>> Date: Tue Jun 5 22:38:53 2012
>>>&
2012/6/25 Williams, Nick :
> -Original Message-
> From: Konstantin Kolinko [mailto:knst.koli...@gmail.com]
> Sent: Sunday, June 24, 2012 11:15 AM
> To: Tomcat Developers List
> Subject: antlib.xml vs catalina.tasks (was: Re: r1346638)
>
> 2012/6/6 Mark Thomas :
&
protocol="org.apache.coyote.http11.Http11AprProtocol"
> port="8443" maxThreads="200"
> scheme="https" secure="true" SSLEnabled="true"
> SSLCertificateFile="/usr/local/ssl/server.crt"
> SSLCertificateKeyFile="/usr/local/ssl/server.pem"
> - clientAuth="optional" SSLProtocol="TLSv1"/>
> --->
> + SSLVerifyClient="optional" SSLProtocol="TLSv1"/>
>
>
>
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
.exception_type";
> public static final String ERROR_MESSAGE = "javax.servlet.error.message";
> public static final String ERROR_REQUEST_URI =
> "javax.servlet.error.request_uri";
> public static final String ERROR_SERVLET_NAME =
> "javax.servlet.error.servlet_name";
> public static final String ERROR_STATUS_CODE =
> "javax.servlet.error.status_code";
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
- throws IOException, IllegalStateException, IllegalArgumentException;
> + throws IllegalStateException, IllegalArgumentException;
>
> /**
> *
>
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
ug53465 took 0.89 sec
FAILED
expected:<200> but was:<404>
It is the recently added test.
BTW, the NIO log shows a lot of NullPointerExceptions. Those happen
after ProtocolHandler is stopped and destroyed.
Best regards,
Konstantin Kolinko
---
erform the cleanup.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
er(String name, String value) {
> + super.setHeader(name, value);
> + if ("content-length".equalsIgnoreCase(name)) {
> + didSetContentLength = true;
> + }
> + }
> +
> + @Override
> pu
inal List roles;
> +private final String userRoleId;
> +
>
> public User(String username, String dn, String password,
> -List roles) {
> +List roles, String userRoleId) {
> this.username = username;
> this.dn
//ci.apache.org/projects/tomcat/tomcat8/logs/
->1356852/
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
k.AssertionFailedError: null
at
org.apache.catalina.loader.TestWebappClassLoaderExecutorMemoryLeak.testTimerThreadLeak(TestWebappClassLoaderExecutorMemoryLeak.java:72)
]]]
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@to
+1822,15 @@ public class Response
> cc.setEnd(end);
> index = index2;
> }
> +
> +// Add the query string (if present) back in
> +if (queryCC != null) {
> +try {
> +cc.append(queryCC, 0, queryCC.length);
>
he
> standards compliant text "Found" is also used by the Apache Web Server.
I do not really like how many "{0}" are used in those messages in the
valves' resource file. There was some discussion of that in
https://issues.apache.org/bugzilla/show_bug.cgi?id=53071#c9
Reg
2012/6/17 Mark Thomas :
> On 16/06/2012 19:18, Mark Thomas wrote:
>>
>>
>> Konstantin Kolinko wrote:
>>
>>> 2012/6/16 Mark Thomas :
>>>>
>>>>> URLs are needed per Servlet API, so they cannot be removed.
>>>>> Does our &
2012/7/30 Mark Thomas :
> On 30/07/2012 01:16, Konstantin Kolinko wrote:
>> If we remove JNDI stuff from resource handling, one of "challenges"
>> might be to re-implement DefaultServlet using only Servlet API
>> methods. Well, if the former is not possible, it mig
ct on Jenkins "TomcatMavenPlugin-mvn2.x" [1] that is
in the failed state for many months (and it nags me with an e-mail
every time it builds).
If maven 2 is not supported, then maybe it is now time to remove this
project from Jenkins?
[1] https://builds.apache.or
(RFC1123_DATE, Locale.US),
> new SimpleDateFormat("EE, dd-MMM-yy HH:mm:ss zzz", Locale.US),
> new SimpleDateFormat("EEE d HH:mm:ss ", Locale.US)
> };
>
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
nk/STATUS.txt
> tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/ExpandWar.java
> tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
>
> Propchange: tomcat/tc6.0.x/trunk/
> ------
>
2012/8/10 Konstantin Kolinko :
> 2012/8/9 :
>> Author: schultz
>> Date: Thu Aug 9 18:14:14 2012
>> New Revision: 1371355
>>
>> URL: http://svn.apache.org/viewvc?rev=1371355&view=rev
>> Log:
>> https://issues.apache.org/bugzilla/show_bug.cgi?id=
t "Step 9a. Make the merged web.xml available to other
components, specifically Jasper, (...)" from the main
"if(!webXml.isMetadataComplete())" branch?
Shouldn't it be invoked in this case as well?
I think it is possible to move
e() method. If
you intend to use those, then it is OK to leave concrete
implementation class in the declaration.
Just my preference.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
patch, it is good.
If not, or if it is too much of a burden, do not worry.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
show
additional information in the log.
On your question of "that is a little foolish":
Regardless of the patch, if you consider those revisions processed, so
nothing from them should ever be automatically merged again into this
vers
onder what performance will be there
with file and jar URLs.
>
> I can put a patch of the changes so far on people.a.o if you are
> interested (note: it won't compile yet).
>
I would like to look and review. I think that at the current point
this refactoring
reate a Locale. According to RFC2616 ch 3.10
there may be an arbitrary count of subtags.
language-tag = primary-tag *( "-" subtag )
One more bug in ResponseUtil.getLocaleFromLanguageHeader():
===
"if (primaryTag.length() != 2)"
should be "if (primaryTag.length() != 2 && primaryTag.length() != 3)"
RFC2616 ch 3.10 says that language codes are 2 characters, but this
information is outdated. The language codes can be 3 characters as
well.
The IANA registry is defined by RFC 5646 and can be seen here: Look for "aaa".
http://www.iana.org/protocols/
http://www.iana.org/assignments/language-subtag-registry/
The Locale(String,String) constructor in JDK 7u05 says "An ISO 639
alpha-2 or alpha-3 language code".
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
301 - 400 of 2494 matches
Mail list logo
