2012/6/18 <kkoli...@apache.org>: > Author: kkolinko > Date: Mon Jun 18 10:21:01 2012 > New Revision: 1351269 > > URL: http://svn.apache.org/viewvc?rev=1351269&view=rev > Log: > Propose updated patch > > Modified: > tomcat/tc6.0.x/trunk/STATUS.txt >
> * Implement maxHeaderCount attribute on Connector. > It is equivalent of LimitRequestFields directive of Apache HTTPD > (backport of r1350295) > In JkMain.setProperty(): Fix setting of properties when connector has > already started for properties that have aliases. E.g. changing > maxHeaderCount attribute on Connector MBean via JMX. > Patch: > > http://people.apache.org/~kkolinko/patches/2012-06-18_tc6_maxHeaderCount_v2.patch > Eol-Style: > svn propset svn:eol-style native > java/org/apache/coyote/AbstractProtocol.java > svn propset svn:eol-style native > java/org/apache/tomcat/util/net/AbstractEndpoint.java Several comments on the proposed patch. 1. I tested HTTP connectors using RequestHeaderExample servlet + JMX 2. I have not tested request handling by AJP connectors, but tested that the maxHeaderCount setting is manageable via JMX. 3. I am introducing new base classes, AbstractProtocol and AbstractEndpoint. 4. JkCoyoteHandler AJP connector differs a lot. The maxHeaderCount property was added to HandlerRequest class. 5. Connector.getMaxHeaderCount() slightly differs with its implementation in Tomcat 7. This is to handle JkCoyoteHandler connector. 6. The patch includes a fix for JkMain.setProperty(). This is so that replacement of "maxHeaderCount" -> "request.maxHeaderCount" happened not only at startup but also when changing this attribute on Connector MBean. Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
