Re: [newbie] best way to propose patch?

2011-11-23 Thread Konstantin Kolinko
er creating the issue in Bugzilla, feel free to post to dev@. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [newbie] best way to propose patch?

2011-11-24 Thread Konstantin Kolinko
2011/11/24 Michal Hasko : > On 11/23/2011 06:38 PM, Konstantin Kolinko wrote: >> The preferred way is to create a report in Bugzilla and attach the patch >> there. > > As I think about what the page http://tomcat.apache.org/svn.html says > about trunk branch: > >  &

Re: svn commit: r1207856 - /tomcat/tc7.0.x/trunk/modules/

2011-11-29 Thread Konstantin Kolinko
propget svn:externals modules --strict >file.txt Without --strict option above it adds an extra empty line at the end of the file. Edit the file and svn propset svn:externals --file file.txt modules To test it before committing: svn up That is if you do not have a GUI SVN client Best re

Re: Using Passwords with special characters to for SQL JDBC Connection Pool

2011-11-30 Thread Konstantin Kolinko
2011/11/30 rogermcnally : > > I'm trying to configure a JDBC Connection Pool for SQL Server 2005 in Tomcat > 6 but am hitting a wall in that connection password uses special characters > e.g. / < / etc.  It's causing this error, > > > > Element type "Resource" must be followed by either attribute s

Re: Proposal: use tomcat-version-number in server.xml element?

2011-12-02 Thread Konstantin Kolinko
cause some LifeCycle listener implementations were removed. - Tomcat 5.5 and 6.0 differ in loader configuration in catalina.properties How about mentioning your issue somewhere in the FAQ? Though I think it is already mentioned on http://apache.org/migration.html Best regards, Konstantin Kolinko -

Re: DO NOT REPLY [Bug 52259] synchonization issues and dead lock if no realm is presented in configuration

2011-12-02 Thread Konstantin Kolinko
gt; > Yes and no: it's in the changelog, but the changelog currently published > on the website doesn't cover anything past 7.0.23. > There is link here: http://tomcat.apache.org/bugreport.html#Recently_fixed_issues Best regards, Konstantin Kolinko --

Re: Proposal: use tomcat-version-number in server.xml element?

2011-12-03 Thread Konstantin Kolinko
2011/12/2 Filip Hanik - Dev Lists : > On 12/2/2011 10:11 AM, Konstantin Kolinko wrote: >> >> 2011/12/2 Christopher Schultz: >>> >>> All, >>> >>> This may be a waste of time, but it's worth suggesting IMO. >>> >>> We hav

Re: svn commit: r1212618 - in /tomcat/maven-plugin/trunk: common-tomcat-maven-plugin/pom.xml pom.xml

2011-12-09 Thread Konstantin Kolinko
,11 @@ >     > >     > +      org.apache.httpcomponents > +      fluent-hc > +     > + > +     >       org.apache.tomcat >       tomcat-catalina >       7.0.22 7.0.23? Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Timing for 7.0.24

2011-12-09 Thread Konstantin Kolinko
ut that) I'm happy to > re-evaluate. > > I'm aiming to work through the open bugs between now and then. I'm > currently working on 52184. > I like the plan. Best regards, Konstantin Kolinko

Re: Cross site scripting safe

2011-12-14 Thread Konstantin Kolinko
ailed answer, ask on users@. See also "Security Considerations" page in the manual. > css filtering It is usually called "xss", not css. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: de

Re: svn commit: r1214855 - in /tomcat/trunk: java/org/apache/jasper/compiler/Parser.java test/org/apache/jasper/compiler/TestParser.java test/webapp-3.0/bug52335.jsp

2011-12-15 Thread Konstantin Kolinko
from code review. I have not tried to debug it yet). Best regards, Konstantin Kolinko 2011/12/15 : > Author: markt > Date: Thu Dec 15 16:50:25 2011 > New Revision: 1214855 > > URL: http://svn.apache.org/viewvc?rev=1214855&view=rev > Log: > Fix https://issues.ap

Re: Publishing process for JARs for Maven Central

2011-12-17 Thread Konstantin Kolinko
ous releases of 7.0 in your local repository (so that the file is built correctly)? If Nexus allows to prepare new releases without the need to keep old releases around, I am +1 for it. Best regards, Konstantin Kolinko -

Re: svn commit: r1215557 - in /tomcat/tc6.0.x/trunk/res/maven: README.txt mvn-pub.xml mvn.properties.default

2011-12-17 Thread Konstantin Kolinko
ASF repo (staging in nexus) > +maven.asf.release.repo.url=https://repository.apache.org/service/local/staging/deploy/maven2 >  maven.asf.release.repo.repositoryId=apache.releases >  maven.asf.release.deploy.version=${tomcat.version} Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Move to Maven? (WAS: Re: Publishing process for JARs for Maven Central)

2011-12-20 Thread Konstantin Kolinko
it is not mature enough. Ant is surely easier to run and it comes with IDE by default. If one wants to convince me in using Maven - I would very like to see a release of Tomcat taglibs subproject. It looks we are stalled there. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: MBean InitialContext() Tomcat query- pls help

2011-12-20 Thread Konstantin Kolinko
You should ask on the users@ list. It is offtopic on dev@. 2011/12/20 S B : > Hi, > > I created and deployed an MBean in my tomcat. It uses datasource to connect > to DB. > > My questions is: > > When I create InitialContext() inside MBean's constructor and pass the > envContext to DBManager class

Re: A question regarding using Tomcat

2011-12-20 Thread Konstantin Kolinko
2011/12/20 Mayank Tripathi : > Hi , > > Greetings for the day. > > I've a question about using the tomcat as a TCP server. Given that tomcat > uses basic TCPConnections how can we use it as TCP server?Are there some > settings we need to turn on or given we already have our TCPClient how > tomcat w

Re: [GUMP@vmgump]: Project jakarta-tomcat (in module jakarta-tomcat) failed

2011-12-20 Thread Konstantin Kolinko
This is Tomcat 3.3 (jakarta-tomcat-33.xml in Gump). It is odd that this failed. 2011/12/21 Stefan Bodewig : > To whom it may engage... > > This is an automated request, but not an unsolicited one. For > more information please visit http://gump.apache.org/nagged.html, > and/or contact the folk at

Re: [GUMP@vmgump]: Project jakarta-tomcat (in module jakarta-tomcat) failed

2011-12-21 Thread Konstantin Kolinko
2011/12/21 Mark Thomas : > On 21/12/2011 07:35, Konstantin Kolinko wrote: >> This is Tomcat 3.3 (jakarta-tomcat-33.xml in Gump). >> It is odd that this failed. > > I suspect because the connectors are shared between 3.3.x, 4.1.x and > 5.5.x and r1221282 removed the followi

Re: svn commit: r1222201 - in /tomcat/trunk/webapps/docs/config: filter.xml project.xml

2011-12-22 Thread Konstantin Kolinko
74,10 @@ org.apache.catalina.filters.RequestDumpe >     filter is not so high, because parameter parsing does check content type >     of the request before consuming the request body. > > +    Note, that for the POST requests to be parsed correctly, a > +    SetCharacterEncodingFilter filter must be configure

Re: svn commit: r1222276 - /tomcat/trunk/test/org/apache/catalina/loader/TestVirtualContext.java

2011-12-22 Thread Konstantin Kolinko
2011/12/22 : > Author: markt > Date: Thu Dec 22 15:20:00 2011 > New Revision: 176 > > URL: http://svn.apache.org/viewvc?rev=176&view=rev > Log: > Get test working on Windows > > Modified: >    tomcat/trunk/test/org/apache/catalina/loader/TestVirtualContext.java > > Modified: tomcat/trunk/t

Re: [Tomcat Wiki] Trivial Update of "PoweredBy" by babayaga

2011-12-24 Thread Konstantin Kolinko
tilizes a hotel database system using Tomcat. > > No it doesn't, as evidenced by the main search being via: > /SearchProgress.aspx Those are on different domain, http://holiday.* This one has a lot of PHP (/wp-login.php?action=register etc.), including the PHP session cookie and respon

Re: Time for 5.5.35?

2011-12-25 Thread Konstantin Kolinko
ision&revision=1213470 (JULI build fix) http://svn.apache.org/viewvc?view=revision&revision=1220297 (catalina.policy) http://svn.apache.org/viewvc?view=revision&revision=1224654 (API review) http://svn.apache.org/viewvc?view=revision&revision=1224664 (Parameters) I expect to b

Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2011-12-26 Thread Konstantin Kolinko
ttpRequest1] expected:<0> but was:<1> at org.apache.catalina.mbeans.TestRegistration.testMBeanDeregistration(TestRegistration.java:189) ]]] The NIO test in the same Gump run was OK. The buildbot run for trunk did not observe this (it is just hitting the usual TestCometProcessor stuff). The Gum

Re: svn commit: r1224955 - /tomcat/sandbox/trunk-mvn-build/tomcat-tests/src/test/java/org/apache/catalina/authenticator/TestFormAuthenticator.java

2011-12-27 Thread Konstantin Kolinko
2011/12/27 : > Author: olamy > Date: Tue Dec 27 17:36:19 2011 > New Revision: 1224955 > > URL: http://svn.apache.org/viewvc?rev=1224955&view=rev > Log: > fix path > > Modified: >     > tomcat/sandbox/trunk-mvn-build/tomcat-tests/src/test/java/org/apache/catalina/authenticator/TestFormAuthenticator

Re: svn commit: r1224955 - /tomcat/sandbox/trunk-mvn-build/tomcat-tests/src/test/java/org/apache/catalina/authenticator/TestFormAuthenticator.java

2011-12-27 Thread Konstantin Kolinko
2011/12/27 Olivier Lamy : > 2011/12/27 Konstantin Kolinko : >> 2011/12/27  : >>> Author: olamy >>> Date: Tue Dec 27 17:36:19 2011 >>> New Revision: 1224955 >>> >>> URL: http://svn.apache.org/viewvc?rev=1224955&view=rev >>> Log:

Re: svn commit: r1225000 - /tomcat/trunk/java/org/apache/catalina/authenticator/NonLoginAuthenticator.java

2011-12-27 Thread Konstantin Kolinko
1. I think the AuthenticatoBase#cache flag should be honored. That is: I think session.setPrincipal() should not be called unless the flag is true. I wonder whether we can call AuthenticatoBase#register(), like FormAuthenticator does. The #register() method honors the cache flag, but a problem is

Re: unit test debugging under Netbeans

2011-12-28 Thread Konstantin Kolinko
the jvm debugger and attach the > netbeans nbjpdastart ant task to let the gui control the test. The same as above. > So... can I submit a patch for these three changes to build.xml? I am sure > this will make some of you nervous, but it seems the cleanest approach to > me. > >

Re: Improving wiki security

2011-12-29 Thread Konstantin Kolinko
tion or publications to list there. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [SECURITY] Apache Tomcat and the hashtable collision DoS vulnerability

2011-12-29 Thread Konstantin Kolinko
htable entry. I think Oracle could apply some random seed to that function. For those concerned I would propose to 1. Further lower the parameters count limit to e.g. to 1000, 100 or 20. 2. Configure FailedRequestFilter so that it rejects requests the hit the limit. (So that the limit does not cause

Re: svn commit: r1226069 - /tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java

2011-12-31 Thread Konstantin Kolinko
This commit broke the buildbot and I can reproduce the failures. E.g. TEST-javax.el.TestCompositeELResolver.BIO.txt [[[ java.lang.NullPointerException at org.apache.catalina.startup.Tomcat.silence(Tomcat.java:671) at org.apache.catalina.startup.Tomcat.addWebapp(Tomcat.java:517)

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2011-12-31 Thread Konstantin Kolinko
ll to what test these NPEs belong. I suspect that they occur during shutdown. Best regards, Konstantin Kolinko 2012/1/1 : > The Buildbot has detected a new failure on builder tomcat-trunk while > building ASF Buildbot. > Full details are available at: >  http://ci.apache.org/builde

Re: svn commit: r1226385 - /tomcat/trunk/test/org/apache/catalina/startup/TestWebRuleSet.java

2012-01-02 Thread Konstantin Kolinko
FYI, I am able to reproduce the failures in this test. Using JDK 6u29 32-bit on WinXP. The exceptions are strange. See below. TEST-org.apache.catalina.startup.TestWebRuleSet.BIO.txt @ r1226397 [[[ Testsuite: org.apache.catalina.startup.TestWebRuleSet Tests run: 7, Failures: 4, Errors: 0, Time elap

Re: svn commit: r1226385 - /tomcat/trunk/test/org/apache/catalina/startup/TestWebRuleSet.java

2012-01-02 Thread Konstantin Kolinko
2012/1/2 Mark Thomas : > On 02/01/2012 12:37, Konstantin Kolinko wrote: >> FYI, I am able to reproduce the failures in this test. >> Using JDK 6u29 32-bit on WinXP. > > I can reproduce it running via Ant as well. Investigating now. > In TestWebRuleSet#parse() the

Re: svn commit: r1226385 - /tomcat/trunk/test/org/apache/catalina/startup/TestWebRuleSet.java

2012-01-02 Thread Konstantin Kolinko
2012/1/2 Konstantin Kolinko : > 2012/1/2 Mark Thomas : >> On 02/01/2012 12:37, Konstantin Kolinko wrote: >>> FYI, I am able to reproduce the failures in this test. >>> Using JDK 6u29 32-bit on WinXP. >> >> I can reproduce it running via Ant as well. Inve

Re: svn commit: r1226766 - in /tomcat/site/trunk/docs: ./ stylesheets/

2012-01-03 Thread Konstantin Kolinko
pyright © 1999-2011, The Apache Software Foundation > +        Copyright © 1999-2012, The Apache Software Foundation > Thank you. I did "svn up" on the site, so the changes should be visible in an hour. Best regards, Konstantin Kolinko -

Re: unit test debugging under Netbeans

2012-01-04 Thread Konstantin Kolinko
and are run from there. I was confusing some things. Still the "test-(bio|nio|apr)" targets depend on "deploy" target and that one packs Tomcat classes into jars, along with doing a lot of other stuff. Best regards, Konstantin Kolinko

Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2012-01-05 Thread Konstantin Kolinko
Only one test failed: TEST-org.apache.catalina.mbeans.TestRegistration.BIO.txt.html [[[ Testsuite: org.apache.catalina.mbeans.TestRegistration Tests run: 1, Failures: 1, Errors: 0, Time elapsed: 1.716 sec - Standard Error - Jan 5, 2012 3:36:03 AM org.apache.coyote.Abstr

Re: svn commit: r1226975 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2012-01-05 Thread Konstantin Kolinko
2012/1/5 jean-frederic clere : > On 01/03/2012 11:51 PM, ma...@apache.org wrote: >> >> Correct error in r1666072 > > > Hm sure? > I corrected Mark's log message. Best regards, Konstantin Kolinko -

Re: problem using default Realm in new unit tests

2012-01-05 Thread Konstantin Kolinko
erver.xml file you will note that the element there belongs to Engine. That is why it is started once. When Contexts are created and their context.xml files are parsed, the Contexts always get distinct new Realm instances. Instead of assigning the same Realm instance to both Contexts you s

Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2012-01-07 Thread Konstantin Kolinko
ests. It is somewhere on my TODO list. Access to access log file should be configurable in Gump. I have less expectations for Buildbot (where we do not yet have access to JUnit report files). > [1] > http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/gump_file/TEST-org.apach

Re: svn commit: r1228929 - in /tomcat/trunk: java/org/apache/catalina/connector/Connector.java test/org/apache/catalina/mbeans/TestRegistration.java

2012-01-08 Thread Konstantin Kolinko
type + "-" + ADDRESS + "-" + > port), > +        "Tomcat:type=Mapper,port=" + port + ",address=" > +                + ObjectName.quote(ADDRESS), > +        "Tomcat:type=ProtocolHandler,port=" + port + ",address=" > +

Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2012-01-08 Thread Konstantin Kolinko
like other junit report files that are written in the same directory. I do not plan to change build.properties.default nor ask for a change in Buildbot configuration. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: ant build failing: could not find file modules/jdbc-pool/doc/jdbc-pool.xml to copy

2012-01-08 Thread Konstantin Kolinko
re you guys > using IntelliJ or Eclipse? Most of us are using Eclipse IDE. The building.html page in the docs has some useful instructions (for Eclipse). There are also some useful files in res/ide-support Best regards, Konstantin Kolinko ---

Re: ant build failing: could not find file modules/jdbc-pool/doc/jdbc-pool.xml to copy

2012-01-08 Thread Konstantin Kolinko
149/ Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: ant build failing: could not find file modules/jdbc-pool/doc/jdbc-pool.xml to copy

2012-01-08 Thread Konstantin Kolinko
ess it was just > initially to write to that folder). > > Anyhow, I'll try the svn then thanks. > > On Sun, Jan 8, 2012 at 5:52 PM, Konstantin Kolinko > wrote: > >> 2012/1/9 S Ahmed : >> > 2. sudo ant >> >> Just curious regarding the above comman

Re: problem using default Realm in new unit tests

2012-01-09 Thread Konstantin Kolinko
2012/1/9 Brian Burch : > On 06/01/12 11:47, Konstantin Kolinko wrote: >> >> 2012/1/6 Brian Burch: >>> >>> I am developing some new unit tests to validate SingleSignOn and >>> Authenticator logic. I have us

Re: VERIFIED status in Bugzilla (was: [Bug 41697]...)

2012-01-09 Thread Konstantin Kolinko
age.cgi?id=fields.html#status I think there is no much sense in having VERIFIED bugs in our weekly reports, but it is just a reminder that they have to be promoted to CLOSED, like Mark did. Best regards, Konstantin Kolinko - To un

Re: unit test debugging under Netbeans

2012-01-09 Thread Konstantin Kolinko
2012/1/5 Konstantin Kolinko : > 2011/12/30 Brian Burch : >>> >>> Formatter is configurable since 7.0.24. >> >> >> Silly me! A ${test.formatter} property is defined immediately after >> ${test.name}! The test.formatte

Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2012-01-09 Thread Konstantin Kolinko
2012/1/9 Konstantin Kolinko : >>> 2012/1/7 Rainer Jung : >>>> >>>> Maybe enable the accesslog during testing with test.accesslog=true, so one >>>> can check after the next failure whether the contents agree with your >>>> assumption. N

Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2012-01-09 Thread Konstantin Kolinko
2012/1/10 Konstantin Kolinko : > 2012/1/9 Konstantin Kolinko : >>>> 2012/1/7 Rainer Jung : >>>>> >>>>> Maybe enable the accesslog during testing with test.accesslog=true, so one >>>>> can check after the next failure whether the conte

Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2012-01-10 Thread Konstantin Kolinko
2012/1/10 Rainer Jung : > On 10.01.2012 05:27, Konstantin Kolinko wrote: >> >> 2012/1/10 Konstantin Kolinko: >>> >>> 2012/1/9 Konstantin Kolinko: >>>>>> >>>>>> 2012/1/7 Rainer Jung: >>>>>>> >>

Re: Release 2.0-beta-1 of Tomcat Maven Plugin

2012-01-10 Thread Konstantin Kolinko
ently. [1] http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/Tomcat7Runner.java?view=markup [2] http://thedailywtf.com/Articles/Serious-Failure.aspx Best regards, Konstantin Kolinko ---

Re: More Caching for WebappClassLoader?

2012-01-10 Thread Konstantin Kolinko
reject requests for classes that it cannot load. While we are talking about classloaders - there is one more patch in Bugzilla, https://issues.apache.org/bugzilla/show_bug.cgi?id=48903#c6 that tries to use some jdk7 feature to improve classloader locking. I do not plan to look at it

Re: svn commit: r1230955 - /tomcat/trunk/java/org/apache/catalina/realm/NullRealm.java

2012-01-13 Thread Konstantin Kolinko
orrected svn:eol-style. One small thing that is left is to mention this new realm in config/realm.html Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1231341 - in /tomcat/trunk/modules/jdbc-pool: pom.xml src/test/java/org/apache/tomcat/jdbc/test/PoolCleanerTest.java

2012-01-13 Thread Konstantin Kolinko
at/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/PoolCleanerTest.java I wonder that this issue (and the one fixed in r1231339 ) were not noticed by our checkstyle configuration. I noticed them while reviewing RAT report form buil

Re: svn commit: r1183612 [2/2] - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

2012-01-13 Thread Konstantin Kolinko
t; - *      http://www.apache.org/licenses/LICENSE-2.0 >> - * >> - * Unless required by applicable law or agreed to in writing, software >> - * distributed under the License is distributed on an "AS IS" BASIS, >> - * WITHOUT WARRANTIES OR CONDITIONS OF AN

Re: svn commit: r1231550 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/authenticator/TestNonLoginAndBasicAuthenticator.java

2012-01-14 Thread Konstantin Kolinko
ments" warning. In doTestNonLogin() method the pwd and user are not used at all, so Mark removed them from arguments. In doTestBasic() method you used the constants (USER, PWD) instead of actual method arguments. While reviewing this I corrected two small issues in http://svn.apache.org/vi

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2012-01-14 Thread Konstantin Kolinko
[junit] remoteAddr: 127.0.0.1 ]]] So, it has remoteAddr, but it looks like nothing was received. The requestProcessingTime value of 1326605233578 gives xx:27:13 (disrespecting my different timezone), so it occurred in the same second. BTW, last Gump failure was due to two

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2012-01-15 Thread Konstantin Kolinko
2012/1/15 Mark Thomas : > On 15/01/2012 06:06, Konstantin Kolinko wrote: >> 2012/1/15  : >>> The Buildbot has detected a new failure on builder tomcat-trunk while >>> building ASF Buildbot. >>> Full details are available at: >>>  http://ci

Re: svn commit: r1230765 - in /tomcat/trunk/java/org/apache/catalina/core: ContainerBase.java StandardContext.java

2012-01-15 Thread Konstantin Kolinko
2012/1/13 : > Author: markt > Date: Thu Jan 12 20:34:24 2012 > New Revision: 1230765 > > URL: http://svn.apache.org/viewvc?rev=1230765&view=rev > Log: > Move destruction of ContainerBase objects to ContainerBase to ensure > that they are destroyed. > > Modified: >    tomcat/trunk/java/org/apache/c

Re: [VOTE] Release Apache Tomcat 7.0.24

2012-01-15 Thread Konstantin Kolinko
files to Nexus? It should be easier to prepare everything while vote goes. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1231762 - in /tomcat/trunk: java/org/apache/catalina/manager/JMXProxyServlet.java webapps/docs/manager-howto.xml

2012-01-15 Thread Konstantin Kolinko
=1231762&view=diff > == > --- tomcat/trunk/webapps/docs/manager-howto.xml (original) > +++ tomcat/trunk/webapps/docs/manager-howto.xml Sun Jan 15 21:37:18 2012 > @@ -1301,6 +1301,18 @@ Error: java.lang.Numbe

Re: Nexus release problems

2012-01-16 Thread Konstantin Kolinko
te them "before closing staging area". Others [2] (an older thread but seems more reliable) say that only after closing it. [1] http://markmail.org/message/tebuldnggk3pepky [2] http://markmail.org/thread/uqjxxvpgztrlg362 Best regards, Konstantin Kolinko -

Re: svn commit: r1231923 - in /tomcat/trunk: build.properties.default build.xml

2012-01-16 Thread Konstantin Kolinko
How to avoid being asked for passphrase if 1. I do not have gpg installed 2. Do not want to generate asc files It seems that buildbot also has problem with this. Maybe check that "gpg.exec" points to an existing executable. 2012/1/16 : > Author: markt > Date: Mon Jan 16 11:11:11 2012 > New Rev

Re: [VOTE] Release Apache Tomcat 7.0.24

2012-01-16 Thread Konstantin Kolinko
when Sylvain removed that line from ".gitignore" and used that name in his commit. I am generally in favor of using more targeted patterns in "dist-source" target, (That is, comment out "**/target/**" for n

Re: svn commit: r1080719 - in /tomcat/trunk: java/org/apache/catalina/startup/ContextConfig.java webapps/docs/changelog.xml

2012-01-16 Thread Konstantin Kolinko
; >>>> URL: http://svn.apache.org/viewvc?rev=1080719&view=rev >>>> Log: >>>> Don't unpack WAR files if they are not located in the Host's appBase. >> I do not mind if someone reimplemented the feature, but keeping it off by default, That is like we

Re: [VOTE] Release Apache Tomcat 7.0.25

2012-01-18 Thread Konstantin Kolinko
22.0) on 32-bit WinXP JDK 6u29. Tested standard applications running with Security Manager enabled, deployment, undeployment and did not observe any problems. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsub

Re: svn commit: r1232843 - /tomcat/trunk/java/org/apache/catalina/loader/WebappLoader.java

2012-01-18 Thread Konstantin Kolinko
(In the opposite way the conversion would be done via file.toURI().toURL().toExternalForm() ) Best regards, Konstantin Kolinko > > Modified: >    tomcat/trunk/java/org/apache/catalina/loader/WebappLoader.java > > Modified: tomcat/trunk/java/org/apache/catalina/loader/WebappLoader

Re: Detecting failures of unit tests

2012-01-18 Thread Konstantin Kolinko
re Tomcat shutdown was failing (generating messages), but JUnit tests were not failing. Maybe that is because of different threads. I do not know how improve that. I personally always review results and stdout for "NullPointerException". NPEs are unexpected. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2012-01-19 Thread Konstantin Kolinko
files are still there. I'll add a command to delete those files to our build.xml, and will revert the change once Gump is fixed. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2012-01-21 Thread Konstantin Kolinko
2012/1/19 Konstantin Kolinko : > 2012/1/19 Bill Barker : >> To whom it may engage... >> >> This is an automated request, but not an unsolicited one. For >> more information please visit http://gump.apache.org/nagged.html, >> and/or contact the folk at gene...@gump

Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2012-01-24 Thread Konstantin Kolinko
: org.apache.coyote.RequestGroupInfo@1dfd868 serverPort: -1 bytesReceived: 0 requestCount: 0 requestBytesSent: 0 contentLength: -1 - --- I thought we fixed this. It may be worth a second look. Best regards, Konstantin Kolinko --

Re: [ANN] Process has changed for distributing releases

2012-01-24 Thread Konstantin Kolinko
t.apache.org/repos/dist/dev/tomcat/ > Thank you for clarification. One question: how old releases are handled? Those that should be removed from mirrors, but are kept in the archive. Is the procedure to just "svn remove" them from this repository? Best regards, Konstantin Kolinko --

Re: svn commit: r1237428 - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

2012-01-29 Thread Konstantin Kolinko
pache/catalina/startup/mbeans-descriptors.xml?view=markup Best regards, Konstantin Kolinko > > Modified: tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java > URL: > http://svn.apache.org/viewvc/tomcat/trunk/java/org/ap

Re: Revision number fun: r1234567

2012-01-31 Thread Konstantin Kolinko
nes >> >> Better handling when MBean ops return null. >> Patch by kkolinko >> > > https://twitter.com/#!/TheASF/status/164398458235654146 Tha

Re: [VOTE] Apache Tomcat Maven plugin 2.0-beta-1

2012-01-31 Thread Konstantin Kolinko
> [-1] > Where are downloadable artifacts that will be placed to the ASF mirror system? Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1239256 - /tomcat/trunk/java/org/apache/catalina/Globals.java

2012-02-01 Thread Konstantin Kolinko
2012/2/1 : > Author: markt > Date: Wed Feb  1 18:42:58 2012 > New Revision: 1239256 > > URL: http://svn.apache.org/viewvc?rev=1239256&view=rev > Log: > Deprecate unused constants Please check first whether the string values of those constants are used or not! TOMCAT_CONNECTOR_ATTR_PREFIX (and so

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2012-02-01 Thread Konstantin Kolinko
build.xml or annotate it with @Ignored? Best regards, Konstantin Kolinko 2012/2/1 : > The Buildbot has detected a new failure on builder tomcat-trunk while > building ASF Buildbot. > Full details are available at: >  http://ci.apache.org/builders/tomcat-trunk/builds/2691 > >

Re: POST data (single character) cleared when using tomcat 6.0.33 and Character Encoding Filter

2012-02-02 Thread Konstantin Kolinko
s Charset in 5.5.35 and 6.0.35 is part of fix for CVE-2012-0022 [2] So a different implementation might be needed. [1] http://svn.apache.org/viewvc?view=revision&revision=1140904 [2] http://tomcat.apache.org/security.html The good news are that it does not affect UTF-8, so using that encodin

Re: POST data (single character) cleared when using tomcat 6.0.33 and Character Encoding Filter

2012-02-02 Thread Konstantin Kolinko
2012/2/2 Mark Thomas : > On 02/02/2012 11:25, Konstantin Kolinko wrote: >> cc: dev >> >> 2012/1/23 kitagawa : >>>> >>>> While developing using ubuntu 11.04, tomcat 6.0.33 and java 1.5 I ran >>>> into a problem after setting the charact

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2012-02-02 Thread Konstantin Kolinko
) at org.apache.catalina.startup.Tomcat.getService(Tomcat.java:412) at org.apache.catalina.startup.TomcatBaseTest.setUp(TomcatBaseTest.java:108) Best regards, Konstantin Kolinko 2012/2/2 : > The Buildbot has detected a new failure on builder tomcat-trunk while > buildi

Re: svn commit: r1239522 - in /tomcat/trunk/java/org/apache/catalina: Server.java core/ContainerBase.java core/StandardEngine.java core/StandardServer.java mbeans/MBeanFactory.java startup/Tomcat.java

2012-02-02 Thread Konstantin Kolinko
it is OK to convert to canonical form unconditionally, though it is slight change in behaviour. Best regards, Konstantin Kolinko > Modified: tomcat/trunk/java/org/apache/catalina/Server.java > URL: > http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/Server.java?rev=1239522&am

Re: svn commit: r1240105 - in /tomcat/trunk/java/org/apache/catalina: Container.java core/ContainerBase.java core/StandardHost.java deploy/NamingResources.java mbeans/MBeanUtils.java realm/RealmBase.j

2012-02-03 Thread Konstantin Kolinko
2012/2/3 : > Author: markt > Date: Fri Feb  3 12:08:09 2012 > New Revision: 1240105 > > URL: http://svn.apache.org/viewvc?rev=1240105&view=rev > Log: > Refactor to remove some circular dependencies > > Modified: >    tomcat/trunk/java/org/apache/catalina/Container.java >    tomcat/trunk/java/org/a

Re: svn commit: r1240105 - in /tomcat/trunk/java/org/apache/catalina: Container.java core/ContainerBase.java core/StandardHost.java deploy/NamingResources.java mbeans/MBeanUtils.java realm/RealmBase.j

2012-02-03 Thread Konstantin Kolinko
2012/2/3 Mark Thomas : > On 03/02/2012 12:19, Konstantin Kolinko wrote: >> 2012/2/3  : >>> +    @Override >>> +    public String getMBeanKeyProperties() { >>> +        Container c = this; >>> +        StringBuilder keyProperties = new StringB

catalina.home, catalina.base properties in Tomcat 8

2012-02-03 Thread Konstantin Kolinko
rver.xml that will set those two system properties when Tomcat starts. That is relevant only if we go on with removing those properties. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.or

Re: catalina.home, catalina.base properties in Tomcat 8

2012-02-03 Thread Konstantin Kolinko
2012/2/3 Mark Thomas : >> >> That is relevant only if we go on with removing those properties. > > The simplest solution is looking very much like restoring the update of > these two system properties after the (now consistent) processing. > +1. Best reg

Re: svn commit: r1240330 - in /tomcat/trunk/java/org/apache/catalina: JmxEnabled.java mbeans/MBeanFactory.java util/LifecycleMBeanBase.java

2012-02-03 Thread Konstantin Kolinko
2012/2/4 : > Author: markt > Date: Fri Feb  3 20:09:51 2012 > New Revision: 1240330 > > URL: http://svn.apache.org/viewvc?rev=1240330&view=rev > Log: > Add new interface to indicate JMX support and start to use it > > Added: >    tomcat/trunk/java/org/apache/catalina/JmxEnabled.java svn:eol-style

Re: svn commit: r1241441 - in /tomcat/trunk/java/org/apache/coyote: ./ ajp/ http11/ http11/upgrade/

2012-02-07 Thread Konstantin Kolinko
rocessor.java >    tomcat/trunk/java/org/apache/coyote/http11/upgrade/UpgradeNioProcessor.java >    tomcat/trunk/java/org/apache/coyote/http11/upgrade/UpgradeProcessor.java > (...) Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1242374 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/juli/logging/ java/org/apache/tomcat/util/http/ java/org/apache/tomcat/util/log/ webapps/docs/

2012-02-09 Thread Konstantin Kolinko
odName(); >             } > -            if (cname == null) { > -                cname = "unknown"; > -                method = "unknown"; > -            } > - >             if (ex==null) { >                 logger.logp(level, cname, method, msg); >             } else { > (...) Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Misconfigured Git-SVN once again

2012-02-09 Thread Konstantin Kolinko
r.java M trunk\java\org\apache\coyote\http11\upgrade\UpgradeAprProcessor.java M trunk\java\org\apache\coyote\http11\upgrade\UpgradeNioProcessor.java M trunk\webapps\examples\websocket\index.html Best regards, Konstantin Kolinko -

Re: Misconfigured Git-SVN once again

2012-02-09 Thread Konstantin Kolinko
2012/2/10 Konstantin Kolinko : > Hi! > > Some recent Mark's commits once again caused several new files to have > wrong line ends at the server side. > > This is a technical issue where the "pristine" texts for the files > that have svn:eol-style=native propert

Re: Custom rules for commons-digester

2012-02-13 Thread Konstantin Kolinko
to have source-based > rules instead of configuration-based rules? They are faster. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Custom rules for commons-digester

2012-02-13 Thread Konstantin Kolinko
2012/2/14 Christopher Schultz : > Konstantin, > > On 2/13/12 4:32 PM, Konstantin Kolinko wrote: >> 2012/2/14 Christopher Schultz : >>> All, >>> >>> There are 15 or so custom rule classes in the Tomcat sources for >>> handling various commons-dige

JNDIRealm performance

2012-02-14 Thread Konstantin Kolinko
ng, so using HTTPD in front of Tomcat might be a workaround for JNDIRealm performance issues. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: AccessLogValve enhancement

2012-02-15 Thread Konstantin Kolinko
;logCategory" as I would name it) feature, I think it does not belong to the current AccessLogValve but you might plug it there after some refactoring. Anyway I would like to see the whole picture, which includes the logging configuration that you would use with AccessLogValve.

Re: svn commit: r1244574 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/el/lang/ELSupport.java test/org/apache/el/lang/TestELSupport.java webapps/docs/changelog.xml

2012-02-16 Thread Konstantin Kolinko
The code itself is OK. It is not an issue for 6.0, because Javadoc for these methods is essentially empty there. I plan to look into fixing this later, but anyone can beat me over it. Best regards, Konstantin Kolinko > Modified: tomcat/tc7.0.x/trunk/java/org/apache/el/lang/ELSupport.java > U

Re: AccessLogValve enhancement

2012-02-16 Thread Konstantin Kolinko
2012/2/17 Mark Claassen : > I attached the two new valves in a zip file, Do not send attachments to this mailing list ever! The proper procedure is documented here: http://tomcat.apache.org/bugreport.html#How_to_submit_patches_and_enhancement_requests Best regards, Konstantin Koli

Re: svn commit: r1244737 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/startup/ContextConfig.java java/org/apache/catalina/startup/LocalStrings.properties webapps/docs/changelog.xml

2012-02-16 Thread Konstantin Kolinko
"contextConfig.webinfClassesUrl"), e); 1262 } Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1243655 - in /tomcat/trunk/modules/jdbc-pool/src: main/java/org/apache/tomcat/jdbc/pool/interceptor/ test/java/org/apache/tomcat/jdbc/bugs/ test/java/org/apache/tomcat/jdbc/pool/inter

2012-02-16 Thread Konstantin Kolinko
d rely on SecureRandom. Just a Random should be enough. BTW, s/static/static final/ Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [GUMP@vmgump]: Project tomcat-trunk-validate-eoln (in module tomcat-trunk) failed

2012-02-17 Thread Konstantin Kolinko
vn.apache.org/viewvc/gump/metadata/workspace.xml?view=markup#l39 [2] http://ant.apache.org/manual/sysclasspath.html I did not expect that Ant had such a feature. I'll fix the broken build. Best regards, Konstantin Kolinko ---

<    1   2   3   4   5   6   7   8   9   10   >