markt-asf commented on issue #141: Update BUILDING and CONTRIBUTING docs after
the svn->git migration.
URL: https://github.com/apache/tomcat/pull/141#issuecomment-468806277
Test ping.
This is an automated message from the Apa
csutherl commented on issue #141: Update BUILDING and CONTRIBUTING docs after
the svn->git migration.
URL: https://github.com/apache/tomcat/pull/141#issuecomment-468824644
Do we want to accept this commit so that the docs mostly reflect our current
state and fire off a discussion re: `svn:
markt-asf commented on issue #141: Update BUILDING and CONTRIBUTING docs after
the svn->git migration.
URL: https://github.com/apache/tomcat/pull/141#issuecomment-468826081
+1
This is an automated message from the Apache Git
toby1984 commented on issue #140: jdbc-pool: Improve maxAge handling
URL: https://github.com/apache/tomcat/pull/140#issuecomment-469229642
Could you please elaborate what you meant by your reference to the "maxIdle"
and "initialSize" options ? How do they relate to the "maxAge" one in your
rmaucher commented on issue #140: jdbc-pool: Improve maxAge handling
URL: https://github.com/apache/tomcat/pull/140#issuecomment-469260446
I think maxAge is ok, but then the pool should indeed have at least minIdle.
Basically, if you have 0 active, then you have at least minIdle, that sound
csutherl merged pull request #141: Update BUILDING and CONTRIBUTING docs after
the svn->git migration.
URL: https://github.com/apache/tomcat/pull/141
This is an automated message from the Apache Git Service.
To respond to th
csutherl commented on issue #141: Update BUILDING and CONTRIBUTING docs after
the svn->git migration.
URL: https://github.com/apache/tomcat/pull/141#issuecomment-469688472
I've accepted the PR and will follow up on the dev@ list with a discussion
on an `svn:eol-style` equivalent.
philwebb opened a new pull request #142: Defer creation of
encodingToCharsetCache
URL: https://github.com/apache/tomcat/pull/142
Defer creation of `encodingToCharsetCache` until absolutely necessary
and update `B2CConverter.getCharset` to first attempt a direct lookup
using `Charset.f
philwebb opened a new pull request #143: Apply deduplication to certain loaded
and created Strings
URL: https://github.com/apache/tomcat/pull/143
Apply deduplication to certain loaded and created Strings by using
a static Map. This applies the same technique as described in
https://sh
rmaucher commented on issue #142: Defer creation of encodingToCharsetCache
URL: https://github.com/apache/tomcat/pull/142#issuecomment-470022349
If there is a lookup with Charset.forName, then would the cache be used at
all ? I don't understand this sort of Windows style "startup time"
opt
rmaucher commented on issue #143: Apply deduplication to certain loaded and
created Strings
URL: https://github.com/apache/tomcat/pull/143#issuecomment-470022913
Can you give a metric of actual memory gains made using this change ? Adding
complexity for very little benefit doesn't seem lik
y987425112 opened a new pull request #144: Variable adds final modifier
URL: https://github.com/apache/tomcat/pull/144
If these variables do not add final modifiers, there will be ambiguity and
security risks.
This is an au
markt-asf commented on issue #144: Variable adds final modifier
URL: https://github.com/apache/tomcat/pull/144#issuecomment-470050541
Potential security vulnerabilities should be reported privately to
secur...@tomcat.apache.org. Not in a PR or any other public forum.
That said, th
rmaucher commented on issue #144: Variable adds final modifier
URL: https://github.com/apache/tomcat/pull/144#issuecomment-470054183
That's a very useful reminder for me, if a PR is pulled, it *also* needs to
have a decent description as well, otherwise misleading information gets into
t
y987425112 commented on issue #144: Variable adds final modifier
URL: https://github.com/apache/tomcat/pull/144#issuecomment-470055949
I am very sorry, this is the first time I submit the code, because I am
Chinese, my English is a little poor, there are errors in the description.
Thank
y987425112 closed pull request #144: Variable adds final modifier
URL: https://github.com/apache/tomcat/pull/144
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
philwebb commented on issue #143: Apply deduplication to certain loaded and
created Strings
URL: https://github.com/apache/tomcat/pull/143#issuecomment-470145284
Sure. I discovered these by using the "Inspections" feature from
[YourKit](https://www.yourkit.com/) on an [embedded Tomcat
app
ChristopherSchultz commented on issue #143: Apply deduplication to certain
loaded and created Strings
URL: https://github.com/apache/tomcat/pull/143#issuecomment-470156059
I like the idea, but I think. the implementation could be better. For
instance:
1. There is no need to have tw
ChristopherSchultz edited a comment on issue #143: Apply deduplication to
certain loaded and created Strings
URL: https://github.com/apache/tomcat/pull/143#issuecomment-470156059
I like the idea, but I think the implementation could be better. For
instance:
1. There is no need to h
rmaucher commented on issue #143: Apply deduplication to certain loaded and
created Strings
URL: https://github.com/apache/tomcat/pull/143#issuecomment-470157903
Ok, I'm not sure it is a very significant saving overall (probably not), but
it's still more than I expected.
Yes, +1for
philwebb commented on issue #143: Apply deduplication to certain loaded and
created Strings
URL: https://github.com/apache/tomcat/pull/143#issuecomment-470210052
The other option would be to use `String.intern` for these limited cases.
Either way, I'm happy to rework the PR if you have a s
ChristopherSchultz commented on issue #143: Apply deduplication to certain
loaded and created Strings
URL: https://github.com/apache/tomcat/pull/143#issuecomment-470265906
Good point: String.intern is already implemented, and it's already "weak".
Less code, same result = better.
-
philwebb commented on issue #142: Defer creation of encodingToCharsetCache
URL: https://github.com/apache/tomcat/pull/142#issuecomment-470280939
I've pushed an update following the discussion on
https://bz.apache.org/bugzilla/show_bug.cgi?id=63235
@rmaucher
> If there is a lo
philwebb commented on issue #142: Defer creation of encodingToCharsetCache
URL: https://github.com/apache/tomcat/pull/142#issuecomment-470317822
I've pushed another update now that I know about
https://bz.apache.org/bugzilla/show_bug.cgi?id=51400
---
philwebb commented on issue #143: Apply deduplication to certain loaded and
created Strings
URL: https://github.com/apache/tomcat/pull/143#issuecomment-470381178
I've pushed an update that uses `String.intern` for those two places. With
this change 2192 duplicates are reduced to 300 and I'
rmannibucau commented on issue #143: Apply deduplication to certain loaded and
created Strings
URL: https://github.com/apache/tomcat/pull/143#issuecomment-470392703
Is generating a java class at build time instead of reading the xml
possible? Then a preregistration in a registry would enab
rmaucher commented on issue #142: Defer creation of encodingToCharsetCache
URL: https://github.com/apache/tomcat/pull/142#issuecomment-470434736
Besides the 31ms startup time, it's still worse in every way compared to the
current code.
--
y987425112 opened a new pull request #145: Adding volatile keywords to member
variables
URL: https://github.com/apache/tomcat/pull/145
The semantics of the Java programming language allow compilers and
microprocessors to
perform optimizations that can interact with incorrectly synchroni
rainerjung commented on issue #145: Adding volatile keywords to member variables
URL: https://github.com/apache/tomcat/pull/145#issuecomment-470482121
My understanding always was, that reordering must obey as-if-serial
semantics for any single thread. The complexity only kicks in when check
y987425112 commented on issue #145: Adding volatile keywords to member variables
URL: https://github.com/apache/tomcat/pull/145#issuecomment-470488340
`package com.ydy.thread.volatile2;
public class VolatileTest {
public static void main(String[] args) throws Exception {
y987425112 removed a comment on issue #145: Adding volatile keywords to member
variables
URL: https://github.com/apache/tomcat/pull/145#issuecomment-470488340
`package com.ydy.thread.volatile2;
public class VolatileTest {
public static void main(String[] args) throws Exceptio
y987425112 commented on issue #145: Adding volatile keywords to member variables
URL: https://github.com/apache/tomcat/pull/145#issuecomment-470488862
```
package com.ydy.thread.volatile2;
public class VolatileTest {
public static void main(String[] args) throws Exception {
y987425112 removed a comment on issue #145: Adding volatile keywords to member
variables
URL: https://github.com/apache/tomcat/pull/145#issuecomment-470488862
```
package com.ydy.thread.volatile2;
public class VolatileTest {
public static void main(String[] args) throws Ex
y987425112 commented on issue #145: Adding volatile keywords to member variables
URL: https://github.com/apache/tomcat/pull/145#issuecomment-470489493
```
package com.ydy.thread.volatile2;
public class VolatileTest {
public static void main(String[] args) throws Exception {
rainerjung commented on issue #145: Adding volatile keywords to member variables
URL: https://github.com/apache/tomcat/pull/145#issuecomment-470501897
Yes of course, because the threads do not oby to the rules I have described.
From my comment: "Changes done by thread T1 while holding any l
markt-asf commented on issue #145: Adding volatile keywords to member variables
URL: https://github.com/apache/tomcat/pull/145#issuecomment-470502673
The claims made above are incorrect. They fail to take account of the
requirement that
> However, compilers are allowed to reorder th
markt-asf closed pull request #145: Adding volatile keywords to member variables
URL: https://github.com/apache/tomcat/pull/145
This is an automated message from the Apache Git Service.
To respond to the message, please log o
y987425112 commented on issue #145: Adding volatile keywords to member variables
URL: https://github.com/apache/tomcat/pull/145#issuecomment-470503719
package com.ydy.thread.volatile2;
public class VolatileTest2 {
public static void main(String[] args) {
Task t
y987425112 removed a comment on issue #145: Adding volatile keywords to member
variables
URL: https://github.com/apache/tomcat/pull/145#issuecomment-470503719
package com.ydy.thread.volatile2;
public class VolatileTest2 {
public static void main(String[] args) {
y987425112 commented on issue #145: Adding volatile keywords to member variables
URL: https://github.com/apache/tomcat/pull/145#issuecomment-470504073
```
package com.ydy.thread.volatile2;
public class VolatileTest2 {
public static void main(String[] args) {
philwebb commented on issue #142: Defer creation of encodingToCharsetCache
URL: https://github.com/apache/tomcat/pull/142#issuecomment-470546205
> Besides the 31ms startup time, it's still worse in every way compared to
the current code.
I'm really not sure what I'm supposed to do wi
rmaucher commented on issue #142: Defer creation of encodingToCharsetCache
URL: https://github.com/apache/tomcat/pull/142#issuecomment-470602748
You submitted three items, and indeed I am not convinced by this one.
Looking back to the old BZs, there was also there the conclusion that the
c
markt-asf commented on issue #142: Defer creation of encodingToCharsetCache
URL: https://github.com/apache/tomcat/pull/142#issuecomment-470607054
No. Not an system property ;).
Seriously, I think there is a way that we can improve start-up time without
impacting the vast majority
markt-asf closed pull request #143: Apply deduplication to certain loaded and
created Strings
URL: https://github.com/apache/tomcat/pull/143
This is an automated message from the Apache Git Service.
To respond to the message
markt-asf commented on issue #143: Apply deduplication to certain loaded and
created Strings
URL: https://github.com/apache/tomcat/pull/143#issuecomment-470662734
I've been running YourKit with allocation tracking enabled and tracking each
of the duplicated strings to the root cause. I sta
philwebb commented on issue #143: Apply deduplication to certain loaded and
created Strings
URL: https://github.com/apache/tomcat/pull/143#issuecomment-470667817
@rmannibucau I've opened another issue for that
https://bz.apache.org/bugzilla/show_bug.cgi?id=63237. If I get a second I'll
tr
philwebb commented on issue #143: Apply deduplication to certain loaded and
created Strings
URL: https://github.com/apache/tomcat/pull/143#issuecomment-470668078
@markt-asf Thanks Mark!
This is an automated message from the A
markt-asf opened a new pull request #146: Fix
https://bz.apache.org/bugzilla/show_bug.cgi?id=63235
URL: https://github.com/apache/tomcat/pull/146
Implement an alternative Charset caching strategy that does not load all
Charsets at Tomcat start. This reduces start time by ~30ms and does n
markt-asf commented on issue #142: Defer creation of encodingToCharsetCache
URL: https://github.com/apache/tomcat/pull/142#issuecomment-471072264
See #146 for an alternative approach
This is an automated message from the Apach
rmaucher commented on issue #146: Fix
https://bz.apache.org/bugzilla/show_bug.cgi?id=63235
URL: https://github.com/apache/tomcat/pull/146#issuecomment-471178688
Ok I guess. Wasn't the plan going to include hardcoding UTF-8 ?
The previous code still looks better to me (HashMap vs concurre
markt-asf commented on issue #146: Fix
https://bz.apache.org/bugzilla/show_bug.cgi?id=63235
URL: https://github.com/apache/tomcat/pull/146#issuecomment-471181388
Thanks for taking a look at the code.
I was concerned about the HashMap vs ConcurrentHashMap as well but in the
tests inc
toby1984 commented on issue #140: jdbc-pool: Improve maxAge handling
URL: https://github.com/apache/tomcat/pull/140#issuecomment-471474038
Sorry for not getting back any earlier. I did not touch the existing code
responsible for discarding idle connections or the creation of new connections
herrlock opened a new pull request #147: Fix typo in german translation
URL: https://github.com/apache/tomcat/pull/147
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
michael-o commented on issue #147: Fix typo in german translation
URL: https://github.com/apache/tomcat/pull/147#issuecomment-472068105
Thanks for the PR. Looking at the file makes me consider to delete this file
altogether. Is is full of typos.
michael-o edited a comment on issue #147: Fix typo in german translation
URL: https://github.com/apache/tomcat/pull/147#issuecomment-472068105
Thanks for the PR. Looking at the file makes me consider to delete this file
altogether. It is full of typos.
-
markt-asf closed pull request #147: Fix typo in german translation
URL: https://github.com/apache/tomcat/pull/147
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
markt-asf commented on issue #147: Fix typo in german translation
URL: https://github.com/apache/tomcat/pull/147#issuecomment-472129702
Please provide updates to the translations via:
https://poeditor.com/projects/view?id=221603
---
philwebb closed pull request #142: Defer creation of encodingToCharsetCache
URL: https://github.com/apache/tomcat/pull/142
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
philwebb commented on issue #142: Defer creation of encodingToCharsetCache
URL: https://github.com/apache/tomcat/pull/142#issuecomment-472141038
Closing in favor of #146. Thanks @markt-asf!
This is an automated message from t
samslow opened a new pull request #148: Remove duplicated comments
URL: https://github.com/apache/tomcat/pull/148
Signed-off-by: samslow
I don't know why this comments is here.
If there is a reason why the comment is here and I do not know, Abort this
PR and Teach me if you c
KeiichiFujino commented on issue #140: jdbc-pool: Improve maxAge handling
URL: https://github.com/apache/tomcat/pull/140#issuecomment-472779046
If testOnConnect is true or initSQL is set, we need validate the connection(
with VALIDATE_INIT) when reconnecting.
--
toby1984 commented on issue #140: jdbc-pool: Improve maxAge handling
URL: https://github.com/apache/tomcat/pull/140#issuecomment-472791041
Good catch, I will fix this.
This is an automated message from the Apache Git Service.
wilkinsona commented on issue #146: Fix
https://bz.apache.org/bugzilla/show_bug.cgi?id=63235
URL: https://github.com/apache/tomcat/pull/146#issuecomment-472829112
In addition to the improved startup time, this change has an even bigger
positive impact on Tomcat's memory footprint. With the
wilkinsona edited a comment on issue #146: Fix
https://bz.apache.org/bugzilla/show_bug.cgi?id=63235
URL: https://github.com/apache/tomcat/pull/146#issuecomment-472829112
In addition to the improved startup time, this change has an even bigger
positive impact on Tomcat's memory footprint. W
markt-asf merged pull request #146: Fix
https://bz.apache.org/bugzilla/show_bug.cgi?id=63235
URL: https://github.com/apache/tomcat/pull/146
This is an automated message from the Apache Git Service.
To respond to the message,
nightwatchcyber opened a new pull request #138: Expanding SSI documentation
(bug # 63184)
URL: https://github.com/apache/tomcat/pull/138
Fixing:
https://bz.apache.org/bugzilla/show_bug.cgi?id=63184
This is an automated mes
markt-asf commented on issue #138: Expanding SSI documentation (bug # 63184)
URL: https://github.com/apache/tomcat/pull/138#issuecomment-472856732
Close unintentionally during svn->git migration.
This is an automated message f
toby1984 commented on issue #140: jdbc-pool: Improve maxAge handling
URL: https://github.com/apache/tomcat/pull/140#issuecomment-473018240
I fixed the missing calls to PooledConnection#validate(int).
While reading the code I was kind of unsure whether I should call
PooledConnection#
markt-asf commented on issue #148: Remove duplicated comments
URL: https://github.com/apache/tomcat/pull/148#issuecomment-473021367
No reason. It looks like a leftover from the last major redesign.
This is an automated message
markt-asf merged pull request #148: Remove duplicated comments
URL: https://github.com/apache/tomcat/pull/148
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
markt-asf commented on a change in pull request #138: Expanding SSI
documentation (bug # 63184)
URL: https://github.com/apache/tomcat/pull/138#discussion_r265735282
##
File path: webapps/docs/ssi-howto.xml
##
@@ -146,27 +146,53 @@ false.
The directives are:
-config -
markt-asf commented on a change in pull request #138: Expanding SSI
documentation (bug # 63184)
URL: https://github.com/apache/tomcat/pull/138#discussion_r265734162
##
File path: webapps/docs/ssi-howto.xml
##
@@ -146,27 +146,53 @@ false.
The directives are:
-config -
markt-asf commented on a change in pull request #138: Expanding SSI
documentation (bug # 63184)
URL: https://github.com/apache/tomcat/pull/138#discussion_r265734995
##
File path: webapps/docs/ssi-howto.xml
##
@@ -146,27 +146,53 @@ false.
The directives are:
-config -
markt-asf commented on a change in pull request #138: Expanding SSI
documentation (bug # 63184)
URL: https://github.com/apache/tomcat/pull/138#discussion_r265735188
##
File path: webapps/docs/ssi-howto.xml
##
@@ -146,27 +146,53 @@ false.
The directives are:
-config -
nightwatchcyber commented on a change in pull request #138: Expanding SSI
documentation (bug # 63184)
URL: https://github.com/apache/tomcat/pull/138#discussion_r265823744
##
File path: webapps/docs/ssi-howto.xml
##
@@ -146,27 +146,53 @@ false.
The directives are:
-con
nightwatchcyber commented on a change in pull request #138: Expanding SSI
documentation (bug # 63184)
URL: https://github.com/apache/tomcat/pull/138#discussion_r265823838
##
File path: webapps/docs/ssi-howto.xml
##
@@ -146,27 +146,53 @@ false.
The directives are:
-con
nightwatchcyber commented on a change in pull request #138: Expanding SSI
documentation (bug # 63184)
URL: https://github.com/apache/tomcat/pull/138#discussion_r265823823
##
File path: webapps/docs/ssi-howto.xml
##
@@ -146,27 +146,53 @@ false.
The directives are:
-con
nightwatchcyber commented on a change in pull request #138: Expanding SSI
documentation (bug # 63184)
URL: https://github.com/apache/tomcat/pull/138#discussion_r265823804
##
File path: webapps/docs/ssi-howto.xml
##
@@ -146,27 +146,53 @@ false.
The directives are:
-con
nightwatchcyber commented on issue #138: Expanding SSI documentation (bug #
63184)
URL: https://github.com/apache/tomcat/pull/138#issuecomment-473127992
I updated the pull request - let me if that works
This is an automated m
KeiichiFujino commented on issue #140: jdbc-pool: Improve maxAge handling
URL: https://github.com/apache/tomcat/pull/140#issuecomment-473176479
> I fixed the missing calls to PooledConnection#validate(int).
Thanks.
> Looking at the code it seems that the timestamp shoul
KeiichiFujino commented on issue #140: jdbc-pool: Improve maxAge handling
URL: https://github.com/apache/tomcat/pull/140#issuecomment-473180351
Personally, the primary factor in starting PoolCleaner should be
timeBetweenEvictionRunsMillis.
Same as removeAbandoned / testWhileIdle / minEvi
markt-asf commented on issue #138: Expanding SSI documentation (bug # 63184)
URL: https://github.com/apache/tomcat/pull/138#issuecomment-473210613
Looks like you merged in changes from trunk rather than rebasing your PR and
doing a forced push. I'll see if I can unpick this.
--
markt-asf closed pull request #138: Expanding SSI documentation (bug # 63184)
URL: https://github.com/apache/tomcat/pull/138
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
markt-asf commented on issue #138: Expanding SSI documentation (bug # 63184)
URL: https://github.com/apache/tomcat/pull/138#issuecomment-473248983
Applied manually.
This is an automated message from the Apache Git Service.
To
toby1984 commented on issue #140: jdbc-pool: Improve maxAge handling
URL: https://github.com/apache/tomcat/pull/140#issuecomment-473394845
Thanks for taking the time to look at my changes! I totally missed the code
dealing with dynamic reconfiguration through JMX.
I changed my code t
KeiichiFujino commented on issue #140: jdbc-pool: Improve maxAge handling
URL: https://github.com/apache/tomcat/pull/140#issuecomment-473776997
Thanks for the fix.
I have no objections to the current code.
I'll merge this into master branch.
---
salgattas opened a new pull request #149: Adding ReDoS warning/documentation to
RewriteValve
URL: https://github.com/apache/tomcat/pull/149
After reporting a potential DoS in "Rewrite Rules" to the Tomcat security
team, it was decided that there was no bug in Tomcat itself, but rather in h
KeiichiFujino closed pull request #140: jdbc-pool: Improve maxAge handling
URL: https://github.com/apache/tomcat/pull/140
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
tcollignon opened a new pull request #150: Add compiler source and target
support for all Java versions over 10
URL: https://github.com/apache/tomcat/pull/150
Hi,
I maintain the maven plugin to compile JSP :
https://github.com/leonardehrenfried/jspc-maven-plugin
We have recei
markt-asf commented on issue #150: Add compiler source and target support for
all Java versions over 10
URL: https://github.com/apache/tomcat/pull/150#issuecomment-474829632
We want to keep the allowed values to the valid ones. 7.0.x has the right
sort of code in place for Java 10 support.
tcollignon commented on issue #150: Add compiler source and target support for
all Java versions over 10
URL: https://github.com/apache/tomcat/pull/150#issuecomment-474831606
Thx for your anwser
So I will wait for ECJ right ?
Or maybe I can try to add options to Java 11 in ECJ ?
---
markt-asf commented on issue #150: Add compiler source and target support for
all Java versions over 10
URL: https://github.com/apache/tomcat/pull/150#issuecomment-474861978
What I meant was:
- we should check for ECJ updates (I'm doing that now)
- we should replicate the way Java 10
tcollignon commented on issue #150: Add compiler source and target support for
all Java versions over 10
URL: https://github.com/apache/tomcat/pull/150#issuecomment-474872724
Ok sorry I didn't understand the first comment
So I will update the PR like you said
---
markt-asf commented on issue #150: Add compiler source and target support for
all Java versions over 10
URL: https://github.com/apache/tomcat/pull/150#issuecomment-474873975
I actually just done this for Java 11. Could you do the same for Java 12?
--
tcollignon commented on issue #150: Add compiler source and target support for
all Java versions over 10
URL: https://github.com/apache/tomcat/pull/150#issuecomment-474878836
Ok I have add 11 and 12, I wait for your commit, and I will update this with
just 12 if necessary
thx
-
markt-asf commented on issue #149: Adding ReDoS warning/documentation to
RewriteValve
URL: https://github.com/apache/tomcat/pull/149#issuecomment-475172395
That page is generated from this file:
https://github.com/apache/tomcat/blob/master/webapps/docs/rewrite.xml
--
tcollignon commented on issue #150: Add compiler source and target support for
all Java versions over 10
URL: https://github.com/apache/tomcat/pull/150#issuecomment-475179366
Hi
I have update the code, and squash commit
Tell me if it's ok for you
thx
--
markt-asf commented on issue #150: Add compiler source and target support for
all Java versions over 10
URL: https://github.com/apache/tomcat/pull/150#issuecomment-475197867
Hmm. If you pass "12" or "13" directly to ECJ it silently switches to the
latest version it knows - currently 11. Wh
markt-asf commented on issue #150: Add compiler source and target support for
all Java versions over 10
URL: https://github.com/apache/tomcat/pull/150#issuecomment-475214511
Thanks. I took your patch and extended to cover Java 13 as well and added a
check to log a warning if an unsupported
markt-asf closed pull request #150: Add compiler source and target support for
all Java versions over 10
URL: https://github.com/apache/tomcat/pull/150
This is an automated message from the Apache Git Service.
To respond to
1 - 100 of 3209 matches
Mail list logo
