philwebb commented on issue #142: Defer creation of encodingToCharsetCache URL: https://github.com/apache/tomcat/pull/142#issuecomment-470280939 I've pushed an update following the discussion on https://bz.apache.org/bugzilla/show_bug.cgi?id=63235 @rmaucher > If there is a lookup with Charset.forName, then would the cache be used at all Correct. The updated code relies on the [internal cache](https://github.com/openjdk-mirror/jdk7u-jdk/blob/f4d80957e89a19a29bb9f9807d2a28351ed7f7df/src/share/classes/java/nio/charset/Charset.java#L465-L498) that the `Charset` class uses. > I don't understand this sort of Windows style "startup time" optimization, where you hide stuff behind making running actual application code slower I don't know what you mean by "Windows style startup time optimization". Why would the actual actual application code now be slower?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
